source: josm/trunk/test/unit/org/openstreetmap/josm/command/ChangeCommandTest.java@ 17275

Last change on this file since 17275 was 17275, checked in by Don-vip, 3 years ago

see #16567 - upgrade almost all tests to JUnit 5, except those depending on WiremockRule

See https://github.com/tomakehurst/wiremock/issues/684

File size: 6.1 KB
Line 
1// License: GPL. For details, see LICENSE file.
2package org.openstreetmap.josm.command;
3
4import static org.junit.jupiter.api.Assertions.assertArrayEquals;
5import static org.junit.jupiter.api.Assertions.assertEquals;
6import static org.junit.jupiter.api.Assertions.assertNull;
7import static org.junit.jupiter.api.Assertions.assertTrue;
8import static org.junit.jupiter.api.Assertions.assertThrows;
9
10import java.util.ArrayList;
11import java.util.Collections;
12import java.util.List;
13
14import org.junit.jupiter.api.BeforeEach;
15import org.junit.jupiter.api.Test;
16import org.junit.jupiter.api.extension.RegisterExtension;
17import org.openstreetmap.josm.TestUtils;
18import org.openstreetmap.josm.command.CommandTest.CommandTestData;
19import org.openstreetmap.josm.data.coor.LatLon;
20import org.openstreetmap.josm.data.osm.DataIntegrityProblemException;
21import org.openstreetmap.josm.data.osm.DataSet;
22import org.openstreetmap.josm.data.osm.Node;
23import org.openstreetmap.josm.data.osm.OsmPrimitive;
24import org.openstreetmap.josm.data.osm.Relation;
25import org.openstreetmap.josm.data.osm.User;
26import org.openstreetmap.josm.data.osm.Way;
27import org.openstreetmap.josm.gui.layer.OsmDataLayer;
28import org.openstreetmap.josm.testutils.JOSMTestRules;
29
30import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
31import nl.jqno.equalsverifier.EqualsVerifier;
32import nl.jqno.equalsverifier.Warning;
33
34/**
35 * Unit tests of {@link ChangeCommand} class.
36 */
37class ChangeCommandTest {
38
39 /**
40 * We need prefs for nodes.
41 */
42 @RegisterExtension
43 @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
44 public JOSMTestRules test = new JOSMTestRules().preferences().i18n();
45 private CommandTestData testData;
46
47 /**
48 * Set up the test data.
49 */
50 @BeforeEach
51 public void createTestData() {
52 testData = new CommandTestData();
53 }
54
55 /**
56 * Test that empty ways are prevented.
57 */
58 @Test
59 void testPreventEmptyWays() {
60 Way emptyWay = new Way();
61 assertThrows(IllegalArgumentException.class, () -> new ChangeCommand(testData.existingWay, emptyWay));
62 }
63
64 /**
65 * Test {@link ChangeCommand#executeCommand()}
66 */
67 @Test
68 void testChange() {
69 Node newNode = new Node(5);
70 newNode.setCoor(LatLon.NORTH_POLE);
71 newNode.put("new", "new");
72
73 new ChangeCommand(testData.existingNode, newNode).executeCommand();
74
75 assertEquals("new", testData.existingNode.get("new"));
76 assertEquals(null, testData.existingNode.get("existing"));
77 assertEquals(LatLon.NORTH_POLE, testData.existingNode.getCoor());
78
79 Way newWay = new Way(10);
80 List<Node> newNodes = testData.existingWay.getNodes();
81 Collections.reverse(newNodes);
82 newWay.setNodes(newNodes);
83
84 new ChangeCommand(testData.existingWay, newWay).executeCommand();
85 assertArrayEquals(newNodes.toArray(), testData.existingWay.getNodes().toArray());
86 }
87
88 /**
89 * Test {@link ChangeCommand#executeCommand()} fails if ID is changed
90 */
91 @Test
92 void testChangeIdChange() {
93 Node newNode = new Node(1);
94 newNode.setCoor(LatLon.NORTH_POLE);
95
96 assertThrows(DataIntegrityProblemException.class, () -> new ChangeCommand(testData.existingNode, newNode).executeCommand());
97 }
98
99 /**
100 * Test {@link ChangeCommand#undoCommand()}
101 */
102 @Test
103 void testUndo() {
104 Node newNode = new Node(5);
105 newNode.setCoor(LatLon.NORTH_POLE);
106 newNode.put("new", "new");
107
108 ChangeCommand command = new ChangeCommand(testData.existingNode, newNode);
109 command.executeCommand();
110
111 assertEquals("new", testData.existingNode.get("new"));
112 assertEquals(LatLon.NORTH_POLE, testData.existingNode.getCoor());
113
114 command.undoCommand();
115 assertNull(testData.existingNode.get("new"));
116 assertEquals("existing", testData.existingNode.get("existing"));
117 assertEquals(LatLon.ZERO, testData.existingNode.getCoor());
118 }
119
120 /**
121 * Tests {@link ChangeCommand#fillModifiedData(java.util.Collection, java.util.Collection, java.util.Collection)}
122 */
123 @Test
124 void testFillModifiedData() {
125 ArrayList<OsmPrimitive> modified = new ArrayList<>();
126 ArrayList<OsmPrimitive> deleted = new ArrayList<>();
127 ArrayList<OsmPrimitive> added = new ArrayList<>();
128 new ChangeCommand(testData.existingNode, testData.existingNode).fillModifiedData(modified, deleted, added);
129 assertArrayEquals(new Object[] {testData.existingNode}, modified.toArray());
130 assertArrayEquals(new Object[] {}, deleted.toArray());
131 assertArrayEquals(new Object[] {}, added.toArray());
132 }
133
134 /**
135 * Test {@link ChangeCommand#getDescriptionText()}
136 */
137 @Test
138 void testDescription() {
139 Node node = new Node(LatLon.ZERO);
140 node.put("name", "xy");
141 Way way = new Way();
142 way.addNode(node);
143 way.put("name", "xy");
144 Relation relation = new Relation();
145 relation.put("name", "xy");
146 DataSet ds = new DataSet(node, way, relation);
147
148 assertTrue(new ChangeCommand(ds, node, node).getDescriptionText().matches("Change node.*xy.*"));
149 assertTrue(new ChangeCommand(ds, way, way).getDescriptionText().matches("Change way.*xy.*"));
150 assertTrue(new ChangeCommand(ds, relation, relation).getDescriptionText().matches("Change relation.*xy.*"));
151 }
152
153 /**
154 * Unit test of methods {@link ChangeCommand#equals} and {@link ChangeCommand#hashCode}.
155 */
156 @Test
157 void testEqualsContract() {
158 TestUtils.assumeWorkingEqualsVerifier();
159 EqualsVerifier.forClass(ChangeCommand.class).usingGetClass()
160 .withPrefabValues(DataSet.class,
161 new DataSet(), new DataSet())
162 .withPrefabValues(User.class,
163 User.createOsmUser(1, "foo"), User.createOsmUser(2, "bar"))
164 .withPrefabValues(OsmPrimitive.class,
165 new Node(1), new Node(2))
166 .withPrefabValues(OsmDataLayer.class,
167 new OsmDataLayer(new DataSet(), "1", null), new OsmDataLayer(new DataSet(), "2", null))
168 .suppress(Warning.NONFINAL_FIELDS)
169 .verify();
170 }
171}
Note: See TracBrowser for help on using the repository browser.