source: josm/trunk/test/unit/org/openstreetmap/josm/actions/corrector/ReverseWayTagCorrectorTest.java@ 14256

Last change on this file since 14256 was 14256, checked in by Don-vip, 6 years ago

see #15229 - move corrector package to actions.corrector

  • Property svn:eol-style set to native
File size: 6.6 KB
Line 
1// License: GPL. For details, see LICENSE file.
2package org.openstreetmap.josm.actions.corrector;
3
4import java.util.Collections;
5import java.util.List;
6import java.util.Map;
7import java.util.stream.Stream;
8
9import org.junit.Assert;
10import org.junit.Rule;
11import org.junit.Test;
12import org.openstreetmap.josm.data.correction.TagCorrection;
13import org.openstreetmap.josm.data.osm.Node;
14import org.openstreetmap.josm.data.osm.OsmPrimitive;
15import org.openstreetmap.josm.data.osm.OsmUtils;
16import org.openstreetmap.josm.data.osm.Tag;
17import org.openstreetmap.josm.data.osm.Way;
18import org.openstreetmap.josm.testutils.JOSMTestRules;
19
20import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
21import net.trajano.commons.testing.UtilityClassTestUtil;
22
23/**
24 * Unit tests of {@link ReverseWayTagCorrector} class.
25 */
26public class ReverseWayTagCorrectorTest {
27
28 /**
29 * Setup test.
30 */
31 @Rule
32 @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
33 public JOSMTestRules test = new JOSMTestRules();
34
35 /**
36 * Tests that {@code ReverseWayTagCorrector.TagSwitcher} satisfies utility class criterias.
37 * @throws ReflectiveOperationException if an error occurs
38 */
39 @Test
40 public void testUtilityClass() throws ReflectiveOperationException {
41 UtilityClassTestUtil.assertUtilityClassWellDefined(ReverseWayTagCorrector.TagSwitcher.class);
42 }
43
44 /**
45 * Test of {@link ReverseWayTagCorrector.TagSwitcher#apply} method.
46 */
47 @Test
48 public void testTagSwitch() {
49 // oneway
50 assertSwitch(new Tag("oneway", "yes"), new Tag("oneway", "-1"));
51 assertSwitch(new Tag("oneway", "true"), new Tag("oneway", "-1"));
52 assertSwitch(new Tag("oneway", "-1"), new Tag("oneway", "yes"));
53 assertSwitch(new Tag("oneway", "no"), new Tag("oneway", "no"));
54 assertSwitch(new Tag("oneway", "something"), new Tag("oneway", "something"));
55 // incline/direction
56 for (String k : new String[]{"incline", "direction"}) {
57 assertSwitch(new Tag(k, "up"), new Tag(k, "down"));
58 assertSwitch(new Tag(k, "down"), new Tag(k, "up"));
59 assertSwitch(new Tag(k, "something"), new Tag(k, "something"));
60 }
61 // direction=forward/backward/...
62 assertSwitch(new Tag("direction", "forward"), new Tag("direction", "backward"));
63 assertSwitch(new Tag("direction", "backward"), new Tag("direction", "forward"));
64 // :left/:right with oneway (see #10977)
65 assertSwitch(new Tag("cycleway:left:oneway", "-1"), new Tag("cycleway:right:oneway", "yes"));
66 // :forward/:backward (see #8518)
67 assertSwitch(new Tag("turn:forward", "right"), new Tag("turn:backward", "right"));
68 assertSwitch(new Tag("change:forward", "not_right"), new Tag("change:backward", "not_right"));
69 assertSwitch(new Tag("placement:forward", "right_of:1"), new Tag("placement:backward", "right_of:1"));
70 assertSwitch(new Tag("turn:lanes:forward", "left|right"), new Tag("turn:lanes:backward", "left|right"));
71 assertSwitch(new Tag("change:lanes:forward", "not_right|only_left"), new Tag("change:lanes:backward", "not_right|only_left"));
72 // keys
73 assertSwitch(new Tag("forward", "something"), new Tag("backward", "something"));
74 assertSwitch(new Tag("backward", "something"), new Tag("forward", "something"));
75 assertSwitch(new Tag("up", "something"), new Tag("down", "something"));
76 assertSwitch(new Tag("down", "something"), new Tag("up", "something"));
77 // values
78 assertSwitch(new Tag("something", "forward"), new Tag("something", "backward"));
79 assertSwitch(new Tag("something", "backward"), new Tag("something", "forward"));
80 assertSwitch(new Tag("something", "up"), new Tag("something", "down"));
81 assertSwitch(new Tag("something", "down"), new Tag("something", "up"));
82 // value[:_]suffix
83 assertSwitch(new Tag("something", "forward:suffix"), new Tag("something", "backward:suffix"));
84 assertSwitch(new Tag("something", "backward_suffix"), new Tag("something", "forward_suffix"));
85 assertSwitch(new Tag("something", "up:suffix"), new Tag("something", "down:suffix"));
86 assertSwitch(new Tag("something", "down_suffix"), new Tag("something", "up_suffix"));
87 // prefix[:_]value
88 assertSwitch(new Tag("something", "prefix:forward"), new Tag("something", "prefix:backward"));
89 assertSwitch(new Tag("something", "prefix_backward"), new Tag("something", "prefix_forward"));
90 assertSwitch(new Tag("something", "prefix:up"), new Tag("something", "prefix:down"));
91 assertSwitch(new Tag("something", "prefix_down"), new Tag("something", "prefix_up"));
92 // prefix[:_]value[:_]suffix
93 assertSwitch(new Tag("something", "prefix:forward:suffix"), new Tag("something", "prefix:backward:suffix"));
94 assertSwitch(new Tag("something", "prefix_backward:suffix"), new Tag("something", "prefix_forward:suffix"));
95 assertSwitch(new Tag("something", "prefix:up_suffix"), new Tag("something", "prefix:down_suffix"));
96 assertSwitch(new Tag("something", "prefix_down_suffix"), new Tag("something", "prefix_up_suffix"));
97 // #8499
98 assertSwitch(new Tag("type", "drawdown"), new Tag("type", "drawdown"));
99 }
100
101 private void assertSwitch(Tag oldTag, Tag newTag) {
102 Assert.assertEquals(ReverseWayTagCorrector.TagSwitcher.apply(oldTag), newTag);
103 }
104
105 private Map<OsmPrimitive, List<TagCorrection>> getTagCorrectionsForWay(String middleNodeTags) {
106 final OsmPrimitive n1 = OsmUtils.createPrimitive("node");
107 final OsmPrimitive n2 = OsmUtils.createPrimitive("node " + middleNodeTags);
108 final OsmPrimitive n3 = OsmUtils.createPrimitive("node");
109 final Way w = new Way();
110 Stream.of(n1, n2, n3).map(Node.class::cast).forEach(w::addNode);
111 return ReverseWayTagCorrector.getTagCorrectionsMap(w);
112 }
113
114 /**
115 * Test tag correction on way nodes
116 */
117 @Test
118 public void testSwitchingWayNodes() {
119 final Map<OsmPrimitive, List<TagCorrection>> tagCorrections = getTagCorrectionsForWay("direction=forward");
120 Assert.assertEquals(1, tagCorrections.size());
121 Assert.assertEquals(Collections.singletonList(new TagCorrection("direction", "forward", "direction", "backward")),
122 tagCorrections.values().iterator().next());
123 }
124
125 /**
126 * Test tag correction on way nodes are not applied for absolute values such as compass cardinal directions
127 */
128 @Test
129 public void testNotSwitchingWayNodes() {
130 Assert.assertEquals(0, getTagCorrectionsForWay("direction=SSW").size());
131 Assert.assertEquals(0, getTagCorrectionsForWay("direction=145").size());
132 }
133}
Note: See TracBrowser for help on using the repository browser.