1 | // License: GPL. For details, see LICENSE file.
|
---|
2 | package org.openstreetmap.josm.actions;
|
---|
3 |
|
---|
4 | import static org.junit.jupiter.api.Assertions.assertEquals;
|
---|
5 | import static org.junit.jupiter.api.Assertions.assertFalse;
|
---|
6 | import static org.junit.jupiter.api.Assertions.assertNotNull;
|
---|
7 | import static org.junit.jupiter.api.Assertions.assertTrue;
|
---|
8 |
|
---|
9 | import java.nio.file.Files;
|
---|
10 | import java.nio.file.Paths;
|
---|
11 | import java.util.Collection;
|
---|
12 | import java.util.Map;
|
---|
13 | import java.util.TreeMap;
|
---|
14 |
|
---|
15 | import org.junit.jupiter.api.Test;
|
---|
16 | import org.junit.jupiter.api.extension.RegisterExtension;
|
---|
17 | import org.openstreetmap.josm.TestUtils;
|
---|
18 | import org.openstreetmap.josm.command.SequenceCommand;
|
---|
19 | import org.openstreetmap.josm.data.osm.DataSet;
|
---|
20 | import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
|
---|
21 | import org.openstreetmap.josm.data.osm.Relation;
|
---|
22 | import org.openstreetmap.josm.data.osm.RelationMember;
|
---|
23 | import org.openstreetmap.josm.data.osm.Way;
|
---|
24 | import org.openstreetmap.josm.data.osm.search.SearchCompiler;
|
---|
25 | import org.openstreetmap.josm.data.osm.search.SearchParseError;
|
---|
26 | import org.openstreetmap.josm.data.osm.search.SearchSetting;
|
---|
27 | import org.openstreetmap.josm.gui.MainApplication;
|
---|
28 | import org.openstreetmap.josm.gui.layer.Layer;
|
---|
29 | import org.openstreetmap.josm.gui.layer.OsmDataLayer;
|
---|
30 | import org.openstreetmap.josm.io.OsmReader;
|
---|
31 | import org.openstreetmap.josm.testutils.JOSMTestRules;
|
---|
32 | import org.openstreetmap.josm.tools.Pair;
|
---|
33 | import org.openstreetmap.josm.tools.SubclassFilteredCollection;
|
---|
34 |
|
---|
35 | import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
|
---|
36 |
|
---|
37 | /**
|
---|
38 | * Unit test of {@link CreateMultipolygonAction}
|
---|
39 | */
|
---|
40 | class CreateMultipolygonActionTest {
|
---|
41 |
|
---|
42 | /**
|
---|
43 | * Setup test.
|
---|
44 | */
|
---|
45 | @RegisterExtension
|
---|
46 | @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
|
---|
47 | public JOSMTestRules test = new JOSMTestRules().projection().main().preferences();
|
---|
48 |
|
---|
49 | private static Map<String, String> getRefToRoleMap(Relation relation) {
|
---|
50 | Map<String, String> refToRole = new TreeMap<>();
|
---|
51 | String ref = relation.get("ref");
|
---|
52 | if (ref != null) {
|
---|
53 | refToRole.put(ref, "outer");
|
---|
54 | }
|
---|
55 | for (RelationMember i : relation.getMembers()) {
|
---|
56 | ref = i.getMember().get("ref");
|
---|
57 | if (ref != null) {
|
---|
58 | refToRole.put(ref, i.getRole());
|
---|
59 | }
|
---|
60 | }
|
---|
61 | return refToRole;
|
---|
62 | }
|
---|
63 |
|
---|
64 | private static SearchSetting regexpSearch(String search) {
|
---|
65 | SearchSetting setting = new SearchSetting();
|
---|
66 | setting.text = search;
|
---|
67 | setting.regexSearch = true;
|
---|
68 | return setting;
|
---|
69 | }
|
---|
70 |
|
---|
71 | @SuppressWarnings("unchecked")
|
---|
72 | private static Relation createMultipolygon(Collection<Way> ways, String pattern, Relation r, boolean runCmd)
|
---|
73 | throws SearchParseError {
|
---|
74 | Pair<SequenceCommand, Relation> cmd = CreateMultipolygonAction.createMultipolygonCommand(
|
---|
75 | (Collection<Way>) (Collection<?>) SubclassFilteredCollection.filter(ways, SearchCompiler.compile(regexpSearch(pattern))), r);
|
---|
76 | if (runCmd) {
|
---|
77 | cmd.a.executeCommand();
|
---|
78 | }
|
---|
79 | return cmd.b;
|
---|
80 | }
|
---|
81 |
|
---|
82 | @Test
|
---|
83 | void testCreate1() throws Exception {
|
---|
84 | DataSet ds = OsmReader.parseDataSet(Files.newInputStream(Paths.get(TestUtils.getTestDataRoot(), "create_multipolygon.osm")), null);
|
---|
85 | Pair<SequenceCommand, Relation> mp = CreateMultipolygonAction.createMultipolygonCommand(ds.getWays(), null);
|
---|
86 | assertEquals("Sequence: Create multipolygon", mp.a.getDescriptionText());
|
---|
87 | assertEquals("{1=outer, 1.1=inner, 1.1.1=outer, 1.1.2=outer, 1.2=inner}", getRefToRoleMap(mp.b).toString());
|
---|
88 | }
|
---|
89 |
|
---|
90 | @Test
|
---|
91 | void testCreate2() throws Exception {
|
---|
92 | DataSet ds = OsmReader.parseDataSet(Files.newInputStream(Paths.get(TestUtils.getTestDataRoot(), "create_multipolygon.osm")), null);
|
---|
93 | Relation mp = createMultipolygon(ds.getWays(), "ref=1 OR ref:1.1.", null, true);
|
---|
94 | assertEquals("{1=outer, 1.1.1=inner, 1.1.2=inner}", getRefToRoleMap(mp).toString());
|
---|
95 | }
|
---|
96 |
|
---|
97 | @Test
|
---|
98 | void testUpdate1() throws Exception {
|
---|
99 | DataSet ds = OsmReader.parseDataSet(Files.newInputStream(Paths.get(TestUtils.getTestDataRoot(), "create_multipolygon.osm")), null);
|
---|
100 | Relation mp = createMultipolygon(ds.getWays(), "ref=\".*1$\"", null, true);
|
---|
101 | assertEquals(3, mp.getMembersCount());
|
---|
102 | assertEquals("{1=outer, 1.1=inner, 1.1.1=outer}", getRefToRoleMap(mp).toString());
|
---|
103 | Relation mp2 = createMultipolygon(ds.getWays(), "ref=1.2", mp, true);
|
---|
104 | assertEquals(4, mp2.getMembersCount());
|
---|
105 | assertEquals("{1=outer, 1.1=inner, 1.1.1=outer, 1.2=inner}", getRefToRoleMap(mp2).toString());
|
---|
106 | }
|
---|
107 |
|
---|
108 | @Test
|
---|
109 | void testUpdate2() throws Exception {
|
---|
110 | DataSet ds = OsmReader.parseDataSet(Files.newInputStream(Paths.get(TestUtils.getTestDataRoot(), "create_multipolygon.osm")), null);
|
---|
111 | Relation mp = createMultipolygon(ds.getWays(), "ref=1 OR ref:1.1.1", null, true);
|
---|
112 | assertEquals("{1=outer, 1.1.1=inner}", getRefToRoleMap(mp).toString());
|
---|
113 | Relation mp2 = createMultipolygon(ds.getWays(), "ref=1.1 OR ref=1.2 OR ref=1.1.2", mp, false);
|
---|
114 | assertEquals("{1=outer, 1.1=inner, 1.1.1=outer, 1.1.2=outer, 1.2=inner}", getRefToRoleMap(mp2).toString());
|
---|
115 | }
|
---|
116 |
|
---|
117 | /**
|
---|
118 | * Non-regression test for <a href="https://josm.openstreetmap.de/ticket/17767">Bug #17767</a>.
|
---|
119 | * @throws Exception if an error occurs
|
---|
120 | */
|
---|
121 | @Test
|
---|
122 | void testTicket17767() throws Exception {
|
---|
123 | DataSet ds = OsmReader.parseDataSet(TestUtils.getRegressionDataStream(17767, "upd-mp.osm"), null);
|
---|
124 | Layer layer = new OsmDataLayer(ds, null, null);
|
---|
125 | MainApplication.getLayerManager().addLayer(layer);
|
---|
126 | try {
|
---|
127 | CreateMultipolygonAction updateAction = new CreateMultipolygonAction(true);
|
---|
128 | CreateMultipolygonAction createAction = new CreateMultipolygonAction(false);
|
---|
129 | assertFalse(updateAction.isEnabled());
|
---|
130 | assertFalse(createAction.isEnabled());
|
---|
131 | ds.setSelected(ds.getPrimitiveById(189944949L, OsmPrimitiveType.WAY));
|
---|
132 | assertFalse(updateAction.isEnabled());
|
---|
133 | assertTrue(createAction.isEnabled());
|
---|
134 | } finally {
|
---|
135 | MainApplication.getLayerManager().removeLayer(layer);
|
---|
136 | }
|
---|
137 | }
|
---|
138 |
|
---|
139 | /**
|
---|
140 | * Non-regression test for <a href="https://josm.openstreetmap.de/ticket/17768">Bug #17768</a>.
|
---|
141 | * @throws Exception if an error occurs
|
---|
142 | */
|
---|
143 | @Test
|
---|
144 | void testTicket17768() throws Exception {
|
---|
145 | DataSet ds = OsmReader.parseDataSet(TestUtils.getRegressionDataStream(17768, "dupmem.osm"), null);
|
---|
146 | Layer layer = new OsmDataLayer(ds, null, null);
|
---|
147 | MainApplication.getLayerManager().addLayer(layer);
|
---|
148 | try {
|
---|
149 | Relation old = (Relation) ds.getPrimitiveById(580092, OsmPrimitiveType.RELATION);
|
---|
150 | assertEquals(3, old.getMembersCount());
|
---|
151 | Relation mp = createMultipolygon(ds.getWays(), "type:way", old, true);
|
---|
152 | assertEquals(mp.getPrimitiveId(), old.getPrimitiveId());
|
---|
153 | assertEquals(2, mp.getMembersCount());
|
---|
154 | } finally {
|
---|
155 | MainApplication.getLayerManager().removeLayer(layer);
|
---|
156 | }
|
---|
157 |
|
---|
158 | }
|
---|
159 |
|
---|
160 | /**
|
---|
161 | * Non-regression test for <a href="https://josm.openstreetmap.de/ticket/20110">Bug #20110</a>.
|
---|
162 | * @throws Exception if an error occurs
|
---|
163 | */
|
---|
164 | @Test
|
---|
165 | void testTicket20110() throws Exception {
|
---|
166 | DataSet ds = OsmReader.parseDataSet(TestUtils.getRegressionDataStream(20110, "data.osm"), null);
|
---|
167 | assertEquals(1, ds.getRelations().size());
|
---|
168 | Relation mp = ds.getRelations().iterator().next();
|
---|
169 | assertEquals("wetland", mp.get("natural"));
|
---|
170 | long numCoastlineWays = ds.getWays().stream().filter(w -> "coastline".equals(w.get("natural"))).count();
|
---|
171 | Relation modMp = createMultipolygon(ds.getWays(), "type:way", mp, false);
|
---|
172 | assertNotNull(modMp);
|
---|
173 | assertEquals("wetland", modMp.get("natural"));
|
---|
174 | assertEquals(numCoastlineWays, ds.getWays().stream().filter(w -> "coastline".equals(w.get("natural"))).count());
|
---|
175 | }
|
---|
176 | }
|
---|