source: josm/trunk/src/org/openstreetmap/josm/data/validation/util/ValUtil.java@ 16119

Last change on this file since 16119 was 16119, checked in by Don-vip, 4 years ago

fix #18928 - fix various crashes with empty ways

  • Property svn:eol-style set to native
File size: 6.1 KB
Line 
1// License: GPL. For details, see LICENSE file.
2package org.openstreetmap.josm.data.validation.util;
3
4import java.awt.geom.Point2D;
5import java.util.ArrayList;
6import java.util.Collections;
7import java.util.HashSet;
8import java.util.List;
9import java.util.Map;
10import java.util.Set;
11
12import org.openstreetmap.josm.data.coor.EastNorth;
13import org.openstreetmap.josm.data.osm.Node;
14import org.openstreetmap.josm.data.osm.Way;
15import org.openstreetmap.josm.data.validation.OsmValidator;
16import org.openstreetmap.josm.tools.CheckParameterUtil;
17
18/**
19 * Utility class
20 *
21 * @author frsantos
22 */
23public final class ValUtil {
24
25 private ValUtil() {
26 // Hide default constructor for utils classes
27 }
28
29 /**
30 * Returns the start and end cells of a way.
31 * @param w The way
32 * @param cellWays The map with all cells
33 * @return A list with all the cells the way starts or ends
34 */
35 public static List<List<Way>> getWaysInCell(Way w, Map<Point2D, List<Way>> cellWays) {
36 if (w.isEmpty())
37 return Collections.emptyList();
38
39 Node n1 = w.getNode(0);
40 Node n2 = w.getNode(w.getNodesCount() - 1);
41
42 List<List<Way>> cells = new ArrayList<>(2);
43 Set<Point2D> cellNodes = new HashSet<>();
44 Point2D cell;
45 double griddetail = OsmValidator.getGridDetail();
46
47 // First, round coordinates
48 // CHECKSTYLE.OFF: SingleSpaceSeparator
49 long x0 = Math.round(n1.getEastNorth().east() * griddetail);
50 long y0 = Math.round(n1.getEastNorth().north() * griddetail);
51 long x1 = Math.round(n2.getEastNorth().east() * griddetail);
52 long y1 = Math.round(n2.getEastNorth().north() * griddetail);
53 // CHECKSTYLE.ON: SingleSpaceSeparator
54
55 // Start of the way
56 cell = new Point2D.Double(x0, y0);
57 cellNodes.add(cell);
58 cells.add(cellWays.computeIfAbsent(cell, k -> new ArrayList<>()));
59
60 // End of the way
61 cell = new Point2D.Double(x1, y1);
62 if (!cellNodes.contains(cell)) {
63 cellNodes.add(cell);
64 cells.add(cellWays.computeIfAbsent(cell, k -> new ArrayList<>()));
65 }
66
67 // Then floor coordinates, in case the way is in the border of the cell.
68 // CHECKSTYLE.OFF: SingleSpaceSeparator
69 x0 = (long) Math.floor(n1.getEastNorth().east() * griddetail);
70 y0 = (long) Math.floor(n1.getEastNorth().north() * griddetail);
71 x1 = (long) Math.floor(n2.getEastNorth().east() * griddetail);
72 y1 = (long) Math.floor(n2.getEastNorth().north() * griddetail);
73 // CHECKSTYLE.ON: SingleSpaceSeparator
74
75 // Start of the way
76 cell = new Point2D.Double(x0, y0);
77 if (!cellNodes.contains(cell)) {
78 cellNodes.add(cell);
79 cells.add(cellWays.computeIfAbsent(cell, k -> new ArrayList<>()));
80 }
81
82 // End of the way
83 cell = new Point2D.Double(x1, y1);
84 if (!cellNodes.contains(cell)) {
85 cellNodes.add(cell);
86 cells.add(cellWays.computeIfAbsent(cell, k -> new ArrayList<>()));
87 }
88 return cells;
89 }
90
91 /**
92 * Returns the coordinates of all cells in a grid that a line between 2 nodes intersects with.
93 *
94 * @param n1 The first node.
95 * @param n2 The second node.
96 * @param gridDetail The detail of the grid. Bigger values give smaller
97 * cells, but a bigger number of them.
98 * @return A list with the coordinates of all cells
99 * @throws IllegalArgumentException if n1 or n2 is {@code null} or without coordinates
100 */
101 public static List<Point2D> getSegmentCells(Node n1, Node n2, double gridDetail) {
102 CheckParameterUtil.ensureParameterNotNull(n1, "n1");
103 CheckParameterUtil.ensureParameterNotNull(n1, "n2");
104 return getSegmentCells(n1.getEastNorth(), n2.getEastNorth(), gridDetail);
105 }
106
107 /**
108 * Returns the coordinates of all cells in a grid that a line between 2 nodes intersects with.
109 *
110 * @param en1 The first EastNorth.
111 * @param en2 The second EastNorth.
112 * @param gridDetail The detail of the grid. Bigger values give smaller
113 * cells, but a bigger number of them.
114 * @return A list with the coordinates of all cells
115 * @throws IllegalArgumentException if en1 or en2 is {@code null}
116 * @since 6869
117 */
118 public static List<Point2D> getSegmentCells(EastNorth en1, EastNorth en2, double gridDetail) {
119 CheckParameterUtil.ensureParameterNotNull(en1, "en1");
120 CheckParameterUtil.ensureParameterNotNull(en2, "en2");
121 List<Point2D> cells = new ArrayList<>();
122 double x0 = en1.east() * gridDetail;
123 double x1 = en2.east() * gridDetail;
124 double y0 = en1.north() * gridDetail + 1;
125 double y1 = en2.north() * gridDetail + 1;
126
127 if (x0 > x1) {
128 // Move to 1st-4th cuadrants
129 double aux;
130 aux = x0; x0 = x1; x1 = aux;
131 aux = y0; y0 = y1; y1 = aux;
132 }
133
134 double dx = x1 - x0;
135 double dy = y1 - y0;
136 long stepY = y0 <= y1 ? 1 : -1;
137 long gridX0 = (long) Math.floor(x0);
138 long gridX1 = (long) Math.floor(x1);
139 long gridY0 = (long) Math.floor(y0);
140 long gridY1 = (long) Math.floor(y1);
141
142 long maxSteps = (gridX1 - gridX0) + Math.abs(gridY1 - gridY0) + 1;
143 while ((gridX0 <= gridX1 && (gridY0 - gridY1)*stepY <= 0) && maxSteps-- > 0) {
144 cells.add(new Point2D.Double(gridX0, gridY0));
145
146 // Is the cross between the segment and next vertical line nearer than the cross with next horizontal line?
147 // Note: segment line formula: y=dy/dx(x-x1)+y1
148 // Note: if dy < 0, must use *bottom* line. If dy > 0, must use upper line
149 double scanY = dy/dx * (gridX0 + 1 - x1) + y1 + (dy < 0 ? -1 : 0);
150 double scanX = dx/dy * (gridY0 + (dy < 0 ? 0 : 1)*stepY - y1) + x1;
151
152 double distX = Math.pow(gridX0 + 1 - x0, 2) + Math.pow(scanY - y0, 2);
153 double distY = Math.pow(scanX - x0, 2) + Math.pow(gridY0 + stepY - y0, 2);
154
155 if (distX < distY) {
156 gridX0 += 1;
157 } else {
158 gridY0 += stepY;
159 }
160 }
161 return cells;
162 }
163}
Note: See TracBrowser for help on using the repository browser.