1 | package org.openstreetmap.josm.data.validation.tests;
|
---|
2 |
|
---|
3 | import static org.openstreetmap.josm.tools.I18n.tr;
|
---|
4 |
|
---|
5 | import java.util.Arrays;
|
---|
6 | import org.openstreetmap.josm.data.osm.Node;
|
---|
7 | import org.openstreetmap.josm.data.osm.OsmPrimitive;
|
---|
8 | import org.openstreetmap.josm.data.osm.Relation;
|
---|
9 | import org.openstreetmap.josm.data.osm.Way;
|
---|
10 | import org.openstreetmap.josm.data.validation.Severity;
|
---|
11 | import org.openstreetmap.josm.data.validation.Test;
|
---|
12 | import org.openstreetmap.josm.data.validation.TestError;
|
---|
13 | import org.openstreetmap.josm.gui.mappaint.ElemStyles;
|
---|
14 |
|
---|
15 | public class WayConnectedToArea extends Test {
|
---|
16 |
|
---|
17 | public WayConnectedToArea() {
|
---|
18 | super(tr("Way connected to Area"), tr("Checks for ways connected to areas."));
|
---|
19 | }
|
---|
20 |
|
---|
21 | @Override
|
---|
22 | public void visit(Way w) {
|
---|
23 | if (!w.isUsable() || w.isClosed() || !w.hasKey("highway")) {
|
---|
24 | return;
|
---|
25 | }
|
---|
26 |
|
---|
27 | for (OsmPrimitive p : w.firstNode().getReferrers()) {
|
---|
28 | testForError(w, w.firstNode(), p);
|
---|
29 | }
|
---|
30 | for (OsmPrimitive p : w.lastNode().getReferrers()) {
|
---|
31 | testForError(w, w.lastNode(), p);
|
---|
32 | }
|
---|
33 |
|
---|
34 | }
|
---|
35 |
|
---|
36 | private void testForError(Way w, Node wayNode, OsmPrimitive p) {
|
---|
37 | if (isArea(p)) {
|
---|
38 | addError(w, wayNode, p);
|
---|
39 | } else {
|
---|
40 | for (OsmPrimitive r : p.getReferrers()) {
|
---|
41 | if (r instanceof Relation
|
---|
42 | && r.hasTag("type", "multipolygon")
|
---|
43 | && isArea(r)) {
|
---|
44 | addError(w, wayNode, p);
|
---|
45 | break;
|
---|
46 | }
|
---|
47 | }
|
---|
48 | }
|
---|
49 | }
|
---|
50 |
|
---|
51 | private boolean isArea(OsmPrimitive p) {
|
---|
52 | return (p.hasKey("landuse") || p.hasKey("natural"))
|
---|
53 | && ElemStyles.hasAreaElemStyle(p, false);
|
---|
54 | }
|
---|
55 |
|
---|
56 | private void addError(Way w, Node wayNode, OsmPrimitive p) {
|
---|
57 | errors.add(new TestError(this, Severity.WARNING,
|
---|
58 | tr("Way terminates on Area"), 2301,
|
---|
59 | Arrays.asList(w, p),
|
---|
60 | Arrays.asList(wayNode)));
|
---|
61 | }
|
---|
62 | }
|
---|