source: josm/trunk/src/org/openstreetmap/josm/data/validation/tests/WayConnectedToArea.java@ 4806

Last change on this file since 4806 was 4806, checked in by stoecker, 12 years ago

unify texts for validator tests, move command where it belongs

File size: 2.0 KB
Line 
1package org.openstreetmap.josm.data.validation.tests;
2
3import static org.openstreetmap.josm.tools.I18n.tr;
4
5import java.util.Arrays;
6import org.openstreetmap.josm.data.osm.Node;
7import org.openstreetmap.josm.data.osm.OsmPrimitive;
8import org.openstreetmap.josm.data.osm.Relation;
9import org.openstreetmap.josm.data.osm.Way;
10import org.openstreetmap.josm.data.validation.Severity;
11import org.openstreetmap.josm.data.validation.Test;
12import org.openstreetmap.josm.data.validation.TestError;
13import org.openstreetmap.josm.gui.mappaint.ElemStyles;
14
15public class WayConnectedToArea extends Test {
16
17 public WayConnectedToArea() {
18 super(tr("Way connected to Area"), tr("Checks for ways connected to areas."));
19 }
20
21 @Override
22 public void visit(Way w) {
23 if (!w.isUsable() || w.isClosed() || !w.hasKey("highway")) {
24 return;
25 }
26
27 for (OsmPrimitive p : w.firstNode().getReferrers()) {
28 testForError(w, w.firstNode(), p);
29 }
30 for (OsmPrimitive p : w.lastNode().getReferrers()) {
31 testForError(w, w.lastNode(), p);
32 }
33
34 }
35
36 private void testForError(Way w, Node wayNode, OsmPrimitive p) {
37 if (isArea(p)) {
38 addError(w, wayNode, p);
39 } else {
40 for (OsmPrimitive r : p.getReferrers()) {
41 if (r instanceof Relation
42 && r.hasTag("type", "multipolygon")
43 && isArea(r)) {
44 addError(w, wayNode, p);
45 break;
46 }
47 }
48 }
49 }
50
51 private boolean isArea(OsmPrimitive p) {
52 return (p.hasKey("landuse") || p.hasKey("natural"))
53 && ElemStyles.hasAreaElemStyle(p, false);
54 }
55
56 private void addError(Way w, Node wayNode, OsmPrimitive p) {
57 errors.add(new TestError(this, Severity.WARNING,
58 tr("Way terminates on Area"), 2301,
59 Arrays.asList(w, p),
60 Arrays.asList(wayNode)));
61 }
62}
Note: See TracBrowser for help on using the repository browser.