source: josm/trunk/src/org/openstreetmap/josm/data/validation/tests/UntaggedNode.java@ 11129

Last change on this file since 11129 was 11129, checked in by simon04, 8 years ago

fix #13799 - Use builder pattern for TestError

  • Property svn:eol-style set to native
File size: 4.6 KB
Line 
1// License: GPL. For details, see LICENSE file.
2package org.openstreetmap.josm.data.validation.tests;
3
4import static org.openstreetmap.josm.tools.I18n.marktr;
5import static org.openstreetmap.josm.tools.I18n.tr;
6
7import java.util.Locale;
8
9import org.openstreetmap.josm.command.Command;
10import org.openstreetmap.josm.data.osm.AbstractPrimitive;
11import org.openstreetmap.josm.data.osm.Node;
12import org.openstreetmap.josm.data.osm.OsmPrimitive;
13import org.openstreetmap.josm.data.validation.Severity;
14import org.openstreetmap.josm.data.validation.Test;
15import org.openstreetmap.josm.data.validation.TestError;
16
17/**
18 * Checks for nodes with uninteresting tags that are in no way
19 *
20 * @author frsantos
21 */
22public class UntaggedNode extends Test implements AbstractPrimitive.KeyValueVisitor {
23
24 protected static final int UNTAGGED_NODE_BLANK = 201;
25 protected static final int UNTAGGED_NODE_FIXME = 202;
26 protected static final int UNTAGGED_NODE_NOTE = 203;
27 protected static final int UNTAGGED_NODE_CREATED_BY = 204;
28 protected static final int UNTAGGED_NODE_WATCH = 205;
29 protected static final int UNTAGGED_NODE_SOURCE = 206;
30 protected static final int UNTAGGED_NODE_OTHER = 207;
31 protected static final String ERROR_MESSAGE = tr("Unconnected nodes without physical tags");
32
33 /**
34 * Constructor
35 */
36 public UntaggedNode() {
37 super(tr("Untagged and unconnected nodes"),
38 tr("This test checks for untagged nodes that are not part of any way."));
39 }
40
41 @Override
42 public void visit(Node n) {
43 if (n.isUsable() && !n.isTagged() && n.getReferrers().isEmpty()) {
44
45 if (!n.hasKeys() && IN_DOWNLOADED_AREA.test(n)) {
46 errors.add(TestError.builder(this, Severity.WARNING, UNTAGGED_NODE_BLANK)
47 .message(ERROR_MESSAGE, marktr("No tags"))
48 .primitives(n)
49 .build());
50 return;
51 }
52 n.visitKeys(this);
53 }
54 }
55
56 @Override
57 public void visitKeyValue(AbstractPrimitive n, String key, String value) {
58 if (key.toLowerCase(Locale.ENGLISH).contains("fixme") || value.toLowerCase(Locale.ENGLISH).contains("fixme")) {
59 /* translation note: don't translate quoted words */
60 errors.add(TestError.builder(this, Severity.WARNING, UNTAGGED_NODE_FIXME)
61 .message(ERROR_MESSAGE, marktr("Has tag containing ''fixme'' or ''FIXME''"))
62 .primitives((OsmPrimitive) n)
63 .build());
64 return;
65 }
66
67 String msg = null;
68 int code = 0;
69 if (key.startsWith("note") || key.startsWith("comment") || key.startsWith("description")) {
70 /* translation note: don't translate quoted words */
71 msg = marktr("Has key ''note'' or ''comment'' or ''description''");
72 code = UNTAGGED_NODE_NOTE;
73 } else if (key.startsWith("created_by") || key.startsWith("converted_by")) {
74 /* translation note: don't translate quoted words */
75 msg = marktr("Has key ''created_by'' or ''converted_by''");
76 code = UNTAGGED_NODE_CREATED_BY;
77 } else if (key.startsWith("watch")) {
78 /* translation note: don't translate quoted words */
79 msg = marktr("Has key ''watch''");
80 code = UNTAGGED_NODE_WATCH;
81 } else if (key.startsWith("source")) {
82 /* translation note: don't translate quoted words */
83 msg = marktr("Has key ''source''");
84 code = UNTAGGED_NODE_SOURCE;
85 }
86 if (msg != null) {
87 errors.add(TestError.builder(this, Severity.WARNING, code)
88 .message(ERROR_MESSAGE, msg)
89 .primitives((OsmPrimitive) n)
90 .build());
91 return;
92 }
93 // Does not happen, but just to be sure. Maybe definition of uninteresting tags changes in future.
94 errors.add(TestError.builder(this, Severity.WARNING, UNTAGGED_NODE_OTHER)
95 .message(ERROR_MESSAGE, marktr("Other"))
96 .primitives((OsmPrimitive) n)
97 .build());
98 }
99
100 @Override
101 public Command fixError(TestError testError) {
102 return deletePrimitivesIfNeeded(testError.getPrimitives());
103 }
104
105 @Override
106 public boolean isFixable(TestError testError) {
107 if (testError.getTester() instanceof UntaggedNode) {
108 int code = testError.getCode();
109 switch (code) {
110 case UNTAGGED_NODE_BLANK:
111 case UNTAGGED_NODE_CREATED_BY:
112 case UNTAGGED_NODE_WATCH:
113 case UNTAGGED_NODE_SOURCE:
114 return true;
115 }
116 }
117 return false;
118 }
119}
Note: See TracBrowser for help on using the repository browser.