source: josm/trunk/src/org/openstreetmap/josm/data/validation/tests/UnconnectedWays.java@ 5920

Last change on this file since 5920 was 5920, checked in by Don-vip, 11 years ago

Handle nodes without coordinates in UnconnectedWays validator test
  • Property svn:eol-style set to native
File size: 14.5 KB
Line 
1// License: GPL. See LICENSE file for details.
2package org.openstreetmap.josm.data.validation.tests;
3
4import static org.openstreetmap.josm.tools.I18n.tr;
5
6import java.awt.geom.Area;
7import java.awt.geom.Line2D;
8import java.awt.geom.Point2D;
9import java.util.ArrayList;
10import java.util.Arrays;
11import java.util.Collection;
12import java.util.Collections;
13import java.util.HashMap;
14import java.util.HashSet;
15import java.util.List;
16import java.util.Map;
17import java.util.Set;
18
19import org.openstreetmap.josm.Main;
20import org.openstreetmap.josm.data.coor.EastNorth;
21import org.openstreetmap.josm.data.coor.LatLon;
22import org.openstreetmap.josm.data.osm.BBox;
23import org.openstreetmap.josm.data.osm.DataSet;
24import org.openstreetmap.josm.data.osm.Node;
25import org.openstreetmap.josm.data.osm.OsmUtils;
26import org.openstreetmap.josm.data.osm.QuadBuckets;
27import org.openstreetmap.josm.data.osm.Way;
28import org.openstreetmap.josm.data.validation.Severity;
29import org.openstreetmap.josm.data.validation.Test;
30import org.openstreetmap.josm.data.validation.TestError;
31import org.openstreetmap.josm.gui.preferences.ValidatorPreference;
32import org.openstreetmap.josm.gui.progress.ProgressMonitor;
33
34/**
35 * Tests if there are segments that crosses in the same layer
36 *
37 * @author frsantos
38 */
39public class UnconnectedWays extends Test {
40
41 protected static final int UNCONNECTED_WAYS = 1301;
42 protected static final String PREFIX = ValidatorPreference.PREFIX + "." + UnconnectedWays.class.getSimpleName();
43
44 Set<MyWaySegment> ways;
45 QuadBuckets<Node> endnodes; // nodes at end of way
46 QuadBuckets<Node> endnodes_highway; // nodes at end of way
47 QuadBuckets<Node> middlenodes; // nodes in middle of way
48 Set<Node> othernodes; // nodes appearing at least twice
49 //NodeSearchCache nodecache;
50 QuadBuckets<Node> nodecache;
51 Area ds_area;
52 DataSet ds;
53
54 double mindist;
55 double minmiddledist;
56
57 /**
58 * Constructor
59 */
60 public UnconnectedWays() {
61 super(tr("Unconnected ways"),
62 tr("This test checks if a way has an endpoint very near to another way."));
63 }
64
65 @Override
66 public void startTest(ProgressMonitor monitor) {
67 super.startTest(monitor);
68 ways = new HashSet<MyWaySegment>();
69 endnodes = new QuadBuckets<Node>();
70 endnodes_highway = new QuadBuckets<Node>();
71 middlenodes = new QuadBuckets<Node>();
72 othernodes = new HashSet<Node>();
73 mindist = Main.pref.getDouble(PREFIX + ".node_way_distance", 10.0);
74 minmiddledist = Main.pref.getDouble(PREFIX + ".way_way_distance", 0.0);
75 this.ds = Main.main.getCurrentDataSet();
76 this.ds_area = ds.getDataSourceArea();
77 }
78
79 @Override
80 public void endTest() {
81 Map<Node, Way> map = new HashMap<Node, Way>();
82 for (int iter = 0; iter < 1; iter++) {
83 Collection<MyWaySegment> tmp_ways = ways;
84 for (MyWaySegment s : tmp_ways) {
85 Collection<Node> nearbyNodes = s.nearbyNodes(mindist);
86 for (Node en : nearbyNodes) {
87 if (en == null || !s.highway || !endnodes_highway.contains(en)) {
88 continue;
89 }
90 if ("turning_circle".equals(en.get("highway"))
91 || "bus_stop".equals(en.get("highway"))
92 || "buffer_stop".equals(en.get("railway"))
93 || OsmUtils.isTrue(en.get("noexit"))
94 || en.hasKey("barrier")) {
95 continue;
96 }
97 // There's a small false-positive here. Imagine an intersection
98 // like a 't'. If the top part of the 't' is short enough, it
99 // will trigger the node at the very top of the 't' to be unconnected
100 // to the way that "crosses" the 't'. We should probably check that
101 // the ways to which 'en' belongs are not connected to 's.w'.
102 map.put(en, s.w);
103 }
104 if(isCanceled())
105 return;
106 }
107 }
108 for (Map.Entry<Node, Way> error : map.entrySet()) {
109 errors.add(new TestError(this, Severity.WARNING,
110 tr("Way end node near other highway"),
111 UNCONNECTED_WAYS,
112 Arrays.asList(error.getKey(), error.getValue()),
113 Arrays.asList(error.getKey())));
114 }
115 map.clear();
116 for (MyWaySegment s : ways) {
117 if(isCanceled())
118 return;
119 for (Node en : s.nearbyNodes(mindist)) {
120 if (endnodes_highway.contains(en) && !s.highway && !s.isArea()) {
121 map.put(en, s.w);
122 } else if (endnodes.contains(en) && !s.isArea()) {
123 map.put(en, s.w);
124 }
125 }
126 }
127 for (Map.Entry<Node, Way> error : map.entrySet()) {
128 errors.add(new TestError(this, Severity.WARNING,
129 tr("Way end node near other way"),
130 UNCONNECTED_WAYS,
131 Arrays.asList(error.getKey(), error.getValue()),
132 Arrays.asList(error.getKey())));
133 }
134 /* the following two use a shorter distance */
135 if (minmiddledist > 0.0) {
136 map.clear();
137 for (MyWaySegment s : ways) {
138 if(isCanceled())
139 return;
140 for (Node en : s.nearbyNodes(minmiddledist)) {
141 if (!middlenodes.contains(en)) {
142 continue;
143 }
144 map.put(en, s.w);
145 }
146 }
147 //System.out.println("p3 elapsed: " + (System.currentTimeMillis()-last));
148 //last = System.currentTimeMillis();
149 for (Map.Entry<Node, Way> error : map.entrySet()) {
150 errors.add(new TestError(this, Severity.OTHER,
151 tr("Way node near other way"),
152 UNCONNECTED_WAYS,
153 Arrays.asList(error.getKey(), error.getValue()),
154 Arrays.asList(error.getKey())));
155 }
156 map.clear();
157 for (MyWaySegment s : ways) {
158 for (Node en : s.nearbyNodes(minmiddledist)) {
159 if(isCanceled())
160 return;
161 if (!othernodes.contains(en)) {
162 continue;
163 }
164 map.put(en, s.w);
165 }
166 }
167 //System.out.println("p4 elapsed: " + (System.currentTimeMillis()-last));
168 //last = System.currentTimeMillis();
169 for (Map.Entry<Node, Way> error : map.entrySet()) {
170 errors.add(new TestError(this, Severity.OTHER,
171 tr("Connected way end node near other way"),
172 UNCONNECTED_WAYS,
173 Arrays.asList(error.getKey(), error.getValue()),
174 Arrays.asList(error.getKey())));
175 }
176 }
177 ways = null;
178 endnodes = null;
179 super.endTest();
180 //System.out.println("p99 elapsed: " + (System.currentTimeMillis()-last));
181 //last = System.currentTimeMillis();
182 }
183
184 private class MyWaySegment {
185 private final Line2D line;
186 public final Way w;
187 public final boolean isAbandoned;
188 public final boolean isBoundary;
189 public final boolean highway;
190 private final double len;
191 private Set<Node> nearbyNodeCache;
192 double nearbyNodeCacheDist = -1.0;
193 final Node n1;
194 final Node n2;
195
196 public MyWaySegment(Way w, Node n1, Node n2) {
197 this.w = w;
198 String railway = w.get("railway");
199 String highway = w.get("highway");
200 this.isAbandoned = "abandoned".equals(railway) || OsmUtils.isTrue(w.get("disused"));
201 this.highway = (highway != null || railway != null) && !isAbandoned;
202 this.isBoundary = !this.highway && "administrative".equals(w.get("boundary"));
203 line = new Line2D.Double(n1.getEastNorth().east(), n1.getEastNorth().north(),
204 n2.getEastNorth().east(), n2.getEastNorth().north());
205 len = line.getP1().distance(line.getP2());
206 this.n1 = n1;
207 this.n2 = n2;
208 }
209
210 public boolean nearby(Node n, double dist) {
211 if (w == null) {
212 Main.debug("way null");
213 return false;
214 }
215 if (w.containsNode(n))
216 return false;
217 if (OsmUtils.isTrue(n.get("noexit")))
218 return false;
219 EastNorth coord = n.getEastNorth();
220 if (coord == null)
221 return false;
222 Point2D p = new Point2D.Double(coord.east(), coord.north());
223 if (line.getP1().distance(p) > len+dist)
224 return false;
225 if (line.getP2().distance(p) > len+dist)
226 return false;
227 return line.ptSegDist(p) < dist;
228 }
229
230 public List<LatLon> getBounds(double fudge) {
231 double x1 = n1.getCoor().lon();
232 double x2 = n2.getCoor().lon();
233 if (x1 > x2) {
234 double tmpx = x1;
235 x1 = x2;
236 x2 = tmpx;
237 }
238 double y1 = n1.getCoor().lat();
239 double y2 = n2.getCoor().lat();
240 if (y1 > y2) {
241 double tmpy = y1;
242 y1 = y2;
243 y2 = tmpy;
244 }
245 LatLon topLeft = new LatLon(y2+fudge, x1-fudge);
246 LatLon botRight = new LatLon(y1-fudge, x2+fudge);
247 List<LatLon> ret = new ArrayList<LatLon>();
248 ret.add(topLeft);
249 ret.add(botRight);
250 return ret;
251 }
252
253 public Collection<Node> nearbyNodes(double dist) {
254 // If you're looking for nodes that are farther
255 // away that we looked for last time, the cached
256 // result is no good
257 if (dist > nearbyNodeCacheDist) {
258 //if (nearbyNodeCacheDist != -1)
259 // System.out.println("destroyed MyWaySegment nearby node cache:" + dist + " > " + nearbyNodeCacheDist);
260 nearbyNodeCache = null;
261 }
262 if (nearbyNodeCache != null) {
263 // If we've cached an aread greater than the
264 // one now being asked for...
265 if (nearbyNodeCacheDist > dist) {
266 //System.out.println("had to trim MyWaySegment nearby node cache.");
267 // Used the cached result and trim out
268 // the nodes that are not in the smaller
269 // area, but keep the old larger cache.
270 Set<Node> trimmed = new HashSet<Node>(nearbyNodeCache);
271 Set<Node> initial = new HashSet<Node>(nearbyNodeCache);
272 for (Node n : initial) {
273 if (!nearby(n, dist)) {
274 trimmed.remove(n);
275 }
276 }
277 return trimmed;
278 }
279 return nearbyNodeCache;
280 }
281 /*
282 * We know that any point near the line must be at
283 * least as close as the other end of the line, plus
284 * a little fudge for the distance away ('dist').
285 */
286
287 // This needs to be a hash set because the searches
288 // overlap a bit and can return duplicate nodes.
289 nearbyNodeCache = null;
290 List<LatLon> bounds = this.getBounds(dist);
291 List<Node> found_nodes = endnodes_highway.search(new BBox(bounds.get(0), bounds.get(1)));
292 found_nodes.addAll(endnodes.search(new BBox(bounds.get(0), bounds.get(1))));
293
294 for (Node n : found_nodes) {
295 if (!nearby(n, dist) ||
296 (ds_area != null && !ds_area.contains(n.getCoor()))) {
297 continue;
298 }
299 // It is actually very rare for us to find a node
300 // so defer as much of the work as possible, like
301 // allocating the hash set
302 if (nearbyNodeCache == null) {
303 nearbyNodeCache = new HashSet<Node>();
304 }
305 nearbyNodeCache.add(n);
306 }
307 nearbyNodeCacheDist = dist;
308 if (nearbyNodeCache == null) {
309 nearbyNodeCache = Collections.emptySet();
310 }
311 return nearbyNodeCache;
312 }
313
314 public boolean isArea() {
315 return w.hasKey("landuse")
316 || w.hasKey("leisure")
317 || w.hasKey("amenity")
318 || w.hasKey("building");
319 }
320 }
321
322 List<MyWaySegment> getWaySegments(Way w) {
323 List<MyWaySegment> ret = new ArrayList<MyWaySegment>();
324 if (!w.isUsable()
325 || w.hasKey("barrier")
326 || "cliff".equals(w.get("natural")))
327 return ret;
328
329 int size = w.getNodesCount();
330 if (size < 2)
331 return ret;
332 for (int i = 1; i < size; ++i) {
333 if(i < size-1) {
334 addNode(w.getNode(i), middlenodes);
335 }
336 Node a = w.getNode(i-1);
337 Node b = w.getNode(i);
338 if (a.isDrawable() && b.isDrawable()) {
339 MyWaySegment ws = new MyWaySegment(w, a, b);
340 if (ws.isBoundary || ws.isAbandoned) {
341 continue;
342 }
343 ret.add(ws);
344 }
345 }
346 return ret;
347 }
348
349 @Override
350 public void visit(Way w) {
351 if (w.getNodesCount() > 0) {
352 ways.addAll(getWaySegments(w));
353 QuadBuckets<Node> set = endnodes;
354 if (w.hasKey("highway") || w.hasKey("railway")) {
355 set = endnodes_highway;
356 }
357 addNode(w.firstNode(), set);
358 addNode(w.lastNode(), set);
359 }
360 }
361
362 @Override
363 public void visit(Node n) {
364 }
365
366 private void addNode(Node n, QuadBuckets<Node> s) {
367 boolean m = middlenodes.contains(n);
368 boolean e = endnodes.contains(n);
369 boolean eh = endnodes_highway.contains(n);
370 boolean o = othernodes.contains(n);
371 if (!m && !e && !o && !eh) {
372 s.add(n);
373 } else if (!o) {
374 othernodes.add(n);
375 if (e) {
376 endnodes.remove(n);
377 } else if (eh) {
378 endnodes_highway.remove(n);
379 } else {
380 middlenodes.remove(n);
381 }
382 }
383 }
384}
Note: See TracBrowser for help on using the repository browser.