source: josm/trunk/src/org/openstreetmap/josm/data/validation/tests/Addresses.java@ 11608

Last change on this file since 11608 was 11608, checked in by Don-vip, 7 years ago

fix #14402 - add blacklist for leisure area values to avoid false positives - improve globally the detection of keys/tags
  • Property svn:eol-style set to native
File size: 9.8 KB
Line 
1// License: GPL. For details, see LICENSE file.
2package org.openstreetmap.josm.data.validation.tests;
3
4import static org.openstreetmap.josm.tools.I18n.marktr;
5import static org.openstreetmap.josm.tools.I18n.tr;
6
7import java.util.ArrayList;
8import java.util.Collection;
9import java.util.HashMap;
10import java.util.HashSet;
11import java.util.List;
12import java.util.Locale;
13import java.util.Map;
14import java.util.Map.Entry;
15import java.util.Set;
16
17import org.openstreetmap.josm.Main;
18import org.openstreetmap.josm.data.coor.EastNorth;
19import org.openstreetmap.josm.data.osm.Node;
20import org.openstreetmap.josm.data.osm.OsmPrimitive;
21import org.openstreetmap.josm.data.osm.Relation;
22import org.openstreetmap.josm.data.osm.RelationMember;
23import org.openstreetmap.josm.data.osm.Way;
24import org.openstreetmap.josm.data.validation.Severity;
25import org.openstreetmap.josm.data.validation.Test;
26import org.openstreetmap.josm.data.validation.TestError;
27import org.openstreetmap.josm.tools.Geometry;
28import org.openstreetmap.josm.tools.Pair;
29import org.openstreetmap.josm.tools.SubclassFilteredCollection;
30
31/**
32 * Performs validation tests on addresses (addr:housenumber) and associatedStreet relations.
33 * @since 5644
34 */
35public class Addresses extends Test {
36
37 protected static final int HOUSE_NUMBER_WITHOUT_STREET = 2601;
38 protected static final int DUPLICATE_HOUSE_NUMBER = 2602;
39 protected static final int MULTIPLE_STREET_NAMES = 2603;
40 protected static final int MULTIPLE_STREET_RELATIONS = 2604;
41 protected static final int HOUSE_NUMBER_TOO_FAR = 2605;
42
43 // CHECKSTYLE.OFF: SingleSpaceSeparator
44 protected static final String ADDR_HOUSE_NUMBER = "addr:housenumber";
45 protected static final String ADDR_INTERPOLATION = "addr:interpolation";
46 protected static final String ADDR_PLACE = "addr:place";
47 protected static final String ADDR_STREET = "addr:street";
48 protected static final String ASSOCIATED_STREET = "associatedStreet";
49 // CHECKSTYLE.ON: SingleSpaceSeparator
50
51 /**
52 * Constructor
53 */
54 public Addresses() {
55 super(tr("Addresses"), tr("Checks for errors in addresses and associatedStreet relations."));
56 }
57
58 protected List<Relation> getAndCheckAssociatedStreets(OsmPrimitive p) {
59 List<Relation> list = OsmPrimitive.getFilteredList(p.getReferrers(), Relation.class);
60 list.removeIf(r -> !r.hasTag("type", ASSOCIATED_STREET));
61 if (list.size() > 1) {
62 Severity level;
63 // warning level only if several relations have different names, see #10945
64 final String name = list.get(0).get("name");
65 if (name == null || SubclassFilteredCollection.filter(list, r -> r.hasTag("name", name)).size() < list.size()) {
66 level = Severity.WARNING;
67 } else {
68 level = Severity.OTHER;
69 }
70 List<OsmPrimitive> errorList = new ArrayList<>(list);
71 errorList.add(0, p);
72 errors.add(TestError.builder(this, level, MULTIPLE_STREET_RELATIONS)
73 .message(tr("Multiple associatedStreet relations"))
74 .primitives(errorList)
75 .build());
76 }
77 return list;
78 }
79
80 protected void checkHouseNumbersWithoutStreet(OsmPrimitive p) {
81 List<Relation> associatedStreets = getAndCheckAssociatedStreets(p);
82 // Find house number without proper location (neither addr:street, associatedStreet, addr:place or addr:interpolation)
83 if (p.hasKey(ADDR_HOUSE_NUMBER) && !p.hasKey(ADDR_STREET) && !p.hasKey(ADDR_PLACE)) {
84 for (Relation r : associatedStreets) {
85 if (r.hasTag("type", ASSOCIATED_STREET)) {
86 return;
87 }
88 }
89 for (Way w : OsmPrimitive.getFilteredList(p.getReferrers(), Way.class)) {
90 if (w.hasKey(ADDR_INTERPOLATION) && w.hasKey(ADDR_STREET)) {
91 return;
92 }
93 }
94 // No street found
95 errors.add(TestError.builder(this, Severity.WARNING, HOUSE_NUMBER_WITHOUT_STREET)
96 .message(tr("House number without street"))
97 .primitives(p)
98 .build());
99 }
100 }
101
102 @Override
103 public void visit(Node n) {
104 checkHouseNumbersWithoutStreet(n);
105 }
106
107 @Override
108 public void visit(Way w) {
109 checkHouseNumbersWithoutStreet(w);
110 }
111
112 @Override
113 public void visit(Relation r) {
114 checkHouseNumbersWithoutStreet(r);
115 if (r.hasTag("type", ASSOCIATED_STREET)) {
116 // Used to count occurences of each house number in order to find duplicates
117 Map<String, List<OsmPrimitive>> map = new HashMap<>();
118 // Used to detect different street names
119 String relationName = r.get("name");
120 Set<OsmPrimitive> wrongStreetNames = new HashSet<>();
121 // Used to check distance
122 Set<OsmPrimitive> houses = new HashSet<>();
123 Set<Way> street = new HashSet<>();
124 for (RelationMember m : r.getMembers()) {
125 String role = m.getRole();
126 OsmPrimitive p = m.getMember();
127 if ("house".equals(role)) {
128 houses.add(p);
129 String number = p.get(ADDR_HOUSE_NUMBER);
130 if (number != null) {
131 number = number.trim().toUpperCase(Locale.ENGLISH);
132 List<OsmPrimitive> list = map.get(number);
133 if (list == null) {
134 list = new ArrayList<>();
135 map.put(number, list);
136 }
137 list.add(p);
138 }
139 if (relationName != null && p.hasKey(ADDR_STREET) && !relationName.equals(p.get(ADDR_STREET))) {
140 if (wrongStreetNames.isEmpty()) {
141 wrongStreetNames.add(r);
142 }
143 wrongStreetNames.add(p);
144 }
145 } else if ("street".equals(role)) {
146 if (p instanceof Way) {
147 street.add((Way) p);
148 }
149 if (relationName != null && p.hasTagDifferent("name", relationName)) {
150 if (wrongStreetNames.isEmpty()) {
151 wrongStreetNames.add(r);
152 }
153 wrongStreetNames.add(p);
154 }
155 }
156 }
157 // Report duplicate house numbers
158 for (Entry<String, List<OsmPrimitive>> entry : map.entrySet()) {
159 List<OsmPrimitive> list = entry.getValue();
160 if (list.size() > 1) {
161 errors.add(TestError.builder(this, Severity.WARNING, DUPLICATE_HOUSE_NUMBER)
162 .message(tr("Duplicate house numbers"), marktr("House number ''{0}'' duplicated"), entry.getKey())
163 .primitives(list)
164 .build());
165 }
166 }
167 // Report wrong street names
168 if (!wrongStreetNames.isEmpty()) {
169 errors.add(TestError.builder(this, Severity.WARNING, MULTIPLE_STREET_NAMES)
170 .message(tr("Multiple street names in relation"))
171 .primitives(wrongStreetNames)
172 .build());
173 }
174 // Report addresses too far away
175 if (!street.isEmpty()) {
176 for (OsmPrimitive house : houses) {
177 if (house.isUsable()) {
178 checkDistance(house, street);
179 }
180 }
181 }
182 }
183 }
184
185 protected void checkDistance(OsmPrimitive house, Collection<Way> street) {
186 EastNorth centroid;
187 if (house instanceof Node) {
188 centroid = ((Node) house).getEastNorth();
189 } else if (house instanceof Way) {
190 List<Node> nodes = ((Way) house).getNodes();
191 if (house.hasKey(ADDR_INTERPOLATION)) {
192 for (Node n : nodes) {
193 if (n.hasKey(ADDR_HOUSE_NUMBER)) {
194 checkDistance(n, street);
195 }
196 }
197 return;
198 }
199 centroid = Geometry.getCentroid(nodes);
200 } else {
201 return; // TODO handle multipolygon houses ?
202 }
203 if (centroid == null) return; // fix #8305
204 double maxDistance = Main.pref.getDouble("validator.addresses.max_street_distance", 200.0);
205 boolean hasIncompleteWays = false;
206 for (Way streetPart : street) {
207 for (Pair<Node, Node> chunk : streetPart.getNodePairs(false)) {
208 EastNorth p1 = chunk.a.getEastNorth();
209 EastNorth p2 = chunk.b.getEastNorth();
210 if (p1 != null && p2 != null) {
211 EastNorth closest = Geometry.closestPointToSegment(p1, p2, centroid);
212 if (closest.distance(centroid) <= maxDistance) {
213 return;
214 }
215 } else {
216 Main.warn("Addresses test skipped chunck "+chunk+" for street part "+streetPart+" because p1 or p2 is null");
217 }
218 }
219 if (!hasIncompleteWays && streetPart.isIncomplete()) {
220 hasIncompleteWays = true;
221 }
222 }
223 // No street segment found near this house, report error on if the relation does not contain incomplete street ways (fix #8314)
224 if (hasIncompleteWays) return;
225 List<OsmPrimitive> errorList = new ArrayList<>(street);
226 errorList.add(0, house);
227 errors.add(TestError.builder(this, Severity.WARNING, HOUSE_NUMBER_TOO_FAR)
228 .message(tr("House number too far from street"))
229 .primitives(errorList)
230 .build());
231 }
232}
Note: See TracBrowser for help on using the repository browser.