source: josm/trunk/src/org/openstreetmap/josm/command/ChangeRelationMemberRoleCommand.java@ 2990

Last change on this file since 2990 was 2683, checked in by mjulius, 14 years ago

fixes #4149 - exception when undoing reversal of way with tag corrections

don't try to undo Command for a primitive that does not belong to a dataset

fixes issue with ChangeRelationMemberRoleCommand.undoCommand() doing nothing except resetting modified flag
don't reverse tags on way nodes when reversing way
reversing way now also reverses 'incline=*' tags

File size: 2.7 KB
Line 
1// License: GPL. For details, see LICENSE file.
2package org.openstreetmap.josm.command;
3
4import static org.openstreetmap.josm.tools.I18n.tr;
5
6import java.util.Collection;
7
8import javax.swing.JLabel;
9import javax.swing.tree.DefaultMutableTreeNode;
10import javax.swing.tree.MutableTreeNode;
11
12import org.openstreetmap.josm.Main;
13import org.openstreetmap.josm.data.osm.OsmPrimitive;
14import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
15import org.openstreetmap.josm.data.osm.Relation;
16import org.openstreetmap.josm.data.osm.RelationMember;
17import org.openstreetmap.josm.gui.DefaultNameFormatter;
18import org.openstreetmap.josm.tools.ImageProvider;
19
20/**
21 * Command that changes the role of a relation member
22 *
23 * @author Teemu Koskinen <teemu.koskinen@mbnet.fi>
24 */
25public class ChangeRelationMemberRoleCommand extends Command {
26
27 // The relation to be changed
28 private final Relation relation;
29 // Position of the member
30 private int position = -1;
31 // The new role
32 private final String newRole;
33 // The old role
34 private String oldRole;
35 // Old value of modified;
36 private Boolean oldModified;
37
38 public ChangeRelationMemberRoleCommand(Relation relation, int position, String newRole) {
39 super();
40 this.relation = relation;
41 this.position = position;
42 this.newRole = newRole;
43 }
44
45 @Override public boolean executeCommand() {
46 if (position < 0 || position >= relation.getMembersCount()) {
47 Main.debug("error changing the role");
48 return false;
49 }
50
51 oldRole = relation.getMember(position).getRole();
52 if (newRole.equals(oldRole)) return true;
53 relation.setMember(position, new RelationMember(newRole, relation.getMember(position).getMember()));
54
55 oldModified = relation.isModified();
56 relation.setModified(true);
57 return true;
58 }
59
60 @Override public void undoCommand() {
61 relation.setMember(position, new RelationMember(oldRole, relation.getMember(position).getMember()));
62 relation.setModified(oldModified);
63 }
64
65 @Override public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted, Collection<OsmPrimitive> added) {
66 modified.add(relation);
67 }
68
69 @Override public MutableTreeNode description() {
70 return new DefaultMutableTreeNode(
71 new JLabel(
72 tr("Change relation member role for {0} {1}",
73 OsmPrimitiveType.from(relation),
74 relation.getDisplayName(DefaultNameFormatter.getInstance())
75 ),
76 ImageProvider.get(OsmPrimitiveType.from(relation)),
77 JLabel.HORIZONTAL)
78 );
79 }
80}
Note: See TracBrowser for help on using the repository browser.