source: josm/trunk/src/org/openstreetmap/josm/actions/SimplifyWayAction.java@ 11217

Last change on this file since 11217 was 11118, checked in by simon04, 8 years ago

fix #13094 - SimplifyWayAction for first node of closed way (patch by Tyndare, modified)
  • Property svn:eol-style set to native
File size: 11.4 KB
Line 
1// License: GPL. For details, see LICENSE file.
2package org.openstreetmap.josm.actions;
3
4import static org.openstreetmap.josm.gui.help.HelpUtil.ht;
5import static org.openstreetmap.josm.tools.I18n.tr;
6import static org.openstreetmap.josm.tools.I18n.trn;
7
8import java.awt.event.ActionEvent;
9import java.awt.event.KeyEvent;
10import java.util.ArrayList;
11import java.util.Arrays;
12import java.util.Collection;
13import java.util.Collections;
14import java.util.HashSet;
15import java.util.LinkedList;
16import java.util.List;
17import java.util.Set;
18
19import javax.swing.JOptionPane;
20
21import org.openstreetmap.josm.Main;
22import org.openstreetmap.josm.command.ChangeCommand;
23import org.openstreetmap.josm.command.Command;
24import org.openstreetmap.josm.command.DeleteCommand;
25import org.openstreetmap.josm.command.SequenceCommand;
26import org.openstreetmap.josm.data.osm.DataSet;
27import org.openstreetmap.josm.data.osm.Node;
28import org.openstreetmap.josm.data.osm.OsmPrimitive;
29import org.openstreetmap.josm.data.osm.Way;
30import org.openstreetmap.josm.data.projection.Ellipsoid;
31import org.openstreetmap.josm.gui.HelpAwareOptionPane;
32import org.openstreetmap.josm.gui.HelpAwareOptionPane.ButtonSpec;
33import org.openstreetmap.josm.gui.Notification;
34import org.openstreetmap.josm.tools.ImageProvider;
35import org.openstreetmap.josm.tools.Shortcut;
36
37/**
38 * Delete unnecessary nodes from a way
39 * @since 2575
40 */
41public class SimplifyWayAction extends JosmAction {
42
43 /**
44 * Constructs a new {@code SimplifyWayAction}.
45 */
46 public SimplifyWayAction() {
47 super(tr("Simplify Way"), "simplify", tr("Delete unnecessary nodes from a way."),
48 Shortcut.registerShortcut("tools:simplify", tr("Tool: {0}", tr("Simplify Way")), KeyEvent.VK_Y, Shortcut.SHIFT), true);
49 putValue("help", ht("/Action/SimplifyWay"));
50 }
51
52 protected boolean confirmWayWithNodesOutsideBoundingBox(List<? extends OsmPrimitive> primitives) {
53 return DeleteCommand.checkAndConfirmOutlyingDelete(primitives, null);
54 }
55
56 protected void alertSelectAtLeastOneWay() {
57 new Notification(
58 tr("Please select at least one way to simplify."))
59 .setIcon(JOptionPane.WARNING_MESSAGE)
60 .setDuration(Notification.TIME_SHORT)
61 .setHelpTopic(ht("/Action/SimplifyWay#SelectAWayToSimplify"))
62 .show();
63 }
64
65 protected boolean confirmSimplifyManyWays(int numWays) {
66 ButtonSpec[] options = new ButtonSpec[] {
67 new ButtonSpec(
68 tr("Yes"),
69 ImageProvider.get("ok"),
70 tr("Simplify all selected ways"),
71 null
72 ),
73 new ButtonSpec(
74 tr("Cancel"),
75 ImageProvider.get("cancel"),
76 tr("Cancel operation"),
77 null
78 )
79 };
80 return 0 == HelpAwareOptionPane.showOptionDialog(
81 Main.parent,
82 tr(
83 "The selection contains {0} ways. Are you sure you want to simplify them all?",
84 numWays
85 ),
86 tr("Simplify ways?"),
87 JOptionPane.WARNING_MESSAGE,
88 null, // no special icon
89 options,
90 options[0],
91 ht("/Action/SimplifyWay#ConfirmSimplifyAll")
92 );
93 }
94
95 @Override
96 public void actionPerformed(ActionEvent e) {
97 DataSet ds = getLayerManager().getEditDataSet();
98 ds.beginUpdate();
99 try {
100 List<Way> ways = OsmPrimitive.getFilteredList(ds.getSelected(), Way.class);
101 if (ways.isEmpty()) {
102 alertSelectAtLeastOneWay();
103 return;
104 } else if (!confirmWayWithNodesOutsideBoundingBox(ways) || (ways.size() > 10 && !confirmSimplifyManyWays(ways.size()))) {
105 return;
106 }
107
108 Collection<Command> allCommands = new LinkedList<>();
109 for (Way way: ways) {
110 SequenceCommand simplifyCommand = simplifyWay(way);
111 if (simplifyCommand == null) {
112 continue;
113 }
114 allCommands.add(simplifyCommand);
115 }
116 if (allCommands.isEmpty()) return;
117 SequenceCommand rootCommand = new SequenceCommand(
118 trn("Simplify {0} way", "Simplify {0} ways", allCommands.size(), allCommands.size()),
119 allCommands
120 );
121 Main.main.undoRedo.add(rootCommand);
122 } finally {
123 ds.endUpdate();
124 }
125 }
126
127 /**
128 * Replies true if <code>node</code> is a required node which can't be removed
129 * in order to simplify the way.
130 *
131 * @param way the way to be simplified
132 * @param node the node to check
133 * @return true if <code>node</code> is a required node which can't be removed
134 * in order to simplify the way.
135 */
136 protected boolean isRequiredNode(Way way, Node node) {
137 int frequency = Collections.frequency(way.getNodes(), node);
138 if ((way.getNode(0) == node) && (way.getNode(way.getNodesCount()-1) == node)) {
139 frequency = frequency - 1; // closed way closing node counted only once
140 }
141 boolean isRequired = frequency > 1;
142 if (!isRequired) {
143 List<OsmPrimitive> parents = new LinkedList<>();
144 parents.addAll(node.getReferrers());
145 parents.remove(way);
146 isRequired = !parents.isEmpty();
147 }
148 if (!isRequired) {
149 isRequired = node.isTagged();
150 }
151 return isRequired;
152 }
153
154 /**
155 * Simplifies a way with default threshold (read from preferences).
156 *
157 * @param w the way to simplify
158 * @return The sequence of commands to run
159 * @since 6411
160 */
161 public final SequenceCommand simplifyWay(Way w) {
162 return simplifyWay(w, Main.pref.getDouble("simplify-way.max-error", 3.0));
163 }
164
165 /**
166 * Simplifies a way with a given threshold.
167 *
168 * @param w the way to simplify
169 * @param threshold the max error threshold
170 * @return The sequence of commands to run
171 * @since 6411
172 */
173 public SequenceCommand simplifyWay(Way w, double threshold) {
174 int lower = 0;
175 int i = 0;
176 List<Node> newNodes = new ArrayList<>(w.getNodesCount());
177 while (i < w.getNodesCount()) {
178 if (isRequiredNode(w, w.getNode(i))) {
179 // copy a required node to the list of new nodes. Simplify not possible
180 newNodes.add(w.getNode(i));
181 i++;
182 lower++;
183 continue;
184 }
185 i++;
186 // find the longest sequence of not required nodes ...
187 while (i < w.getNodesCount() && !isRequiredNode(w, w.getNode(i))) {
188 i++;
189 }
190 // ... and simplify them
191 buildSimplifiedNodeList(w.getNodes(), lower, Math.min(w.getNodesCount()-1, i), threshold, newNodes);
192 lower = i;
193 i++;
194 }
195
196 if ((newNodes.size() > 3) && (newNodes.get(0) == newNodes.get(newNodes.size() - 1))) {
197 // Closed way, check if the first node could also be simplified ...
198 if (!isRequiredNode(w, newNodes.get(0))) {
199 final List<Node> l1 = Arrays.asList(newNodes.get(newNodes.size() - 2), newNodes.get(0), newNodes.get(1));
200 final List<Node> l2 = new ArrayList<>(3);
201 buildSimplifiedNodeList(l1, 0, 2, threshold, l2);
202 if (!l2.contains(newNodes.get(0))) {
203 newNodes.remove(0);
204 newNodes.set(newNodes.size() - 1, newNodes.get(0)); // close the way
205 }
206 }
207 }
208
209 Set<Node> delNodes = new HashSet<>();
210 delNodes.addAll(w.getNodes());
211 delNodes.removeAll(newNodes);
212
213 if (delNodes.isEmpty()) return null;
214
215 Collection<Command> cmds = new LinkedList<>();
216 Way newWay = new Way(w);
217 newWay.setNodes(newNodes);
218 cmds.add(new ChangeCommand(w, newWay));
219 cmds.add(new DeleteCommand(delNodes));
220 w.getDataSet().clearSelection(delNodes);
221 return new SequenceCommand(
222 trn("Simplify Way (remove {0} node)", "Simplify Way (remove {0} nodes)", delNodes.size(), delNodes.size()), cmds);
223 }
224
225 /**
226 * Builds the simplified list of nodes for a way segment given by a lower index <code>from</code>
227 * and an upper index <code>to</code>
228 *
229 * @param wnew the way to simplify
230 * @param from the lower index
231 * @param to the upper index
232 * @param threshold the max error threshold
233 * @param simplifiedNodes list that will contain resulting nodes
234 */
235 protected void buildSimplifiedNodeList(List<Node> wnew, int from, int to, double threshold, List<Node> simplifiedNodes) {
236
237 Node fromN = wnew.get(from);
238 Node toN = wnew.get(to);
239
240 // Get max xte
241 int imax = -1;
242 double xtemax = 0;
243 for (int i = from + 1; i < to; i++) {
244 Node n = wnew.get(i);
245 double xte = Math.abs(Ellipsoid.WGS84.a
246 * xtd(fromN.getCoor().lat() * Math.PI / 180, fromN.getCoor().lon() * Math.PI / 180, toN.getCoor().lat() * Math.PI
247 / 180, toN.getCoor().lon() * Math.PI / 180, n.getCoor().lat() * Math.PI / 180, n.getCoor().lon() * Math.PI
248 / 180));
249 if (xte > xtemax) {
250 xtemax = xte;
251 imax = i;
252 }
253 }
254
255 if (imax != -1 && xtemax >= threshold) {
256 // Segment cannot be simplified - try shorter segments
257 buildSimplifiedNodeList(wnew, from, imax, threshold, simplifiedNodes);
258 buildSimplifiedNodeList(wnew, imax, to, threshold, simplifiedNodes);
259 } else {
260 // Simplify segment
261 if (simplifiedNodes.isEmpty() || simplifiedNodes.get(simplifiedNodes.size()-1) != fromN) {
262 simplifiedNodes.add(fromN);
263 }
264 if (fromN != toN) {
265 simplifiedNodes.add(toN);
266 }
267 }
268 }
269
270 /* From Aviaton Formulary v1.3
271 * http://williams.best.vwh.net/avform.htm
272 */
273 private static double dist(double lat1, double lon1, double lat2, double lon2) {
274 return 2 * Math.asin(Math.sqrt(Math.pow(Math.sin((lat1 - lat2) / 2), 2) + Math.cos(lat1) * Math.cos(lat2)
275 * Math.pow(Math.sin((lon1 - lon2) / 2), 2)));
276 }
277
278 private static double course(double lat1, double lon1, double lat2, double lon2) {
279 return Math.atan2(Math.sin(lon1 - lon2) * Math.cos(lat2), Math.cos(lat1) * Math.sin(lat2) - Math.sin(lat1)
280 * Math.cos(lat2) * Math.cos(lon1 - lon2))
281 % (2 * Math.PI);
282 }
283
284 private static double xtd(double lat1, double lon1, double lat2, double lon2, double lat3, double lon3) {
285 double distAD = dist(lat1, lon1, lat3, lon3);
286 double crsAD = course(lat1, lon1, lat3, lon3);
287 double crsAB = course(lat1, lon1, lat2, lon2);
288 return Math.asin(Math.sin(distAD) * Math.sin(crsAD - crsAB));
289 }
290
291 @Override
292 protected void updateEnabledState() {
293 updateEnabledStateOnCurrentSelection();
294 }
295
296 @Override
297 protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
298 setEnabled(selection != null && !selection.isEmpty());
299 }
300}
Note: See TracBrowser for help on using the repository browser.