source: josm/trunk/resources/data/validator/geometry.mapcss @ 16379

Last change on this file since 16379 was 16379, checked in by GerdP, 5 months ago

see #19145: some unclosed ways are not found

  • add check for unclosed place=* ways
  • remove special mapcss check for unclosed place=island ways
  • Property svn:eol-style set to native
File size: 15.2 KB
Line 
1/* {0} on a node, should be a way */
2node[area=no],
3node[oneway],
4node[bridge],
5node[sidewalk],
6node[footway][footway!=crossing], /* footway=crossing has own warning in highway.mapcss */
7node[man_made=embankment],
8node[man_made=groyne],
9node[man_made=cutline],
10node[power=line],
11node[cutline],
12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
38node[waterway=drain],
39node[natural=coastline],
40node[natural=ridge],
41node[natural=valley],
42node[natural=tree_row] {
43  throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
44  assertMatch: "node oneway=-1";
45  assertNoMatch: "way oneway=-1";
46  assertMatch: "node bridge=yes";
47  assertMatch: "node bridge=viaduct";
48}
49
50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52  throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
55/* {0} on a node, should be an area; #10679 #16528 #16792 #12502 #17402*/
56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
59node[area=yes],
60node[area:highway],
61node[landuse],
62node[natural=scree],
63node[natural=scrub],
64node[natural=fell],
65node[natural=heath],
66node[natural=wood],
67node[natural=grassland],
68node[natural=wetland],
69node[natural=water],
70node[natural=mud],
71node[natural=beach],
72node[natural=sand],
73node[natural=wood],
74node[natural=bare_rock],
75node[natural=glacier],
76node[leisure=park][natural!=tree], /* For nodes with both tags another warning is created in combinations.mapcss */
77node[leisure=nature_reserve],
78node[waterway=riverbank],
79node[man_made=bridge],
80node[man_made=breakwater],
81node[aeroway=apron],
82node[power=plant],
83node[power=switchgear],
84node[building:part],
85node[source:outline] {
86  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
87}
88
89/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
90node[type=multipolygon],
91node[interval],
92node[route],
93node[restriction] {
94  throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}"); 
95}
96
97/* {0} on a way, should be a node */
98way[line_attachment],
99way[emergency=fire_hydrant],
100way[entrance],
101way[door],
102way[railway=subway_entrance],
103way[man_made=survey_point],
104way[aeroway=holding_position],
105way[power=transformer],
106way[power=pole],
107way[power=catenary_mast],
108way[power=terminal],
109way[power=tower]!:closed,
110way[amenity=vending_machine],
111way[natural=peak],
112way[natural=saddle],
113way[natural=volcano],
114way[natural=tree],
115way[highway=give_way],
116way[highway=milestone],
117way[highway=mini_roundabout],
118way[highway=stop],
119way[highway=street_lamp],
120way[highway=traffic_signals],
121way[highway=turning_loop],
122way[highway=turning_circle],
123way[highway=motorway_junction] {
124  throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}"); 
125}
126
127/* {0} on a way, should be a relation; see #15642, #10252, #14288 */
128way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
129way[type=multipolygon],
130way[interval][route!=ferry],
131way[route=bus] {
132  throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}"); 
133}
134
135/* #14395, #17025 */
136way[highway][area!=yes][!tunnel][!covered] > node {
137  set node_in_highway;
138}
139way[highway][area!=yes][!tunnel][!covered]:closed > node {
140  set node_in_closed_highway;
141}
142way[highway][area!=yes][!tunnel][!covered] >[index=1] node,
143way[highway][area!=yes][!tunnel][!covered] >[index=-1] node {
144  set first_last_highway_node;
145}
146way[building][building!=no] > node[!entrance].node_in_closed_highway,
147way[building][building!=no] > node[!entrance].node_in_highway!.first_last_highway_node {
148  throwWarning: tr("node connects highway and building");
149}
150
151/* #15035, must not warn for node 3815077900*/
152node[man_made!=monitoring_station][at(0.0,0.0)] {
153  throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
154  fixDeleteObject: this;
155}
156
157/* see ticket:#10125 */
158node[source:geometry] {
159  throwWarning: tr("{0} on a node", "{0.key}");
160  fixChangeKey: "source:geometry => source:position";
161}
162
163/* Building inside building (spatial test) */
164*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")] 
165area[building][building!~/no|entrance/] {
166  throwWarning: tr("Building inside building");
167}
168
169/* Building overlapping building (spatial test) */
170area[building][building!~/no|entrance/]  area[building][building!~/no|entrance/] {
171  throwWarning: tr("Overlapping buildings");
172}
173
174/* Overlapping areas (spatial test) */
175area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
176  set water_area;
177}
178
179/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
180area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/]  area:closed:areaStyle.water_area,
181area:closed:areaStyle[landuse=reservoir]                         area:closed:areaStyle.water_area {
182  throwWarning: tr("Overlapping Water Areas");
183}
184
185/* Water area inside water area (spatial test) */
186area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/]   area:closed:areaStyle.water_area,
187area:closed:areaStyle[landuse=reservoir]                          area:closed:areaStyle.water_area {
188  throwWarning: tr("Water area inside water area");
189}
190
191area:closed:areaStyle  area:closed:areaStyle {
192  throwOther: tr("Overlapping Areas");
193}
194
195/* see ticket #9311 */
196node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/]  area[amenity=parking] {
197  throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
198  group: tr("{0} inside {1}", "amenity", "amenity");
199}
200
201/* see ticket #9556 */
202area:closed:areaStyle[tag("natural") = parent_tag("natural")]  area:closed:areaStyle[natural] {
203  throwWarning: tr("Overlapping Identical Natural Areas");
204}
205
206area:closed:areaStyle[tag("landuse") = parent_tag("landuse")]  area:closed:areaStyle[landuse] {
207  throwWarning: tr("Overlapping Identical Landuses");
208}
209
210/* see ticket:#9522 */
211node[tag("amenity") = parent_tag("amenity")]  area[amenity][amenity != parking] {
212  throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
213  group: tr("{0} inside {1}", "amenity", "amenity");
214}
215node[tag("leisure") = parent_tag("leisure")]  area[leisure] {
216  throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
217  group: tr("{0} inside {1}", "leisure", "leisure");
218}
219node[tag("tourism") = parent_tag("tourism")]  area[tourism] {
220  throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
221  group: tr("{0} inside {1}", "tourism", "tourism");
222}
223node[tag("shop") = parent_tag("shop")]  area[shop] {
224  throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
225  group: tr("{0} inside {1}", "shop", "shop");
226}
227node[tag("power") = parent_tag("power")]  area[power] {
228  throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
229  group: tr("{0} inside {1}", "power", "power");
230}
231
232/* isolated nodes which should be part of a way, see #10825, #15478 */
233node:unconnected:in-downloaded-area[entrance],
234node:unconnected:in-downloaded-area[traffic_calming],
235node:unconnected:in-downloaded-area[highway=passing_place],
236node:unconnected:in-downloaded-area[highway=mini_roundabout],
237node:unconnected:in-downloaded-area[highway=motorway_junction],
238node:unconnected:in-downloaded-area[highway=turning_loop],
239node:unconnected:in-downloaded-area[highway=turning_circle],
240node:unconnected:in-downloaded-area[highway=stop],
241node:unconnected:in-downloaded-area[highway=give_way],
242node:unconnected:in-downloaded-area[highway=traffic_signals],
243node:unconnected:in-downloaded-area[highway=crossing],
244node:unconnected:in-downloaded-area[crossing],
245node:unconnected:in-downloaded-area[highway=milestone],
246node:unconnected:in-downloaded-area[railway=milestone],
247node:unconnected:in-downloaded-area[railway=crossing],
248node:unconnected:in-downloaded-area[railway=level_crossing],
249node:unconnected:in-downloaded-area[railway=buffer_stop],
250node:unconnected:in-downloaded-area[public_transport=stop_position],
251node:unconnected:in-downloaded-area[aeroway=holding_position],
252node:unconnected:in-downloaded-area[noexit],
253node:unconnected:in-downloaded-area[waterway=dam],
254node:unconnected:in-downloaded-area[waterway=weir],
255node:unconnected:in-downloaded-area[waterway=waterfall],
256node:unconnected:in-downloaded-area[amenity=ferry_terminal],
257node:unconnected:in-downloaded-area[leisure=slipway],
258node:unconnected:in-downloaded-area[mountain_pass=yes],
259node:unconnected:in-downloaded-area[barrier=gate],
260node:unconnected:in-downloaded-area[barrier=lift_gate],
261node:unconnected:in-downloaded-area[barrier=swing_gate],
262node:unconnected:in-downloaded-area[barrier=toll_booth],
263node:unconnected:in-downloaded-area[barrier=turnstile],
264node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
265node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
266node:unconnected:in-downloaded-area[barrier=rope],
267node:unconnected:in-downloaded-area[barrier=sally_port],
268node:unconnected:in-downloaded-area[barrier=spikes],
269node:unconnected:in-downloaded-area[barrier=stile],
270node:unconnected:in-downloaded-area[barrier=sump_buster],
271node:unconnected:in-downloaded-area[barrier=kerb],
272node:unconnected:in-downloaded-area[barrier=border_control],
273node:unconnected:in-downloaded-area[barrier=bump_gate],
274node:unconnected:in-downloaded-area[barrier=bus_trap],
275node:unconnected:in-downloaded-area[barrier=cattle_grid],
276node:unconnected:in-downloaded-area[barrier=chain],
277node:unconnected:in-downloaded-area[barrier=cycle_barrier],
278node:unconnected:in-downloaded-area[barrier=hampshire_gate],
279node:unconnected:in-downloaded-area[barrier=height_restrictor],
280node:unconnected:in-downloaded-area[barrier=debris] {
281  throwWarning: tr("{0}", "{2.tag}");
282  group: tr("isolated node which must be connected to a way");
283}
284
285/* #11127 */
286way[railway][bridge] > node,
287way[highway][bridge] > node {
288  set node_in_bridge;
289}
290way[waterway] > node.node_in_bridge {
291  throwWarning: tr("node connects waterway and bridge");
292}
293
294/* #11128, #14812, #15032 */
295way[highway] > node[tourism=information][information=guidepost] {
296  set guidepost;
297  throwOther: tr("{0} node connected to a highway", "{1.tag}");
298}
299way >[index=1] node,
300way >[index=-1] node {
301  set first_last_node;
302}
303way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge|taxi|toilets)$/],
304way[highway] > node[building][!entrance],
305way[highway] > node[leisure][!entrance][leisure!=slipway][leisure!=fitness_station],
306way[highway] > node[office][!entrance],
307way[highway] > node[shop][!entrance],
308way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
309way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
310  throwWarning: tr("{0} node connected to a highway", "{0.key}");
311}
312
313/* #18817 */
314way[man_made=pipeline][location=underground] > node[marker],
315way[power=cable      ][location=underground] > node[marker] {
316  throwWarning: tr("{0} node connected to an underground object", "{0.key}");
317}
318
319way[junction=roundabout]:righthandtraffic:clockwise,
320way[junction=roundabout]!:righthandtraffic:anticlockwise {
321  throwWarning: tr("suspicious roundabout direction");
322}
323
324/* #12496 */
325area:closed[place=islet][eval(areasize()) > 1500000] {
326  throwWarning: tr("{0} on a large area", "{1.tag}");
327  suggestAlternative: "place=island";
328  fixAdd: "place=island";
329}
330
331area:closed[place=island][eval(areasize()) < 500000] {
332  throwWarning: tr("{0} on a small area", "{1.tag}");
333  suggestAlternative: "place=islet";
334  fixAdd: "place=islet";
335}
336
337/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
338area:closed[building][building!=no][eval(areasize()) > 520000] {
339  throwError: tr("Too large building");
340}
341
342/* #12577 */
343way[power=line] > node,
344way[power=minor_line] > node,
345way[power=cable] > node {
346  set node_in_power_way;
347}
348way[!power][!building] > node.node_in_power_way {
349  throwWarning: tr("Node connects a power line or cable with an object which is not related to the power infrastructure.");
350}
351
352/* #12646, #12992, #16334 */
353way[waterway=~/^(stream|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area { 
354  throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
355}
356
357/* #10717, #14535 */
358way:closed[natural=coastline]  area[natural=water],
359way:closed[natural=coastline]  area[waterway=riverbank] {
360  throwError: tr("Coastline inside {1}", "{0.tag}");
361}
362
363/* #10471 */
364way[waterway] > node[ford?] { set ford_on_waterway; }
365way[highway] > node[ford?] { set ford_on_highway; }
366node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
367    throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
368}
369
370/* #13877 */
371area:closed[waterway = canal][area!=no],
372area:closed[waterway = drain][area!=no],
373area:closed[waterway = ditch][area!=no],
374area:closed[waterway = stream][area!=no],
375area:closed[waterway = river][area!=no] {
376  throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
377}
378
379/* #15097 */
380way[highway][area!=yes] > node,
381way[man_made=pier] > node {
382  set node_in_highway_pier;
383}
384way[route=ferry][tunnel=yes] > node,
385way[route=ferry][bridge=yes] > node {
386  set node_in_ferry_bridge_tunnel;
387}
388way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
389way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
390  throwWarning: tr("Ferry route is not connected to the road network or branches.");
391}
392way[amenity=ferry_terminal] > node,
393way[man_made=pier] > node {
394  set node_in_terminal_pier;
395}
396way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
397way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
398  throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
399}
400
401/* #10391 - Many misuses of building=hangar instead of building=barn/industrial/warehouse */
402area:closed2[aeroway]  way[building=hangar][!aeroway] {
403  throwWarning: tr("{0} outside of {1}", "{0.tag}", "aeroway");
404  suggestAlternative: "building=barn";
405  suggestAlternative: "building=industrial";
406  suggestAlternative: "building=warehouse";
407}
Note: See TracBrowser for help on using the repository browser.