source: josm/trunk/data/validator/unnecessary.mapcss@ 15044

Last change on this file since 15044 was 15044, checked in by Don-vip, 5 years ago

fix #17633 - complain about even more descriptive names (patch by mkoniecz, modified)

  • Property svn:eol-style set to native
File size: 7.6 KB
Line 
1*[access][highway=proposed],
2*[motor_vehicle?][!vehicle][!access][bicycle_road!=yes][highway =~ /^(motorway|motorway_link|trunk|trunk_link|primary|primary_link|secondary|secondary_link|tertiary|tertiary_link|unclassified|residential|service|living_street)$/],
3*[bridge=no],
4*[building=no],
5*[elevation="0"],
6*[layer="0"] {
7 /* see #9365 - Useless tag layer=0 */
8 throwWarning: tr("{0} is unnecessary", "{0.tag}");
9 group: tr("unnecessary tag");
10 fixRemove: "{0.key}";
11 assertMatch: "way layer=0";
12 assertMatch: "way bridge=no";
13 assertMatch: "way highway=proposed access=no";
14 assertMatch: "way highway=motorway motor_vehicle=yes";
15 assertNoMatch: "way highway=motorway access=no motor_vehicle=yes";
16}
17
18area:closed[amenity ][area?][!highway],
19area:closed[building][area?],
20area:closed[landuse ][area?][!highway],
21area:closed[leisure ][area?][!highway][leisure!=track][leisure!=slipway],
22area:closed[natural ][area?],
23area:closed[shop ][area?] {
24 throwWarning: tr("{0} is unnecessary for {1}", "{2.key}", "{1.key}");
25 group: tr("unnecessary tag");
26 fixRemove: "{2.key}";
27}
28
29/* #14256, #15664 */
30area:closed[highway=rest_area][area?],
31area:closed[highway=services][area?],
32area:closed[aeroway=aerodrome][area?],
33area:closed[aeroway=helipad][area?] {
34 throwWarning: tr("{0} is unnecessary for {1}", "{2.key}", "{1.tag}");
35 group: tr("unnecessary tag");
36 fixRemove: "{2.key}";
37}
38
39/* #9257, #17482 */
40way[foot =~ /^(yes|designated)$/][highway =~ /^(footway|pedestrian)$/][!access],
41way[bicycle =~ /^(yes|designated)$/][highway=cycleway][!vehicle][!access][foot!=designated],
42*[gnis:Class="Populated Place"][place=city],
43*[gnis:Class="Populated Place"][place=town],
44*[gnis:Class="Populated Place"][place=village],
45*[gnis:Class="Populated Place"][place=hamlet],
46*[gnis:Class=Summit][natural=peak] {
47 throwWarning: tr("{0} is unnecessary for {1}", "{0.tag}", "{1.tag}");
48 group: tr("unnecessary tag");
49 fixRemove: "{0.key}";
50 assertMatch: "way highway=pedestrian foot=designated";
51 assertNoMatch: "way highway=pedestrian access=no foot=designated";
52 /* see #17555 assertNoMatch: "node gnis:Class="Populated Place" place=locality";*/
53}
54
55*[emergency=permissive] {
56 /* see #9458 - emergency=permissive makes no sense */
57 throwWarning: tr("{0} makes no sense", "{0.tag}");
58 fixAdd: "emergency=yes";
59 assertMatch: "way emergency=permissive";
60 assertNoMatch: "way emergency=designated";
61}
62
63/* see ticket #7639 -- Warn when a node has the same tags as its parent way. */
64way >:sameTags node:tagged {
65 throwWarning: tr("Nodes duplicating parent way tags");
66}
67
68/* #15477 */
69*[payment:cash][payment:coins][payment:notes] {
70 throwWarning: tr("{0} together with {1} and {2}. Remove {0}.", "{0.key}", "{1.key}", "{2.key}");
71 group: tr("unnecessary tag");
72 fixRemove: "payment:cash";
73}
74
75/* see #10346, #15667 */
76way[waterway][oneway?] {
77 throwWarning: tr("{0} is unnecessary for {1}", "{1.key}", "{0.key}");
78 group: tr("unnecessary tag");
79 fixRemove: "{1.key}";
80}
81way[waterway][oneway=-1] {
82 throwWarning: tr("{0} is unnecessary for {1}. The flow direction is defined by the way direction.", "{1.key}", "{0.key}");
83 group: tr("unnecessary tag");
84}
85
86/* #15774 */
87node[emergency=fire_hydrant][fire_hydrant:count=1] {
88 throwWarning: tr("{0} is unnecessary for {1}", "{1.tag}", "{0.tag}");
89 group: tr("unnecessary tag");
90 fixRemove: "{1.key}";
91}
92
93/* #17100, #17471, #17629, #17633 */
94*[name][name=~/^(?i)(parc|park)$/][leisure=park],
95*[name][name=~/^(?i)(pond)$/][water=pond],
96*[name][name=~/^(?i)(chapel|chapelle|kapelle)$/][building=chapel],
97*[name][name=~/^(?i)(church|église|biserica)$/][amenity=place_of_worship][religion=christian],
98*[name][name=~/^(?i)(mosque|cami|masjid|مسجد)$/][amenity=place_of_worship][religion=muslim],
99*[name][name=~/^(?i)(parking|parkplatz)$/][amenity=parking],
100*[name][name=~/^(?i)(post office)$/][amenity=post_office],
101*[name][name=~/^(?i)(restaurant)$/][amenity=restaurant],
102*[name][name=~/^(?i)(toilets?)$/][amenity=toilets],
103*[name][name=~/^(?i)(playground|spielplatz)$/][leisure=playground],
104*[name][name=~/^(?i)(shop|boutique)$/][shop][shop!=no],
105*[name][name=~/^(?i)(building|bangunan)$/][building][building!=no],
106*[name][name=~/^(?i)(house|casa|maison|rumah|vivienda)$/][building=house],
107*[name][name=~/^(?i)(kiosk)$/][shop=kiosk],
108*[name][name=~/^(?i)(path)$/][highway=path],
109*[name][name=~/^(?i)(jalan)$/][highway],
110*[name][name=~/^(?i)(silo)$/][man_made=silo],
111*[name][name=~/^(?i)(silo)$/][building=silo],
112*[name][name=~/^(?i)(cemetery|cementerio|cimetière|cmentarz|friedhof)$/][amenity=grave_yard],
113*[name][name=~/^(?i)(cemetery|cementerio|cimetière|cmentarz|friedhof)$/][landuse=cemetery],
114*[name][name=~/^(?i)(mairie|rathaus)$/][amenity=townhall],
115*[name][name=~/^(?i)(monument aux morts|war memorial)$/][historic=memorial][memorial=war_memorial],
116*[name][name=~/^(?i)(school|école|Школа)$/][building=school],
117*[name][name=~/^(?i)(school|école|Школа)$/][amenity=school],
118*[name][name=~/^(?i)(école élémentaire)$/][amenity=school]["school:FR"="élémentaire"],
119*[name][name=~/^(?i)(école maternelle)$/][amenity=school]["school:FR"="maternelle"],
120*[name][name=~/^(?i)(école primaire)$/][amenity=school]["school:FR"="primaire"],
121*[name][name=~/^(?i)(collège)$/][amenity=school]["school:FR"="collège"],
122*[name][name=~/^(?i)(lycée)$/][amenity=school]["school:FR"="lycée"],
123*[name][name=~/^(?i)(Аптека|farmacia|pharmacy|pharmacie)$/][amenity=pharmacy],
124*[name][name=~/^(?i)(АГЗС|АЗС)$/][amenity=fuel] {
125 throwWarning: tr("{0}", "{0.tag}");
126 group: tr("descriptive name");
127 fixRemove: "name";
128 assertMatch: "node name=parking amenity=parking";
129 assertMatch: "node name=Parking amenity=parking";
130 assertNoMatch: "node name=Parking_with_suffix amenity=parking";
131 assertNoMatch: "node name=Megaparking amenity=parking";
132 assertMatch: "relation name=parking amenity=parking type=multipolygon";
133 assertMatch: "relation name=Parking amenity=parking type=multipolygon";
134 assertNoMatch: "way name=parking";
135 assertMatch: "relation name=PLAYGROUND leisure=playground type=multipolygon";
136 assertMatch: "node name=PLaYGrOUNd leisure=playground";
137 assertMatch: "node name=shop shop=whatever";
138 assertNoMatch: "node name=shop shop=no";
139 assertNoMatch: "way name=shop leisure=playground";
140 assertMatch: "way name=building building=yes";
141 assertMatch: "way name=building building=house";
142 assertMatch: "way name=Rumah building=house";
143 assertNoMatch: "way name=Rumah building=yes";
144 assertMatch: "way name=house building=house";
145 assertNoMatch: "way name=house building=yes";
146 assertMatch: "way name=kiosk building=yes shop=kiosk";
147 assertNoMatch: "way name=kiosk building=yes";
148 assertMatch: "way name=silo man_made=silo";
149 assertMatch: "way name=Silo man_made=silo building=silo";
150 assertMatch: "way name=Silo building=silo";
151 assertMatch: "way name=cemetery amenity=grave_yard";
152 assertMatch: "way name=Cmentarz amenity=grave_yard";
153 assertNoMatch: "way name=kiosk amenity=grave_yard";
154}
155*[name][name=~/^(?i)(house|casa|rumah|vivienda)$/][building][building!=house][building!=no] {
156 throwWarning: tr("{0}", "{0.tag}");
157 group: tr("descriptive name");
158 /* without fixRemove to avoid possible information loss */
159 assertNoMatch: "way name=building building=yes";
160 assertNoMatch: "way name=building building=house";
161 assertNoMatch: "way name=Rumah building=house";
162 assertMatch: "way name=Rumah building=yes";
163 assertNoMatch: "way name=house building=house";
164 assertMatch: "way name=house building=yes";
165}
166*[name][name=~/^(?i)(school|école|Школа)$/][building][building!=school][building!=no] {
167 throwWarning: tr("{0}", "{0.tag}");
168 group: tr("descriptive name");
169 /* without fixRemove to avoid possible information loss */
170}
Note: See TracBrowser for help on using the repository browser.