source: josm/trunk/data/validator/highway.mapcss@ 13339

Last change on this file since 13339 was 13005, checked in by Klumbumbus, 7 years ago

fix #15439 - fine tune some validator rules (patch by nyurik)

  • Property svn:eol-style set to native
File size: 5.9 KB
RevLine 
[7281]1way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/] {
[6601]2 set major_road;
3}
[7281]4way[highway=~/^.*_link$/] {
5 set link_road;
6}
[6601]7way[highway=~/^(unclassified|residential|living_street|service)$/] {
8 set minor_road;
9}
10
[6874]11way[highway][name =~ /(?i).* (Ave|Blvd|Br|Brg|Cct|Cir|Cl|Cr|Crct|Cres|Crt|Ct|Dr|Drv|Esp|Espl|Hwy|Ln|Mw|Mwy|Pky|Pkwy|Pl|Rd|Qy|Qys|Sq|St|Str|Ter|Tce|Tr|Wy)[.]?$/] {
[6513]12 throwWarning: tr("abbreviated street name");
13 assertMatch: "way highway=unclassified name=\"Foo Ave\"";
14 assertMatch: "way highway=unclassified name=\"Foo Ave.\"";
15 assertMatch: "way highway=unclassified name=\"Bou Blvd.\"";
16 assertMatch: "way highway=unclassified name=\"Bou blvd.\"";
17}
18
[11050]19node[highway =~ /motorway|trunk|primary|secondary|tertiary|unclassified|residential|service|living_street|pedestrian|track|path|footway|cycleway|bus_guideway|bridleway/][highway!=motorway_junction][highway!=services] {
[6513]20 throwWarning: tr("wrong highway tag on a node");
21 assertMatch: "node highway=primary";
22 assertMatch: "node highway=primary_link";
[6516]23 assertNoMatch: "node highway=traffic_calming";
24 assertNoMatch: "node highway=bus_stop";
[6513]25 assertNoMatch: "node highway=crossing";
[6516]26 assertNoMatch: "node highway=emergency_access_point";
27 assertNoMatch: "node highway=give_way";
28 assertNoMatch: "node highway=mini_roundabout";
29 assertNoMatch: "node highway=motorway_junction";
30 assertNoMatch: "node highway=passing_place";
31 assertNoMatch: "node highway=rest_area";
32 assertNoMatch: "node highway=speed_camera";
33 assertNoMatch: "node highway=street_lamp";
34 assertNoMatch: "node highway=services";
35 assertNoMatch: "node highway=stop";
36 assertNoMatch: "node highway=traffic_signals";
37 assertNoMatch: "node highway=turning_circle";
[6513]38}
39
[7977]40way[highway=crossing],
41way[railway=crossing],
42way[railway=level_crossing] {
[6513]43 throwWarning: tr("wrong crossing tag on a way");
44 assertMatch: "way highway=crossing";
45 assertNoMatch: "node highway=crossing";
46}
47
[7932]48way[highway=unclassified][!name][noname!=yes] {
[6513]49 throwOther: tr("Unnamed unclassified highway");
50 assertMatch: "way highway=unclassified";
[7932]51 assertNoMatch: "way highway=unclassified noname=yes";
[6513]52 assertNoMatch: "way highway=unclassified name=Foo";
53}
54
[12194]55way.major_road[!ref][!destination:ref][noref!=yes] {
[6513]56 throwOther: tr("highway without a reference");
[11146]57 group: tr("missing tag");
[6513]58 assertMatch: "way highway=primary";
59 assertNoMatch: "way highway=primary ref=123";
[11337]60 assertNoMatch: "way highway=primary destination:ref=123";
[12194]61 assertNoMatch: "way highway=primary noref=yes";
[6513]62}
63
64way[highway=road] {
[12418]65 throwWarning: tr("Unspecific highway type");
[6513]66 assertMatch: "way highway=road";
67 assertNoMatch: "way highway=residential";
68}
69
[6550]70way[highway=footway][maxspeed],
71way[highway=steps][maxspeed],
[7819]72way[highway=cycleway][bicycle=no],
73way[highway=footway][foot=no],
[6550]74way[highway=cycleway][cycleway=lane] {
75 throwWarning: tr("{0} used with {1}", "{0.value}", "{1.tag}");
[6513]76 assertNoMatch: "way highway=cycleway bicycle=yes";
77 assertNoMatch: "way highway=cycleway";
78 assertNoMatch: "way highway=footway foot=yes";
79 assertNoMatch: "way highway=footway";
80 assertMatch: "way highway=cycleway cycleway=lane";
81 assertNoMatch: "way highway=cycleway";
82 assertNoMatch: "way highway=residential cycleway=lane";
83 assertMatch: "way highway=footway maxspeed=20";
84 assertNoMatch: "way highway=residential maxspeed=20";
85 assertNoMatch: "way highway=footway";
86}
87
[13005]88/* footway, see #10851, #10976, #15439 */
89way[footway=left][/^footway:/],
90way[footway=right][/^footway:/],
91way[footway=both][/^footway:/],
92way[footway=no][/^footway:/] {
[11364]93 throwWarning: tr("{0} is deprecated, use {1} instead. Also check similar tags like {2}", "{0.tag}", "sidewalk", "{1.key}");
94 group: tr("deprecated tagging");
95 set not_fixable_footway;
96 assertMatch: "way footway=both footway:surface=asphalt";
97}
98way[footway=none][/footway:/] {
99 throwWarning: tr("{0} is deprecated, use {1} instead. Also check similar tags like {2}", "{0.tag}", "sidewalk=no", "{1.key}");
100 group: tr("deprecated tagging");
101 set not_fixable_footway;
102}
103way[footway=left]!.not_fixable_footway,
104way[footway=right]!.not_fixable_footway,
105way[footway=both]!.not_fixable_footway,
106way[footway=no]!.not_fixable_footway {
[7814]107 throwWarning: tr("{0} is deprecated", "{0.tag}");
108 suggestAlternative: "sidewalk";
[11139]109 group: tr("deprecated tagging");
[7814]110 fixChangeKey: "footway => sidewalk";
[11364]111 set fixable_footway;
[7814]112}
[11364]113way[footway=none]!.not_fixable_footway {
[7814]114 throwWarning: tr("{0} is deprecated", "{0.tag}");
115 suggestAlternative: "sidewalk=no";
[11139]116 group: tr("deprecated tagging");
[7814]117 fixRemove: "footway";
118 fixAdd: "sidewalk=no";
[11364]119 set fixable_footway;
[7814]120}
[11364]121way[footway][footway!=sidewalk][footway!=crossing]!.fixable_footway!.not_fixable_footway { /* do not trigger this rule if already one of the 4 previous rules applied */
[7814]122 throwWarning: tr("Value of ''{0}'' should either be ''{1}'' or ''{2}''. For sidewalks use ''{3}'' instead.", "{0.key}", "{1.value}", "{2.value}", "sidewalk=left|right|both|no");
[11049]123 assertNoMatch: "way footway=left";
124 assertNoMatch: "way footway=none";
[11364]125 assertNoMatch: "way footway=left footway:left:surface=asphalt";
[11049]126 assertMatch: "way footway=bar";
[9839]127}
128
[13005]129/* #11270, #9297, #15439 */
[12895]130way[railway =~ /^(light_rail|miniature|narrow_gauge|preserved|rail)$/][!highway] > node { set .is_in_railway }
[12595]131way[highway =~ /^(bridleway|cycleway|footway|path|steps)$/] > node { set .is_in_minor_road }
[13005]132way[highway =~ /^(bus_guideway|living_street|motorway|motorway_link|pedestrian|primary|primary_link|raceway|residential|road|secondary|secondary_link|service|tertiary|tertiary_link|track|trunk|trunk_link|unclassified)$/] > node { set .is_in_major_road }
[12595]133node[railway!=crossing].is_in_railway.is_in_minor_road!.is_in_major_road {
[9839]134 throwWarning: tr("pedestrian railway crossing without {0}", "{0.tag}");
[11146]135 group: tr("missing tag");
[9839]136 fixAdd: "railway=crossing";
137}
[12595]138node[railway!=level_crossing].is_in_railway.is_in_major_road!.is_in_minor_road {
[9839]139 throwWarning: tr("railway crossing without {0}", "{0.tag}");
[11146]140 group: tr("missing tag");
[9839]141 fixAdd: "railway=level_crossing";
[7814]142}
Note: See TracBrowser for help on using the repository browser.