source: josm/trunk/data/validator/geometry.mapcss @ 15961

Last change on this file since 15961 was 15961, checked in by GerdP, 9 months ago

fix #16707: Warn about overlapping connected buildings

  • add rule in geometry.mapcss to check overlapping buildings
  • change rule which checks overlapping identical landuses to also check landuse=residential
  • disable the corresponding tests in CrossingWays

effects for the user:

  • Message "Crossing buildings" is replaced by "Overlapping buildings"
  • Message "Crossing residential areas" is replaced by generic "Overlapping Identical Landuses"
  • different highlighting of the overlapping area
  • Property svn:eol-style set to native
File size: 15.2 KB
Line 
1/* {0} on a node, should be a way */
2node[area=no],
3node[oneway],
4node[bridge],
5node[sidewalk],
6node[footway][footway!=crossing], /* footway=crossing has own warning in highway.mapcss */
7node[man_made=embankment],
8node[man_made=groyne],
9node[man_made=cutline],
10node[power=line],
11node[cutline],
12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
38node[waterway=drain],
39node[natural=coastline],
40node[natural=ridge],
41node[natural=valley],
42node[natural=tree_row] {
43  throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
44  assertMatch: "node oneway=-1";
45  assertNoMatch: "way oneway=-1";
46  assertMatch: "node bridge=yes";
47  assertMatch: "node bridge=viaduct";
48}
49
50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52  throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
55/* {0} on a node, should be an area; #10679 #16528 #16792 #12502 #17402*/
56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
59node[area=yes],
60node[area:highway],
61node[landuse],
62node[natural=scree],
63node[natural=scrub],
64node[natural=fell],
65node[natural=heath],
66node[natural=wood],
67node[natural=grassland],
68node[natural=wetland],
69node[natural=water],
70node[natural=mud],
71node[natural=beach],
72node[natural=sand],
73node[natural=wood],
74node[natural=bare_rock],
75node[natural=glacier],
76node[leisure=park][natural!=tree], /* For nodes with both tags another warning is created in combinations.mapcss */
77node[leisure=nature_reserve],
78node[waterway=riverbank],
79node[man_made=bridge],
80node[man_made=breakwater],
81node[aeroway=apron],
82node[power=plant],
83node[power=switchgear],
84node[building:part],
85node[source:outline] {
86  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
87}
88
89/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
90node[type=multipolygon],
91node[interval],
92node[route],
93node[restriction] {
94  throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}"); 
95}
96
97/* {0} on a way, should be a node */
98way[line_attachment],
99way[emergency=fire_hydrant],
100way[entrance],
101way[door],
102way[railway=subway_entrance],
103way[man_made=survey_point],
104way[aeroway=holding_position],
105way[power=transformer],
106way[power=pole],
107way[power=catenary_mast],
108way[power=terminal],
109way[power=tower]!:closed,
110way[amenity=vending_machine],
111way[natural=peak],
112way[natural=saddle],
113way[natural=volcano],
114way[natural=tree],
115way[highway=give_way],
116way[highway=milestone],
117way[highway=mini_roundabout],
118way[highway=stop],
119way[highway=street_lamp],
120way[highway=traffic_signals],
121way[highway=turning_loop],
122way[highway=turning_circle],
123way[highway=motorway_junction] {
124  throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}"); 
125}
126
127/* {0} on a way, should be a relation; see #15642, #10252, #14288 */
128way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
129way[type=multipolygon],
130way[interval][route!=ferry],
131way[route=bus] {
132  throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}"); 
133}
134
135/* #14395, #17025 */
136way[highway][area!=yes][!tunnel][!covered] > node {
137  set node_in_highway;
138}
139way[highway][area!=yes][!tunnel][!covered]:closed > node {
140  set node_in_closed_highway;
141}
142way[highway][area!=yes][!tunnel][!covered] >[index=1] node,
143way[highway][area!=yes][!tunnel][!covered] >[index=-1] node {
144  set first_last_highway_node;
145}
146way[building][building!=no] > node[!entrance].node_in_closed_highway,
147way[building][building!=no] > node[!entrance].node_in_highway!.first_last_highway_node {
148  throwWarning: tr("node connects highway and building");
149}
150
151/* #15035, must not warn for node 3815077900*/
152node[man_made!=monitoring_station][at(0.0,0.0)] {
153  throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
154  fixDeleteObject: this;
155}
156
157/* see ticket:#10125 */
158node[source:geometry] {
159  throwWarning: tr("{0} on a node", "{0.key}");
160  fixChangeKey: "source:geometry => source:position";
161}
162
163/* Building inside building (spatial test) */
164*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")] 
165area[building][building!~/no|entrance/] {
166  throwWarning: tr("Building inside building");
167}
168
169/* Building overlapping building (spatial test) */
170area[building][building!~/no|entrance/]  area[building][building!~/no|entrance/] {
171  throwWarning: tr("Overlapping buildings");
172}
173
174/* Overlapping areas (spatial test) */
175area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
176  set water_area;
177}
178
179/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
180area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/]  area:closed:areaStyle.water_area,
181area:closed:areaStyle[landuse=reservoir]                         area:closed:areaStyle.water_area {
182  throwWarning: tr("Overlapping Water Areas");
183}
184
185area:closed:areaStyle  area:closed:areaStyle {
186  throwOther: tr("Overlapping Areas");
187}
188
189/* see ticket #9311 */
190node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/]  area[amenity=parking] {
191  throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
192  group: tr("{0} inside {1}", "amenity", "amenity");
193}
194
195/* see ticket #9556 */
196area:closed:areaStyle[tag("natural") = parent_tag("natural")]  area:closed:areaStyle[natural] {
197  throwWarning: tr("Overlapping Identical Natural Areas");
198}
199
200area:closed:areaStyle[tag("landuse") = parent_tag("landuse")]  area:closed:areaStyle[landuse] {
201  throwWarning: tr("Overlapping Identical Landuses");
202}
203
204/* see ticket:#9522 */
205node[tag("amenity") = parent_tag("amenity")]  area[amenity][amenity != parking] {
206  throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
207  group: tr("{0} inside {1}", "amenity", "amenity");
208}
209node[tag("leisure") = parent_tag("leisure")]  area[leisure] {
210  throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
211  group: tr("{0} inside {1}", "leisure", "leisure");
212}
213node[tag("tourism") = parent_tag("tourism")]  area[tourism] {
214  throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
215  group: tr("{0} inside {1}", "tourism", "tourism");
216}
217node[tag("shop") = parent_tag("shop")]  area[shop] {
218  throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
219  group: tr("{0} inside {1}", "shop", "shop");
220}
221node[tag("power") = parent_tag("power")]  area[power] {
222  throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
223  group: tr("{0} inside {1}", "power", "power");
224}
225
226/* isolated nodes which should be part of a way, see #10825, #15478 */
227node:unconnected:in-downloaded-area[entrance],
228node:unconnected:in-downloaded-area[traffic_calming],
229node:unconnected:in-downloaded-area[highway=passing_place],
230node:unconnected:in-downloaded-area[highway=mini_roundabout],
231node:unconnected:in-downloaded-area[highway=motorway_junction],
232node:unconnected:in-downloaded-area[highway=turning_loop],
233node:unconnected:in-downloaded-area[highway=turning_circle],
234node:unconnected:in-downloaded-area[highway=stop],
235node:unconnected:in-downloaded-area[highway=give_way],
236node:unconnected:in-downloaded-area[highway=traffic_signals],
237node:unconnected:in-downloaded-area[highway=crossing],
238node:unconnected:in-downloaded-area[crossing],
239node:unconnected:in-downloaded-area[highway=milestone],
240node:unconnected:in-downloaded-area[railway=milestone],
241node:unconnected:in-downloaded-area[railway=crossing],
242node:unconnected:in-downloaded-area[railway=level_crossing],
243node:unconnected:in-downloaded-area[railway=buffer_stop],
244node:unconnected:in-downloaded-area[public_transport=stop_position],
245node:unconnected:in-downloaded-area[aeroway=holding_position],
246node:unconnected:in-downloaded-area[noexit],
247node:unconnected:in-downloaded-area[waterway=dam],
248node:unconnected:in-downloaded-area[waterway=weir],
249node:unconnected:in-downloaded-area[waterway=waterfall],
250node:unconnected:in-downloaded-area[amenity=ferry_terminal],
251node:unconnected:in-downloaded-area[leisure=slipway],
252node:unconnected:in-downloaded-area[mountain_pass=yes],
253node:unconnected:in-downloaded-area[barrier=gate],
254node:unconnected:in-downloaded-area[barrier=lift_gate],
255node:unconnected:in-downloaded-area[barrier=swing_gate],
256node:unconnected:in-downloaded-area[barrier=toll_booth],
257node:unconnected:in-downloaded-area[barrier=turnstile],
258node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
259node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
260node:unconnected:in-downloaded-area[barrier=rope],
261node:unconnected:in-downloaded-area[barrier=sally_port],
262node:unconnected:in-downloaded-area[barrier=spikes],
263node:unconnected:in-downloaded-area[barrier=stile],
264node:unconnected:in-downloaded-area[barrier=sump_buster],
265node:unconnected:in-downloaded-area[barrier=kerb],
266node:unconnected:in-downloaded-area[barrier=border_control],
267node:unconnected:in-downloaded-area[barrier=bump_gate],
268node:unconnected:in-downloaded-area[barrier=bus_trap],
269node:unconnected:in-downloaded-area[barrier=cattle_grid],
270node:unconnected:in-downloaded-area[barrier=chain],
271node:unconnected:in-downloaded-area[barrier=cycle_barrier],
272node:unconnected:in-downloaded-area[barrier=hampshire_gate],
273node:unconnected:in-downloaded-area[barrier=height_restrictor],
274node:unconnected:in-downloaded-area[barrier=debris] {
275  throwWarning: tr("{0}", "{2.tag}");
276  group: tr("isolated node which must be connected to a way");
277}
278
279/* #11127 */
280way[railway][bridge] > node,
281way[highway][bridge] > node {
282  set node_in_bridge;
283}
284way[waterway] > node.node_in_bridge {
285  throwWarning: tr("node connects waterway and bridge");
286}
287
288/* #11128, #14812, #15032 */
289way[highway] > node[tourism=information][information=guidepost] {
290  set guidepost;
291  throwOther: tr("{0} node connected to a highway", "{1.tag}");
292}
293way >[index=1] node,
294way >[index=-1] node {
295  set first_last_node;
296}
297way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge|taxi|toilets)$/],
298way[highway] > node[building][!entrance],
299way[highway] > node[leisure][!entrance][leisure!=slipway][leisure!=fitness_station],
300way[highway] > node[office][!entrance],
301way[highway] > node[shop][!entrance],
302way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
303way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
304  throwWarning: tr("{0} node connected to a highway", "{0.key}");
305}
306
307way[junction=roundabout]:righthandtraffic:clockwise,
308way[junction=roundabout]!:righthandtraffic:anticlockwise {
309  throwWarning: tr("suspicious roundabout direction");
310}
311
312/* #12496 */
313area:closed[place=islet][eval(areasize()) > 1500000] {
314  throwWarning: tr("{0} on a large area", "{1.tag}");
315  suggestAlternative: "place=island";
316  fixAdd: "place=island";
317}
318
319area:closed[place=island][eval(areasize()) < 500000] {
320  throwWarning: tr("{0} on a small area", "{1.tag}");
321  suggestAlternative: "place=islet";
322  fixAdd: "place=islet";
323}
324
325/* #15648 */
326way[place=island]!:closed {
327  throwError: tr("Way with {0} not closed.", "{0.tag}");
328}
329
330/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
331area:closed[building][building!=no][eval(areasize()) > 520000] {
332  throwError: tr("Too large building");
333}
334
335/* #12577 */
336way[power=line] > node,
337way[power=minor_line] > node,
338way[power=cable] > node {
339  set node_in_power_way;
340}
341way[!power][!building] > node.node_in_power_way {
342  throwWarning: tr("Node connects a power line or cable with an object which is not related to the power infrastructure.");
343}
344
345/* #12646, #12992, #16334 */
346way[waterway=~/^(stream|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area { 
347  throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
348}
349
350/* #10717, #14535 */
351way:closed[natural=coastline]  area[natural=water],
352way:closed[natural=coastline]  area[waterway=riverbank] {
353  throwError: tr("Coastline inside {1}", "{0.tag}");
354}
355
356/* #10471 */
357way[waterway] > node[ford?] { set ford_on_waterway; }
358way[highway] > node[ford?] { set ford_on_highway; }
359node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
360    throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
361}
362
363/* #13877 */
364area:closed[waterway = canal][area!=no],
365area:closed[waterway = drain][area!=no],
366area:closed[waterway = ditch][area!=no],
367area:closed[waterway = stream][area!=no],
368area:closed[waterway = river][area!=no] {
369  throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
370}
371
372/* #15097 */
373way[highway][area!=yes] > node,
374way[man_made=pier] > node {
375  set node_in_highway_pier;
376}
377way[route=ferry][tunnel=yes] > node,
378way[route=ferry][bridge=yes] > node {
379  set node_in_ferry_bridge_tunnel;
380}
381way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
382way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
383  throwWarning: tr("Ferry route is not connected to the road network or branches.");
384}
385way[amenity=ferry_terminal] > node,
386way[man_made=pier] > node {
387  set node_in_terminal_pier;
388}
389way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
390way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
391  throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
392}
393
394/* #10391 - Many misuses of building=hangar instead of building=barn/industrial/warehouse */
395area:closed2[aeroway]  way[building=hangar][!aeroway] {
396  throwWarning: tr("{0} outside of {1}", "{0.tag}", "aeroway");
397  suggestAlternative: "building=barn";
398  suggestAlternative: "building=industrial";
399  suggestAlternative: "building=warehouse";
400}
401
402/* #17533 - Check waterway flow direction */
403*[waterway][waterway!=drain] > node:connection {
404  set notDrain;
405}
406way[waterway=drain] >[index!=1] node:connection {
407  set notDrainFirstNode;
408}
409way[waterway=drain] >[index!=-1] node:connection {
410  set notDrainLastNode;
411}
412way[waterway=drain] > node:connection!.notDrainFirstNode!.notDrain,
413way[waterway=drain] > node:connection!.notDrainLastNode!.notDrain {
414  throwWarning: tr("incorrect drain flow direction");
415}
Note: See TracBrowser for help on using the repository browser.