source: josm/trunk/data/validator/geometry.mapcss@ 15016

Last change on this file since 15016 was 15016, checked in by Klumbumbus, 5 years ago

fix #17025 - warn about "node connects highway and building" too if

  • the suspect node is the first and/or last node of the building
  • the suspect node is the first and last node of a closed highway

(patch by GerdP an Klumbumbus)

  • Property svn:eol-style set to native
File size: 14.1 KB
Line 
1/* {0} on a node, should be a way */
2node[area=no],
3node[oneway],
4node[bridge],
5node[sidewalk],
6node[footway],
7node[man_made=embankment],
8node[man_made=groyne],
9node[man_made=cutline],
10node[power=line],
11node[cutline],
12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
38node[waterway=drain],
39node[natural=coastline],
40node[natural=ridge],
41node[natural=valley],
42node[natural=tree_row] {
43 throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
44 assertMatch: "node oneway=-1";
45 assertNoMatch: "way oneway=-1";
46 assertMatch: "node bridge=yes";
47 assertMatch: "node bridge=viaduct";
48}
49
50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52 throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
55/* {0} on a node, should be an area; #10679 #16528 #16792 #12502 #17402*/
56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
59node[area=yes],
60node[area:highway],
61node[landuse],
62node[natural=scree],
63node[natural=scrub],
64node[natural=fell],
65node[natural=heath],
66node[natural=wood],
67node[natural=grassland],
68node[natural=wetland],
69node[natural=water],
70node[natural=mud],
71node[natural=beach],
72node[natural=sand],
73node[natural=wood],
74node[natural=bare_rock],
75node[natural=glacier],
76node[leisure=park][natural!=tree], /* For nodes with both tags another warning is created in combinations.mapcss */
77node[leisure=nature_reserve],
78node[waterway=riverbank],
79node[man_made=bridge],
80node[man_made=breakwater],
81node[aeroway=apron],
82node[power=plant],
83node[power=switchgear],
84node[building:part],
85node[source:outline] {
86 throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
87}
88
89/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
90node[type=multipolygon],
91node[interval],
92node[route],
93node[restriction] {
94 throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}");
95}
96
97/* {0} on a way, should be a node */
98way[emergency=fire_hydrant],
99way[entrance],
100way[door],
101way[railway=subway_entrance],
102way[man_made=survey_point],
103way[aeroway=holding_position],
104way[power=transformer],
105way[power=pole],
106way[power=catenary_mast],
107way[power=terminal],
108way[power=tower]!:closed,
109way[amenity=vending_machine],
110way[natural=peak],
111way[natural=saddle],
112way[natural=volcano],
113way[natural=tree],
114way[highway=give_way],
115way[highway=milestone],
116way[highway=mini_roundabout],
117way[highway=stop],
118way[highway=street_lamp],
119way[highway=traffic_signals],
120way[highway=turning_loop],
121way[highway=turning_circle],
122way[highway=motorway_junction] {
123 throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}");
124}
125
126/* {0} on a way, should be a relation; see #15642, #10252, #14288 */
127way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
128way[type=multipolygon],
129way[interval][route!=ferry],
130way[route=bus] {
131 throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}");
132}
133
134/* #14395, #17025 */
135way[highway][area!=yes][!tunnel][!covered] > node {
136 set node_in_highway;
137}
138way[highway][area!=yes][!tunnel][!covered]:closed > node {
139 set node_in_closed_highway;
140}
141way[highway][area!=yes][!tunnel][!covered] >[index=1] node,
142way[highway][area!=yes][!tunnel][!covered] >[index=-1] node {
143 set first_last_highway_node;
144}
145way[building][building!=no] > node.node_in_closed_highway,
146way[building][building!=no] > node.node_in_highway!.first_last_highway_node {
147 throwWarning: tr("node connects highway and building");
148}
149
150/* #15035, must not warn for node 3815077900*/
151node[man_made!=monitoring_station][at(0.0,0.0)] {
152 throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
153 fixDeleteObject: this;
154}
155
156/* see ticket:#10125 */
157node[source:geometry] {
158 throwWarning: tr("{0} on a node", "{0.key}");
159 fixChangeKey: "source:geometry => source:position";
160}
161
162/* Building inside building (spatial test) */
163*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")]
164*[building][building!~/no|entrance/] {
165 throwWarning: tr("Building inside building");
166}
167
168/* Overlapping areas (spatial test) */
169area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
170 set water_area;
171}
172
173/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
174area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/] area:closed:areaStyle.water_area,
175area:closed:areaStyle[landuse=reservoir] area:closed:areaStyle.water_area {
176 throwWarning: tr("Overlapping Water Areas");
177}
178
179area:closed:areaStyle area:closed:areaStyle {
180 throwOther: tr("Overlapping Areas");
181}
182
183/* see ticket #9311 */
184node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/] *[amenity=parking] {
185 throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
186 group: tr("{0} inside {1}", "amenity", "amenity");
187}
188
189/* see ticket #9556 */
190area:closed:areaStyle[tag("natural") = parent_tag("natural")] area:closed:areaStyle[natural] {
191 throwWarning: tr("Overlapping Identical Natural Areas");
192}
193
194area:closed:areaStyle[landuse!=residential][tag("landuse") = parent_tag("landuse")] area:closed:areaStyle[landuse][landuse!=residential] {
195 throwWarning: tr("Overlapping Identical Landuses");
196}
197
198/* see ticket:#9522 */
199node[tag("amenity") = parent_tag("amenity")] *[amenity][amenity != parking] {
200 throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
201 group: tr("{0} inside {1}", "amenity", "amenity");
202}
203node[tag("leisure") = parent_tag("leisure")] *[leisure] {
204 throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
205 group: tr("{0} inside {1}", "leisure", "leisure");
206}
207node[tag("tourism") = parent_tag("tourism")] *[tourism] {
208 throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
209 group: tr("{0} inside {1}", "tourism", "tourism");
210}
211node[tag("shop") = parent_tag("shop")] *[shop] {
212 throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
213 group: tr("{0} inside {1}", "shop", "shop");
214}
215node[tag("power") = parent_tag("power")] *[power] {
216 throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
217 group: tr("{0} inside {1}", "power", "power");
218}
219
220/* isolated nodes which should be part of a way, see #10825, #15478 */
221node:unconnected:in-downloaded-area[entrance],
222node:unconnected:in-downloaded-area[traffic_calming],
223node:unconnected:in-downloaded-area[highway=passing_place],
224node:unconnected:in-downloaded-area[highway=mini_roundabout],
225node:unconnected:in-downloaded-area[highway=motorway_junction],
226node:unconnected:in-downloaded-area[highway=turning_loop],
227node:unconnected:in-downloaded-area[highway=turning_circle],
228node:unconnected:in-downloaded-area[highway=stop],
229node:unconnected:in-downloaded-area[highway=give_way],
230node:unconnected:in-downloaded-area[highway=traffic_signals],
231node:unconnected:in-downloaded-area[highway=crossing],
232node:unconnected:in-downloaded-area[crossing],
233node:unconnected:in-downloaded-area[highway=milestone],
234node:unconnected:in-downloaded-area[railway=milestone],
235node:unconnected:in-downloaded-area[railway=crossing],
236node:unconnected:in-downloaded-area[railway=level_crossing],
237node:unconnected:in-downloaded-area[railway=buffer_stop],
238node:unconnected:in-downloaded-area[public_transport=stop_position],
239node:unconnected:in-downloaded-area[aeroway=holding_position],
240node:unconnected:in-downloaded-area[noexit],
241node:unconnected:in-downloaded-area[waterway=dam],
242node:unconnected:in-downloaded-area[waterway=weir],
243node:unconnected:in-downloaded-area[waterway=waterfall],
244node:unconnected:in-downloaded-area[amenity=ferry_terminal],
245node:unconnected:in-downloaded-area[leisure=slipway],
246node:unconnected:in-downloaded-area[mountain_pass=yes],
247node:unconnected:in-downloaded-area[barrier=gate],
248node:unconnected:in-downloaded-area[barrier=lift_gate],
249node:unconnected:in-downloaded-area[barrier=swing_gate],
250node:unconnected:in-downloaded-area[barrier=toll_booth],
251node:unconnected:in-downloaded-area[barrier=turnstile],
252node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
253node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
254node:unconnected:in-downloaded-area[barrier=rope],
255node:unconnected:in-downloaded-area[barrier=sally_port],
256node:unconnected:in-downloaded-area[barrier=spikes],
257node:unconnected:in-downloaded-area[barrier=stile],
258node:unconnected:in-downloaded-area[barrier=sump_buster],
259node:unconnected:in-downloaded-area[barrier=kerb],
260node:unconnected:in-downloaded-area[barrier=border_control],
261node:unconnected:in-downloaded-area[barrier=bump_gate],
262node:unconnected:in-downloaded-area[barrier=bus_trap],
263node:unconnected:in-downloaded-area[barrier=cattle_grid],
264node:unconnected:in-downloaded-area[barrier=chain],
265node:unconnected:in-downloaded-area[barrier=cycle_barrier],
266node:unconnected:in-downloaded-area[barrier=hampshire_gate],
267node:unconnected:in-downloaded-area[barrier=height_restrictor],
268node:unconnected:in-downloaded-area[barrier=debris] {
269 throwWarning: tr("{0}", "{2.tag}");
270 group: tr("isolated node which must be connected to a way");
271}
272
273/* #11127 */
274way[railway][bridge] > node,
275way[highway][bridge] > node {
276 set node_in_bridge;
277}
278way[waterway] > node.node_in_bridge {
279 throwWarning: tr("node connects waterway and bridge");
280}
281
282/* #11128, #14812, #15032 */
283way[highway] > node[tourism=information][information=guidepost] {
284 set guidepost;
285 throwOther: tr("{0} node connected to a highway", "{1.tag}");
286}
287way >[index=1] node,
288way >[index=-1] node {
289 set first_last_node;
290}
291way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge|taxi|toilets)$/],
292way[highway] > node[building][!entrance],
293way[highway] > node[leisure][!entrance][leisure!=slipway],
294way[highway] > node[office][!entrance],
295way[highway] > node[shop][!entrance],
296way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
297way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
298 throwWarning: tr("{0} node connected to a highway", "{0.key}");
299}
300
301way[junction=roundabout]:righthandtraffic:clockwise,
302way[junction=roundabout]!:righthandtraffic:anticlockwise {
303 throwWarning: tr("suspicious roundabout direction");
304}
305
306/* #12496 */
307area:closed[place=islet][eval(areasize()) > 1500000] {
308 throwWarning: tr("{0} on a large area", "{1.tag}");
309 suggestAlternative: "place=island";
310 fixAdd: "place=island";
311}
312
313area:closed[place=island][eval(areasize()) < 500000] {
314 throwWarning: tr("{0} on a small area", "{1.tag}");
315 suggestAlternative: "place=islet";
316 fixAdd: "place=islet";
317}
318
319/* #15648 */
320way[place=island]!:closed {
321 throwError: tr("Way with {0} not closed.", "{0.tag}");
322}
323
324/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
325area:closed[building][building!=no][eval(areasize()) > 520000] {
326 throwError: tr("Too large building");
327}
328
329/* #12577 */
330way[power=line] > node,
331way[power=minor_line] > node,
332way[power=cable] > node {
333 set node_in_power_way;
334}
335way[!power][!building] > node.node_in_power_way {
336 throwWarning: tr("Node connects a power line or cable with an object which is not related to the power infrastructure.");
337}
338
339/* #12646, #12992 */
340way[waterway=~/^(stream|ditch|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area {
341 throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
342}
343
344/* #10717, #14535 */
345way:closed[natural=coastline] area[natural=water],
346way:closed[natural=coastline] area[waterway=riverbank] {
347 throwError: tr("Coastline inside {1}", "{0.tag}");
348}
349
350/* #10471 */
351way[waterway] > node[ford?] { set ford_on_waterway; }
352way[highway] > node[ford?] { set ford_on_highway; }
353node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
354 throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
355}
356
357/* #13877 */
358area:closed[waterway = canal][area!=no],
359area:closed[waterway = drain][area!=no],
360area:closed[waterway = ditch][area!=no],
361area:closed[waterway = stream][area!=no],
362area:closed[waterway = river][area!=no] {
363 throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
364}
365
366/* #15097 */
367way[highway][area!=yes] > node,
368way[man_made=pier] > node {
369 set node_in_highway_pier;
370}
371way[route=ferry][tunnel=yes] > node,
372way[route=ferry][bridge=yes] > node {
373 set node_in_ferry_bridge_tunnel;
374}
375way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
376way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
377 throwWarning: tr("Ferry route is not connected to the road network or branches.");
378}
379way[amenity=ferry_terminal] > node,
380way[man_made=pier] > node {
381 set node_in_terminal_pier;
382}
383way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
384way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
385 throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
386}
Note: See TracBrowser for help on using the repository browser.