source: josm/trunk/data/validator/geometry.mapcss @ 14577

Last change on this file since 14577 was 14577, checked in by Klumbumbus, 10 months ago

fix #17130 - warn about area:highway on unclosed ways and nodes

  • Property svn:eol-style set to native
File size: 13.9 KB
Line 
1/* {0} on a node, should be a way */
2node[area=no],
3node[oneway],
4node[bridge],
5node[sidewalk],
6node[footway],
7node[man_made=embankment],
8node[man_made=groyne],
9node[man_made=cutline],
10node[power=line],
11node[cutline],
12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
38node[waterway=drain],
39node[natural=coastline],
40node[natural=ridge],
41node[natural=valley],
42node[natural=tree_row] {
43  throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
44  assertMatch: "node oneway=-1";
45  assertNoMatch: "way oneway=-1";
46  assertMatch: "node bridge=yes";
47  assertMatch: "node bridge=viaduct";
48}
49
50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52  throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
55/* {0} on a node, should be an area; #10679 #16528 #16792 */
56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
59node[area=yes],
60node[area:highway],
61node[landuse],
62node[natural=scree],
63node[natural=scrub],
64node[natural=fell],
65node[natural=heath],
66node[natural=wood],
67node[natural=grassland],
68node[natural=wetland],
69node[natural=water],
70node[natural=mud],
71node[natural=beach],
72node[natural=sand],
73node[natural=wood],
74node[natural=bare_rock],
75node[natural=glacier],
76node[waterway=riverbank],
77node[man_made=bridge],
78node[man_made=breakwater],
79node[aeroway=apron],
80node[power=plant],
81node[power=switchgear],
82node[building:part],
83node[source:outline] {
84  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
85}
86
87/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
88node[type=multipolygon],
89node[route],
90node[restriction] {
91  throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}"); 
92}
93
94/* {0} on a way, should be a node */
95way[entrance],
96way[door],
97way[railway=subway_entrance],
98way[man_made=survey_point],
99way[aeroway=holding_position],
100way[power=transformer],
101way[power=pole],
102way[power=catenary_mast],
103way[power=terminal],
104way[power=tower]!:closed,
105way[amenity=vending_machine],
106way[natural=peak],
107way[natural=saddle],
108way[natural=volcano],
109way[natural=tree],
110way[highway=give_way],
111way[highway=milestone],
112way[highway=mini_roundabout],
113way[highway=stop],
114way[highway=street_lamp],
115way[highway=traffic_signals],
116way[highway=turning_loop],
117way[highway=turning_circle],
118way[highway=motorway_junction] {
119  throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}"); 
120}
121
122/* {0} on a way, should be a relation; see #15642, #10252, #14288 */
123way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
124way[type=multipolygon],
125way[route=bus] {
126  throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}"); 
127}
128
129/* #14395 */
130way >[index=1] node,
131way >[index=-1] node {
132  set first_last_node;
133}
134way[highway][area!=yes][!tunnel][!covered] > node {
135  set node_in_highway;
136}
137way[building][building!=no] > node.node_in_highway!.first_last_node {
138  throwWarning: tr("node connects highway and building");
139}
140
141/* #15035, must not warn for node 3815077900*/
142node[man_made!=monitoring_station][at(0.0,0.0)] {
143  throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
144  fixDeleteObject: this;
145}
146
147/* #12502 */
148node[leisure=park][natural=tree] {
149  throwWarning: tr("{0} together with {1} on a node. Remove {0}.", "{0.tag}", "{1.tag}");
150  group: tr("suspicious tag combination");
151  fixRemove: "leisure";
152}
153node[leisure=park][natural!=tree] {
154  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
155}
156
157/* see ticket:#10125 */
158node[source:geometry] {
159  throwWarning: tr("{0} on a node", "{0.key}");
160  fixChangeKey: "source:geometry => source:position";
161}
162
163/* Building inside building (spatial test) */
164*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")] 
165*[building][building!~/no|entrance/] {
166  throwWarning: tr("Building inside building");
167}
168
169/* Overlapping areas (spatial test) */
170area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
171  set water_area;
172}
173
174/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
175area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/]  area:closed:areaStyle.water_area,
176area:closed:areaStyle[landuse=reservoir]                         area:closed:areaStyle.water_area {
177  throwWarning: tr("Overlapping Water Areas");
178}
179
180area:closed:areaStyle  area:closed:areaStyle {
181  throwOther: tr("Overlapping Areas");
182}
183
184/* see ticket #9311 */
185node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/]  *[amenity=parking] {
186  throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
187  group: tr("{0} inside {1}", "amenity", "amenity");
188}
189
190/* see ticket #9556 */
191area:closed:areaStyle[tag("natural") = parent_tag("natural")]  area:closed:areaStyle[natural] {
192  throwWarning: tr("Overlapping Identical Natural Areas");
193}
194
195area:closed:areaStyle[landuse!=residential][tag("landuse") = parent_tag("landuse")]  area:closed:areaStyle[landuse][landuse!=residential] {
196  throwWarning: tr("Overlapping Identical Landuses");
197}
198
199/* see ticket:#9522 */
200node[tag("amenity") = parent_tag("amenity")]  *[amenity][amenity != parking] {
201  throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
202  group: tr("{0} inside {1}", "amenity", "amenity");
203}
204node[tag("leisure") = parent_tag("leisure")]  *[leisure] {
205  throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
206  group: tr("{0} inside {1}", "leisure", "leisure");
207}
208node[tag("tourism") = parent_tag("tourism")]  *[tourism] {
209  throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
210  group: tr("{0} inside {1}", "tourism", "tourism");
211}
212node[tag("shop") = parent_tag("shop")]  *[shop] {
213  throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
214  group: tr("{0} inside {1}", "shop", "shop");
215}
216node[tag("power") = parent_tag("power")]  *[power] {
217  throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
218  group: tr("{0} inside {1}", "power", "power");
219}
220
221/* isolated nodes which should be part of a way, see #10825, #15478 */
222node:unconnected:in-downloaded-area[entrance],
223node:unconnected:in-downloaded-area[traffic_calming],
224node:unconnected:in-downloaded-area[highway=passing_place],
225node:unconnected:in-downloaded-area[highway=mini_roundabout],
226node:unconnected:in-downloaded-area[highway=motorway_junction],
227node:unconnected:in-downloaded-area[highway=turning_loop],
228node:unconnected:in-downloaded-area[highway=turning_circle],
229node:unconnected:in-downloaded-area[highway=stop],
230node:unconnected:in-downloaded-area[highway=give_way],
231node:unconnected:in-downloaded-area[highway=traffic_signals],
232node:unconnected:in-downloaded-area[highway=crossing],
233node:unconnected:in-downloaded-area[crossing],
234node:unconnected:in-downloaded-area[highway=milestone],
235node:unconnected:in-downloaded-area[railway=milestone],
236node:unconnected:in-downloaded-area[railway=crossing],
237node:unconnected:in-downloaded-area[railway=level_crossing],
238node:unconnected:in-downloaded-area[railway=buffer_stop],
239node:unconnected:in-downloaded-area[public_transport=stop_position],
240node:unconnected:in-downloaded-area[aeroway=holding_position],
241node:unconnected:in-downloaded-area[noexit],
242node:unconnected:in-downloaded-area[waterway=dam],
243node:unconnected:in-downloaded-area[waterway=weir],
244node:unconnected:in-downloaded-area[waterway=waterfall],
245node:unconnected:in-downloaded-area[amenity=ferry_terminal],
246node:unconnected:in-downloaded-area[leisure=slipway],
247node:unconnected:in-downloaded-area[mountain_pass=yes],
248node:unconnected:in-downloaded-area[barrier=gate],
249node:unconnected:in-downloaded-area[barrier=lift_gate],
250node:unconnected:in-downloaded-area[barrier=swing_gate],
251node:unconnected:in-downloaded-area[barrier=toll_booth],
252node:unconnected:in-downloaded-area[barrier=turnstile],
253node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
254node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
255node:unconnected:in-downloaded-area[barrier=rope],
256node:unconnected:in-downloaded-area[barrier=sally_port],
257node:unconnected:in-downloaded-area[barrier=spikes],
258node:unconnected:in-downloaded-area[barrier=stile],
259node:unconnected:in-downloaded-area[barrier=sump_buster],
260node:unconnected:in-downloaded-area[barrier=kerb],
261node:unconnected:in-downloaded-area[barrier=border_control],
262node:unconnected:in-downloaded-area[barrier=bump_gate],
263node:unconnected:in-downloaded-area[barrier=bus_trap],
264node:unconnected:in-downloaded-area[barrier=cattle_grid],
265node:unconnected:in-downloaded-area[barrier=chain],
266node:unconnected:in-downloaded-area[barrier=cycle_barrier],
267node:unconnected:in-downloaded-area[barrier=hampshire_gate],
268node:unconnected:in-downloaded-area[barrier=height_restrictor],
269node:unconnected:in-downloaded-area[barrier=debris] {
270  throwWarning: tr("{0}", "{2.tag}");
271  group: tr("isolated node which must be connected to a way");
272}
273
274/* #11127 */
275way[railway][bridge] > node,
276way[highway][bridge] > node {
277  set node_in_bridge;
278}
279way[waterway] > node.node_in_bridge {
280  throwWarning: tr("node connects waterway and bridge");
281}
282
283/* #11128, #14812, #15032 */
284way[highway] > node[tourism=information][information=guidepost] {
285  set guidepost;
286  throwOther: tr("{0} node connected to a highway", "{1.tag}");
287}
288way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge|taxi)$/],
289way[highway] > node[building][!entrance],
290way[highway] > node[leisure][!entrance][leisure!=slipway],
291way[highway] > node[office][!entrance],
292way[highway] > node[shop][!entrance],
293way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
294way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
295  throwWarning: tr("{0} node connected to a highway", "{0.key}");
296}
297
298way[junction=roundabout]:righthandtraffic:clockwise,
299way[junction=roundabout]!:righthandtraffic:anticlockwise {
300  throwWarning: tr("suspicious roundabout direction");
301}
302
303/* #12496 */
304area:closed[place=islet][eval(areasize()) > 1500000] {
305  throwWarning: tr("{0} on a large area", "{1.tag}");
306  suggestAlternative: "place=island";
307  fixAdd: "place=island";
308}
309
310area:closed[place=island][eval(areasize()) < 500000] {
311  throwWarning: tr("{0} on a small area", "{1.tag}");
312  suggestAlternative: "place=islet";
313  fixAdd: "place=islet";
314}
315
316/* #15648 */
317way[place=island]!:closed {
318  throwError: tr("Way with {0} not closed.", "{0.tag}");
319}
320
321/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
322area:closed[building][building!=no][eval(areasize()) > 520000] {
323  throwError: tr("Too large building");
324}
325
326/* #12577 */
327way[power=line] > node,
328way[power=minor_line] > node,
329way[power=cable] > node {
330  set node_in_power_way;
331}
332way[!power][!building] > node.node_in_power_way {
333  throwWarning: tr("Node connects a power line or cable with an object which is not related to the power infrastructure.");
334}
335
336/* #12646, #12992 */
337way[waterway=~/^(stream|ditch|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area { 
338  throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
339}
340
341/* #10717, #14535 */
342way:closed[natural=coastline]  area[natural=water],
343way:closed[natural=coastline]  area[waterway=riverbank] {
344  throwError: tr("Coastline inside {1}", "{0.tag}");
345}
346
347/* #10471 */
348way[waterway] > node[ford?] { set ford_on_waterway; }
349way[highway] > node[ford?] { set ford_on_highway; }
350node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
351    throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
352}
353
354/* #13877 */
355area:closed[waterway = canal][area!=no],
356area:closed[waterway = drain][area!=no],
357area:closed[waterway = ditch][area!=no],
358area:closed[waterway = stream][area!=no],
359area:closed[waterway = river][area!=no] {
360  throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
361}
362
363/* #15097 */
364way[highway][area!=yes] > node,
365way[man_made=pier] > node {
366  set node_in_highway_pier;
367}
368way[route=ferry][tunnel=yes] > node,
369way[route=ferry][bridge=yes] > node {
370  set node_in_ferry_bridge_tunnel;
371}
372way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
373way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
374  throwWarning: tr("Ferry route is not connected to the road network or branches.");
375}
376way[amenity=ferry_terminal] > node,
377way[man_made=pier] > node {
378  set node_in_terminal_pier;
379}
380way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
381way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
382  throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
383}
Note: See TracBrowser for help on using the repository browser.