source: josm/trunk/data/validator/geometry.mapcss @ 14059

Last change on this file since 14059 was 14059, checked in by Klumbumbus, 11 months ago

fix #16528 - warn about golf=green|bunker|fairway on nodes

  • Property svn:eol-style set to native
File size: 13.8 KB
Line 
1/* {0} on a node, should be a way */
2node[area=no],
3node[oneway],
4node[bridge],
5node[sidewalk],
6node[footway],
7node[man_made=embankment],
8node[man_made=groyne],
9node[man_made=cutline],
10node[power=line],
11node[cutline],
12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
38node[waterway=drain],
39node[natural=coastline],
40node[natural=ridge],
41node[natural=valley],
42node[natural=tree_row] {
43  throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
44  assertMatch: "node oneway=-1";
45  assertNoMatch: "way oneway=-1";
46  assertMatch: "node bridge=yes";
47  assertMatch: "node bridge=viaduct";
48}
49
50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52  throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
55/* {0} on a node, should be an area; #10679 #16528 */
56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
59node[area=yes],
60node[landuse],
61node[natural=scree],
62node[natural=scrub],
63node[natural=fell],
64node[natural=heath],
65node[natural=wood],
66node[natural=grassland],
67node[natural=wetland],
68node[natural=water],
69node[natural=mud],
70node[natural=beach],
71node[natural=sand],
72node[natural=wood],
73node[natural=bare_rock],
74node[natural=glacier],
75node[waterway=riverbank],
76node[man_made=bridge],
77node[man_made=breakwater],
78node[aeroway=apron],
79node[power=plant],
80node[building:part],
81node[source:outline] {
82  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
83}
84
85/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
86node[type=multipolygon],
87node[route],
88node[restriction] {
89  throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}"); 
90}
91
92/* {0} on a way, should be a node */
93way[entrance],
94way[railway=subway_entrance],
95way[man_made=survey_point],
96way[aeroway=holding_position],
97way[power=transformer],
98way[power=pole],
99way[power=tower]!:closed,
100way[amenity=vending_machine],
101way[natural=peak],
102way[natural=saddle],
103way[natural=volcano],
104way[natural=tree],
105way[highway=give_way],
106way[highway=milestone],
107way[highway=mini_roundabout],
108way[highway=stop],
109way[highway=street_lamp],
110way[highway=traffic_signals],
111way[highway=turning_loop],
112way[highway=turning_circle],
113way[highway=motorway_junction] {
114  throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}"); 
115}
116
117/* {0} on a way, should be a relation; see #15642, #10252, #14288 */
118way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
119way[type=multipolygon],
120way[route=bus] {
121  throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}"); 
122}
123
124/* #14395 */
125way >[index=1] node,
126way >[index=-1] node {
127  set first_last_node;
128}
129way[highway][area!=yes][!tunnel][!covered] > node {
130  set node_in_highway;
131}
132way[building][building!=no] > node.node_in_highway!.first_last_node {
133  throwWarning: tr("node connects highway and building");
134}
135
136/* #15035, must not warn for node 3815077900*/
137node[man_made!=monitoring_station][at(0.0,0.0)] {
138  throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
139  fixDeleteObject: this;
140}
141
142/* #12502 */
143node[leisure=park][natural=tree] {
144  throwWarning: tr("{0} together with {1} on a node. Remove {0}.", "{0.tag}", "{1.tag}");
145  group: tr("suspicious tag combination");
146  fixRemove: "leisure";
147}
148node[leisure=park][natural!=tree] {
149  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
150}
151
152/* see ticket:#10125 */
153node[source:geometry] {
154  throwWarning: tr("{0} on a node", "{0.key}");
155  fixChangeKey: "source:geometry => source:position";
156}
157
158/* Building inside building (spatial test) */
159*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")] 
160*[building][building!~/no|entrance/] {
161  throwWarning: tr("Building inside building");
162}
163
164/* Overlapping areas (spatial test) */
165area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
166  set water_area;
167}
168
169/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
170area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/]  area:closed:areaStyle.water_area,
171area:closed:areaStyle[landuse=reservoir]                         area:closed:areaStyle.water_area {
172  throwWarning: tr("Overlapping Water Areas");
173}
174
175area:closed:areaStyle  area:closed:areaStyle {
176  throwOther: tr("Overlapping Areas");
177}
178
179/* see ticket #9311 */
180node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/]  *[amenity=parking] {
181  throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
182  group: tr("{0} inside {1}", "amenity", "amenity");
183}
184
185/* see ticket #9556 */
186area:closed:areaStyle[tag("natural") = parent_tag("natural")]  area:closed:areaStyle[natural] {
187  throwWarning: tr("Overlapping Identical Natural Areas");
188}
189
190area:closed:areaStyle[landuse!=residential][tag("landuse") = parent_tag("landuse")]  area:closed:areaStyle[landuse][landuse!=residential] {
191  throwWarning: tr("Overlapping Identical Landuses");
192}
193
194/* see ticket:#9522 */
195node[tag("amenity") = parent_tag("amenity")]  *[amenity][amenity != parking] {
196  throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
197  group: tr("{0} inside {1}", "amenity", "amenity");
198}
199node[tag("leisure") = parent_tag("leisure")]  *[leisure] {
200  throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
201  group: tr("{0} inside {1}", "leisure", "leisure");
202}
203node[tag("tourism") = parent_tag("tourism")]  *[tourism] {
204  throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
205  group: tr("{0} inside {1}", "tourism", "tourism");
206}
207node[tag("shop") = parent_tag("shop")]  *[shop] {
208  throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
209  group: tr("{0} inside {1}", "shop", "shop");
210}
211node[tag("power") = parent_tag("power")]  *[power] {
212  throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
213  group: tr("{0} inside {1}", "power", "power");
214}
215
216/* isolated nodes which should be part of a way, see #10825, #15478 */
217node:unconnected:in-downloaded-area[entrance],
218node:unconnected:in-downloaded-area[traffic_calming],
219node:unconnected:in-downloaded-area[highway=passing_place],
220node:unconnected:in-downloaded-area[highway=mini_roundabout],
221node:unconnected:in-downloaded-area[highway=motorway_junction],
222node:unconnected:in-downloaded-area[highway=turning_loop],
223node:unconnected:in-downloaded-area[highway=turning_circle],
224node:unconnected:in-downloaded-area[highway=stop],
225node:unconnected:in-downloaded-area[highway=give_way],
226node:unconnected:in-downloaded-area[highway=traffic_signals],
227node:unconnected:in-downloaded-area[highway=crossing],
228node:unconnected:in-downloaded-area[crossing],
229node:unconnected:in-downloaded-area[highway=milestone],
230node:unconnected:in-downloaded-area[railway=milestone],
231node:unconnected:in-downloaded-area[railway=crossing],
232node:unconnected:in-downloaded-area[railway=level_crossing],
233node:unconnected:in-downloaded-area[railway=buffer_stop],
234node:unconnected:in-downloaded-area[public_transport=stop_position],
235node:unconnected:in-downloaded-area[aeroway=holding_position],
236node:unconnected:in-downloaded-area[noexit],
237node:unconnected:in-downloaded-area[waterway=dam],
238node:unconnected:in-downloaded-area[waterway=weir],
239node:unconnected:in-downloaded-area[waterway=waterfall],
240node:unconnected:in-downloaded-area[amenity=ferry_terminal],
241node:unconnected:in-downloaded-area[leisure=slipway],
242node:unconnected:in-downloaded-area[mountain_pass=yes],
243node:unconnected:in-downloaded-area[barrier=gate],
244node:unconnected:in-downloaded-area[barrier=lift_gate],
245node:unconnected:in-downloaded-area[barrier=swing_gate],
246node:unconnected:in-downloaded-area[barrier=toll_booth],
247node:unconnected:in-downloaded-area[barrier=turnstile],
248node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
249node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
250node:unconnected:in-downloaded-area[barrier=rope],
251node:unconnected:in-downloaded-area[barrier=sally_port],
252node:unconnected:in-downloaded-area[barrier=spikes],
253node:unconnected:in-downloaded-area[barrier=stile],
254node:unconnected:in-downloaded-area[barrier=sump_buster],
255node:unconnected:in-downloaded-area[barrier=kerb],
256node:unconnected:in-downloaded-area[barrier=border_control],
257node:unconnected:in-downloaded-area[barrier=bump_gate],
258node:unconnected:in-downloaded-area[barrier=bus_trap],
259node:unconnected:in-downloaded-area[barrier=cattle_grid],
260node:unconnected:in-downloaded-area[barrier=chain],
261node:unconnected:in-downloaded-area[barrier=cycle_barrier],
262node:unconnected:in-downloaded-area[barrier=hampshire_gate],
263node:unconnected:in-downloaded-area[barrier=height_restrictor],
264node:unconnected:in-downloaded-area[barrier=debris] {
265  throwWarning: tr("{0}", "{2.tag}");
266  group: tr("isolated node which must be connected to a way");
267}
268
269/* #11127 */
270way[railway][bridge] > node,
271way[highway][bridge] > node {
272  set node_in_bridge;
273}
274way[waterway] > node.node_in_bridge {
275  throwWarning: tr("node connects waterway and bridge");
276}
277
278/* #11128, #14812, #15032 */
279way[highway] > node[tourism=information][information=guidepost] {
280  set guidepost;
281  throwOther: tr("{0} node connected to a highway", "{1.tag}");
282}
283way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge)$/],
284way[highway] > node[building][!entrance],
285way[highway] > node[leisure][!entrance][leisure!=slipway],
286way[highway] > node[office][!entrance],
287way[highway] > node[shop][!entrance],
288way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
289way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
290  throwWarning: tr("{0} node connected to a highway", "{0.key}");
291}
292
293way[junction=roundabout]:righthandtraffic:clockwise,
294way[junction=roundabout]!:righthandtraffic:anticlockwise {
295  throwWarning: tr("suspicious roundabout direction");
296}
297
298/* #12496 */
299area:closed[place=islet][eval(areasize()) > 1500000] {
300  throwWarning: tr("{0} on a large area", "{1.tag}");
301  suggestAlternative: "place=island";
302  fixAdd: "place=island";
303}
304
305area:closed[place=island][eval(areasize()) < 500000] {
306  throwWarning: tr("{0} on a small area", "{1.tag}");
307  suggestAlternative: "place=islet";
308  fixAdd: "place=islet";
309}
310
311/* #15648 */
312way[place=island]!:closed {
313  throwError: tr("Way with {1} not closed.", "{0.tag}");
314}
315
316/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
317area:closed[building][building!=no][eval(areasize()) > 520000] {
318  throwError: tr("Too large building");
319}
320
321/* #12577 */
322way[power=line] > node,
323way[power=minor_line] > node,
324way[power=cable] > node {
325  set node_in_power_way;
326}
327way[!power][!building] > node.node_in_power_way {
328  throwWarning: tr("Node connects a power line or cable with an object which is not related to the power infrastructure.");
329}
330
331/* #12646, #12992 */
332way[waterway=~/^(stream|ditch|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area { 
333  throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
334}
335
336/* #10717, #14535 */
337way:closed[natural=coastline]  area[natural=water],
338way:closed[natural=coastline]  area[waterway=riverbank] {
339  throwError: tr("Coastline inside {1}", "{0.tag}");
340}
341
342/* #10471 */
343way[waterway] > node[ford?] { set ford_on_waterway; }
344way[highway] > node[ford?] { set ford_on_highway; }
345node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
346    throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
347}
348
349/* #13877 */
350area:closed[waterway = canal][area!=no],
351area:closed[waterway = drain][area!=no],
352area:closed[waterway = ditch][area!=no],
353area:closed[waterway = stream][area!=no],
354area:closed[waterway = river][area!=no] {
355  throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
356}
357
358/* #15097 */
359way[highway][area!=yes] > node,
360way[man_made=pier] > node {
361  set node_in_highway_pier;
362}
363way[route=ferry][tunnel=yes] > node,
364way[route=ferry][bridge=yes] > node {
365  set node_in_ferry_bridge_tunnel;
366}
367way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
368way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
369  throwWarning: tr("Ferry route is not connected to the road network or branches.");
370}
371way[amenity=ferry_terminal] > node,
372way[man_made=pier] > node {
373  set node_in_terminal_pier;
374}
375way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
376way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
377  throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
378}
Note: See TracBrowser for help on using the repository browser.