source: josm/trunk/data/validator/geometry.mapcss@ 13087

Last change on this file since 13087 was 13083, checked in by Klumbumbus, 6 years ago

fix #15503 - draw administrative boundaries only if boundary=administrative is tagged; add a warning for usage on nodes (used 330 times atm)

  • Property svn:eol-style set to native
File size: 13.4 KB
Line 
1/* {0} on a node, should be a way */
2node[area=no],
3node[oneway],
4node[bridge],
5node[sidewalk],
6node[footway],
7node[man_made=embankment],
8node[man_made=groyne],
9node[man_made=cutline],
10node[power=line],
11node[cutline],
12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
38node[waterway=drain],
39node[natural=coastline],
40node[natural=ridge],
41node[natural=valley],
42node[natural=tree_row] {
43 throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
44 assertMatch: "node oneway=-1";
45 assertNoMatch: "way oneway=-1";
46 assertMatch: "node bridge=yes";
47 assertMatch: "node bridge=viaduct";
48}
49
50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52 throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
55/* {0} on a node, should be an area; see ticket #10679 */
56node[area=yes],
57node[landuse],
58node[natural=scree],
59node[natural=scrub],
60node[natural=fell],
61node[natural=heath],
62node[natural=wood],
63node[natural=grassland],
64node[natural=wetland],
65node[natural=water],
66node[natural=mud],
67node[natural=beach],
68node[natural=sand],
69node[natural=wood],
70node[natural=bare_rock],
71node[natural=glacier],
72node[waterway=riverbank],
73node[man_made=bridge],
74node[man_made=breakwater],
75node[aeroway=apron],
76node[power=plant],
77node[building:part],
78node[source:outline] {
79 throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
80}
81
82/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
83node[type=multipolygon],
84node[route],
85node[restriction] {
86 throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}");
87}
88
89/* {0} on a way, should be a node */
90way[entrance],
91way[railway=subway_entrance],
92way[man_made=survey_point],
93way[aeroway=holding_position],
94way[power=transformer],
95way[power=pole],
96way[power=tower]!:closed,
97way[amenity=vending_machine],
98way[natural=peak],
99way[natural=saddle],
100way[natural=volcano],
101way[natural=tree],
102way[highway=give_way],
103way[highway=milestone],
104way[highway=mini_roundabout],
105way[highway=stop],
106way[highway=street_lamp],
107way[highway=traffic_signals],
108way[highway=turning_loop],
109way[highway=turning_circle],
110way[highway=motorway_junction] {
111 throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}");
112}
113
114/* {0} on a way, should be a relation; see #10252, #14288 */
115way[type=multipolygon],
116way[route=bus] {
117 throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}");
118}
119
120/* #14395 */
121way >[index=1] node,
122way >[index=-1] node {
123 set first_last_node;
124}
125way[highway][area!=yes][!tunnel][!covered] > node {
126 set node_in_highway;
127}
128way[building][building!=no] > node.node_in_highway!.first_last_node {
129 throwWarning: tr("node connects highway and building");
130}
131
132/* #15035, must not warn for node 3815077900*/
133node[man_made!=monitoring_station][at(0.0,0.0)] {
134 throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
135 fixDeleteObject: this;
136}
137
138/* #12502 */
139node[leisure=park][natural=tree] {
140 throwWarning: tr("{0} together with {1} on a node. Remove {0}.", "{0.tag}", "{1.tag}");
141 group: tr("suspicious tag combination");
142 fixRemove: "leisure";
143}
144node[leisure=park][natural!=tree] {
145 throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
146}
147
148/* see ticket:#10125 */
149node[source:geometry] {
150 throwWarning: tr("{0} on a node", "{0.key}");
151 fixChangeKey: "source:geometry => source:position";
152}
153
154/* Building inside building (spatial test) */
155*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")]
156*[building][building!~/no|entrance/] {
157 throwWarning: tr("Building inside building");
158}
159
160/* Overlapping areas (spatial test) */
161area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
162 set water_area;
163}
164
165/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
166area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/] area:closed:areaStyle.water_area,
167area:closed:areaStyle[landuse=reservoir] area:closed:areaStyle.water_area {
168 throwWarning: tr("Overlapping Water Areas");
169}
170
171area:closed:areaStyle area:closed:areaStyle {
172 throwOther: tr("Overlapping Areas");
173}
174
175/* see ticket #9311 */
176node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/] *[amenity=parking] {
177 throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
178 group: tr("{0} inside {1}", "amenity", "amenity");
179}
180
181/* see ticket #9556 */
182area:closed:areaStyle[tag("natural") = parent_tag("natural")] area:closed:areaStyle[natural] {
183 throwWarning: tr("Overlapping Identical Natural Areas");
184}
185
186area:closed:areaStyle[tag("landuse") = parent_tag("landuse")] area:closed:areaStyle[landuse] {
187 throwWarning: tr("Overlapping Identical Landuses");
188}
189
190/* see ticket:#9522 */
191node[tag("amenity") = parent_tag("amenity")] *[amenity][amenity != parking] {
192 throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
193 group: tr("{0} inside {1}", "amenity", "amenity");
194}
195node[tag("leisure") = parent_tag("leisure")] *[leisure] {
196 throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
197 group: tr("{0} inside {1}", "leisure", "leisure");
198}
199node[tag("tourism") = parent_tag("tourism")] *[tourism] {
200 throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
201 group: tr("{0} inside {1}", "tourism", "tourism");
202}
203node[tag("shop") = parent_tag("shop")] *[shop] {
204 throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
205 group: tr("{0} inside {1}", "shop", "shop");
206}
207node[tag("power") = parent_tag("power")] *[power] {
208 throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
209 group: tr("{0} inside {1}", "power", "power");
210}
211
212/* isolated nodes which should be part of a way, see #10825, #15478 */
213node:unconnected:in-downloaded-area[entrance],
214node:unconnected:in-downloaded-area[traffic_calming],
215node:unconnected:in-downloaded-area[highway=passing_place],
216node:unconnected:in-downloaded-area[highway=mini_roundabout],
217node:unconnected:in-downloaded-area[highway=motorway_junction],
218node:unconnected:in-downloaded-area[highway=turning_loop],
219node:unconnected:in-downloaded-area[highway=turning_circle],
220node:unconnected:in-downloaded-area[highway=stop],
221node:unconnected:in-downloaded-area[highway=give_way],
222node:unconnected:in-downloaded-area[highway=traffic_signals],
223node:unconnected:in-downloaded-area[highway=crossing],
224node:unconnected:in-downloaded-area[crossing],
225node:unconnected:in-downloaded-area[highway=milestone],
226node:unconnected:in-downloaded-area[railway=milestone],
227node:unconnected:in-downloaded-area[railway=crossing],
228node:unconnected:in-downloaded-area[railway=level_crossing],
229node:unconnected:in-downloaded-area[railway=buffer_stop],
230node:unconnected:in-downloaded-area[public_transport=stop_position],
231node:unconnected:in-downloaded-area[aeroway=holding_position],
232node:unconnected:in-downloaded-area[noexit],
233node:unconnected:in-downloaded-area[waterway=dam],
234node:unconnected:in-downloaded-area[waterway=weir],
235node:unconnected:in-downloaded-area[waterway=waterfall],
236node:unconnected:in-downloaded-area[amenity=ferry_terminal],
237node:unconnected:in-downloaded-area[leisure=slipway],
238node:unconnected:in-downloaded-area[mountain_pass=yes],
239node:unconnected:in-downloaded-area[barrier=gate],
240node:unconnected:in-downloaded-area[barrier=lift_gate],
241node:unconnected:in-downloaded-area[barrier=swing_gate],
242node:unconnected:in-downloaded-area[barrier=toll_booth],
243node:unconnected:in-downloaded-area[barrier=turnstile],
244node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
245node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
246node:unconnected:in-downloaded-area[barrier=rope],
247node:unconnected:in-downloaded-area[barrier=sally_port],
248node:unconnected:in-downloaded-area[barrier=spikes],
249node:unconnected:in-downloaded-area[barrier=stile],
250node:unconnected:in-downloaded-area[barrier=sump_buster],
251node:unconnected:in-downloaded-area[barrier=kerb],
252node:unconnected:in-downloaded-area[barrier=border_control],
253node:unconnected:in-downloaded-area[barrier=bump_gate],
254node:unconnected:in-downloaded-area[barrier=bus_trap],
255node:unconnected:in-downloaded-area[barrier=cattle_grid],
256node:unconnected:in-downloaded-area[barrier=chain],
257node:unconnected:in-downloaded-area[barrier=cycle_barrier],
258node:unconnected:in-downloaded-area[barrier=hampshire_gate],
259node:unconnected:in-downloaded-area[barrier=height_restrictor],
260node:unconnected:in-downloaded-area[barrier=debris] {
261 throwWarning: tr("{0}", "{2.tag}");
262 group: tr("isolated node which must be connected to a way");
263}
264
265/* #11127 */
266way[railway][bridge] > node,
267way[highway][bridge] > node {
268 set node_in_bridge;
269}
270way[waterway] > node.node_in_bridge {
271 throwWarning: tr("node connects waterway and bridge");
272}
273
274/* #11128, #14812, #15032 */
275way[highway] > node[tourism=information][information=guidepost] {
276 set guidepost;
277 throwOther: tr("{0} node connected to a highway", "{1.tag}");
278}
279way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge)$/],
280way[highway] > node[building][!entrance],
281way[highway] > node[leisure][!entrance][leisure!=slipway],
282way[highway] > node[office][!entrance],
283way[highway] > node[shop][!entrance],
284way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
285way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
286 throwWarning: tr("{0} node connected to a highway", "{0.key}");
287}
288
289way[junction=roundabout]:righthandtraffic:clockwise,
290way[junction=roundabout]!:righthandtraffic:anticlockwise {
291 throwWarning: tr("suspicious roundabout direction");
292}
293
294/* #12496 */
295area:closed[place=islet][eval(areasize()) > 1500000] {
296 throwWarning: tr("{0} on a large area", "{1.tag}");
297 suggestAlternative: "place=island";
298 fixAdd: "place=island";
299}
300
301area:closed[place=island][eval(areasize()) < 500000] {
302 throwWarning: tr("{0} on a small area", "{1.tag}");
303 suggestAlternative: "place=islet";
304 fixAdd: "place=islet";
305}
306
307/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
308area:closed[building][building!=no][eval(areasize()) > 520000] {
309 throwError: tr("Too large building");
310}
311
312/* #12577 */
313way[power=line] > node,
314way[power=minor_line] > node,
315way[power=cable] > node {
316 set node_in_power_way;
317}
318way[!power][!building] > node.node_in_power_way {
319 throwWarning: tr("Node connects a power line or cable with an object which is not related to the power infrastructure.");
320}
321
322/* #12646, #12992 */
323way[waterway=~/^(stream|ditch|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area {
324 throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
325}
326
327/* #10717, #14535 */
328way:closed[natural=coastline] area[natural=water],
329way:closed[natural=coastline] area[waterway=riverbank] {
330 throwError: tr("Coastline inside {1}", "{0.tag}");
331}
332
333/* #10471 */
334way[waterway] > node[ford?] { set ford_on_waterway; }
335way[highway] > node[ford?] { set ford_on_highway; }
336node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
337 throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
338}
339
340/* #13877 */
341area:closed[waterway = canal][area!=no],
342area:closed[waterway = drain][area!=no],
343area:closed[waterway = ditch][area!=no],
344area:closed[waterway = stream][area!=no],
345area:closed[waterway = river][area!=no] {
346 throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
347}
348
349/* #15097 */
350way[highway][area!=yes] > node,
351way[man_made=pier] > node {
352 set node_in_highway_pier;
353}
354way[route=ferry][tunnel=yes] > node,
355way[route=ferry][bridge=yes] > node {
356 set node_in_ferry_bridge_tunnel;
357}
358way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
359way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
360 throwWarning: tr("Ferry route is not connected to the road network or branches.");
361}
362way[amenity=ferry_terminal] > node,
363way[man_made=pier] > node {
364 set node_in_terminal_pier;
365}
366way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
367way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
368 throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
369}
Note: See TracBrowser for help on using the repository browser.