source: josm/trunk/data/validator/geometry.mapcss@ 13508

Last change on this file since 13508 was 13394, checked in by Klumbumbus, 6 years ago
  • fix #15648 - warn about unclosed ways with place=islands
  • fix #15659, see #12043 - always display place=island and place=islet fill color (and name) independent from the place style setting. Regression of r8986.
  • Property svn:eol-style set to native
File size: 13.7 KB
RevLine 
[7735]1/* {0} on a node, should be a way */
[11477]2node[area=no],
[6550]3node[oneway],
[7960]4node[bridge],
[7707]5node[sidewalk],
[7814]6node[footway],
[7960]7node[man_made=embankment],
[7975]8node[man_made=groyne],
[8147]9node[man_made=cutline],
[9494]10node[power=line],
[8147]11node[cutline],
[7915]12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
[7977]23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
[7737]34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
[7975]38node[waterway=drain],
[7735]39node[natural=coastline],
40node[natural=ridge],
[8135]41node[natural=valley],
[7735]42node[natural=tree_row] {
[7942]43 throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
[6550]44 assertMatch: "node oneway=-1";
45 assertNoMatch: "way oneway=-1";
46 assertMatch: "node bridge=yes";
[7963]47 assertMatch: "node bridge=viaduct";
[6611]48}
49
[13083]50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52 throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
[7735]55/* {0} on a node, should be an area; see ticket #10679 */
[11477]56node[area=yes],
[7735]57node[landuse],
58node[natural=scree],
59node[natural=scrub],
60node[natural=fell],
61node[natural=heath],
62node[natural=wood],
63node[natural=grassland],
64node[natural=wetland],
65node[natural=water],
66node[natural=mud],
67node[natural=beach],
68node[natural=sand],
69node[natural=wood],
70node[natural=bare_rock],
[9022]71node[natural=glacier],
[7735]72node[waterway=riverbank],
[7960]73node[man_made=bridge],
[7975]74node[man_made=breakwater],
[7977]75node[aeroway=apron],
[7967]76node[power=plant],
[8139]77node[building:part],
[7735]78node[source:outline] {
79 throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
[7468]80}
81
[11500]82/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
83node[type=multipolygon],
[7744]84node[route],
85node[restriction] {
[11500]86 throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}");
[7744]87}
88
[7942]89/* {0} on a way, should be a node */
[7960]90way[entrance],
[10429]91way[railway=subway_entrance],
[7960]92way[man_made=survey_point],
[11005]93way[aeroway=holding_position],
[9500]94way[power=transformer],
[7967]95way[power=pole],
[9494]96way[power=tower]!:closed,
[7977]97way[amenity=vending_machine],
[7942]98way[natural=peak],
99way[natural=saddle],
100way[natural=volcano],
[12708]101way[natural=tree],
[12775]102way[highway=give_way],
103way[highway=milestone],
104way[highway=mini_roundabout],
105way[highway=stop],
106way[highway=street_lamp],
107way[highway=traffic_signals],
108way[highway=turning_loop],
109way[highway=turning_circle],
[12708]110way[highway=motorway_junction] {
[7942]111 throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}");
112}
113
[13217]114/* {0} on a way, should be a relation; see #15642, #10252, #14288 */
115way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
[11500]116way[type=multipolygon],
[7744]117way[route=bus] {
[11500]118 throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}");
[7744]119}
120
[13006]121/* #14395 */
122way >[index=1] node,
123way >[index=-1] node {
124 set first_last_node;
125}
126way[highway][area!=yes][!tunnel][!covered] > node {
127 set node_in_highway;
128}
129way[building][building!=no] > node.node_in_highway!.first_last_node {
130 throwWarning: tr("node connects highway and building");
131}
132
133/* #15035, must not warn for node 3815077900*/
134node[man_made!=monitoring_station][at(0.0,0.0)] {
135 throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
136 fixDeleteObject: this;
137}
138
[9745]139/* #12502 */
140node[leisure=park][natural=tree] {
141 throwWarning: tr("{0} together with {1} on a node. Remove {0}.", "{0.tag}", "{1.tag}");
[11146]142 group: tr("suspicious tag combination");
[9745]143 fixRemove: "leisure";
144}
145node[leisure=park][natural!=tree] {
146 throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
147}
148
[7279]149/* see ticket:#10125 */
150node[source:geometry] {
151 throwWarning: tr("{0} on a node", "{0.key}");
152 fixChangeKey: "source:geometry => source:position";
153}
154
[6611]155/* Building inside building (spatial test) */
[7164]156*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")]
[6861]157*[building][building!~/no|entrance/] {
[6611]158 throwWarning: tr("Building inside building");
[6613]159}
160
161/* Overlapping areas (spatial test) */
162area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
163 set water_area;
164}
165
[7280]166/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
167area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/] area:closed:areaStyle.water_area,
168area:closed:areaStyle[landuse=reservoir] area:closed:areaStyle.water_area {
[6613]169 throwWarning: tr("Overlapping Water Areas");
170}
171
[6630]172area:closed:areaStyle area:closed:areaStyle {
[6613]173 throwOther: tr("Overlapping Areas");
174}
[6614]175
176/* see ticket #9311 */
[6628]177node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/] *[amenity=parking] {
[6614]178 throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
[11353]179 group: tr("{0} inside {1}", "amenity", "amenity");
[6680]180}
181
182/* see ticket #9556 */
183area:closed:areaStyle[tag("natural") = parent_tag("natural")] area:closed:areaStyle[natural] {
184 throwWarning: tr("Overlapping Identical Natural Areas");
185}
186
187area:closed:areaStyle[tag("landuse") = parent_tag("landuse")] area:closed:areaStyle[landuse] {
188 throwWarning: tr("Overlapping Identical Landuses");
[6719]189}
190
191/* see ticket:#9522 */
192node[tag("amenity") = parent_tag("amenity")] *[amenity][amenity != parking] {
193 throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
[10710]194 group: tr("{0} inside {1}", "amenity", "amenity");
[6719]195}
196node[tag("leisure") = parent_tag("leisure")] *[leisure] {
197 throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
[10710]198 group: tr("{0} inside {1}", "leisure", "leisure");
[6719]199}
200node[tag("tourism") = parent_tag("tourism")] *[tourism] {
201 throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
[10710]202 group: tr("{0} inside {1}", "tourism", "tourism");
[6719]203}
204node[tag("shop") = parent_tag("shop")] *[shop] {
205 throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
[10710]206 group: tr("{0} inside {1}", "shop", "shop");
[6759]207}
208node[tag("power") = parent_tag("power")] *[power] {
209 throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
[10710]210 group: tr("{0} inside {1}", "power", "power");
[7793]211}
212
[13074]213/* isolated nodes which should be part of a way, see #10825, #15478 */
[8522]214node:unconnected:in-downloaded-area[entrance],
215node:unconnected:in-downloaded-area[traffic_calming],
216node:unconnected:in-downloaded-area[highway=passing_place],
217node:unconnected:in-downloaded-area[highway=mini_roundabout],
218node:unconnected:in-downloaded-area[highway=motorway_junction],
219node:unconnected:in-downloaded-area[highway=turning_loop],
220node:unconnected:in-downloaded-area[highway=turning_circle],
221node:unconnected:in-downloaded-area[highway=stop],
222node:unconnected:in-downloaded-area[highway=give_way],
223node:unconnected:in-downloaded-area[highway=traffic_signals],
224node:unconnected:in-downloaded-area[highway=crossing],
225node:unconnected:in-downloaded-area[crossing],
[13074]226node:unconnected:in-downloaded-area[highway=milestone],
227node:unconnected:in-downloaded-area[railway=milestone],
[8522]228node:unconnected:in-downloaded-area[railway=crossing],
229node:unconnected:in-downloaded-area[railway=level_crossing],
230node:unconnected:in-downloaded-area[railway=buffer_stop],
231node:unconnected:in-downloaded-area[public_transport=stop_position],
[11005]232node:unconnected:in-downloaded-area[aeroway=holding_position],
[8522]233node:unconnected:in-downloaded-area[noexit],
234node:unconnected:in-downloaded-area[waterway=dam],
235node:unconnected:in-downloaded-area[waterway=weir],
236node:unconnected:in-downloaded-area[waterway=waterfall],
237node:unconnected:in-downloaded-area[amenity=ferry_terminal],
[11133]238node:unconnected:in-downloaded-area[leisure=slipway],
[8522]239node:unconnected:in-downloaded-area[mountain_pass=yes],
240node:unconnected:in-downloaded-area[barrier=gate],
241node:unconnected:in-downloaded-area[barrier=lift_gate],
242node:unconnected:in-downloaded-area[barrier=swing_gate],
243node:unconnected:in-downloaded-area[barrier=toll_booth],
244node:unconnected:in-downloaded-area[barrier=turnstile],
245node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
246node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
247node:unconnected:in-downloaded-area[barrier=rope],
248node:unconnected:in-downloaded-area[barrier=sally_port],
249node:unconnected:in-downloaded-area[barrier=spikes],
250node:unconnected:in-downloaded-area[barrier=stile],
251node:unconnected:in-downloaded-area[barrier=sump_buster],
252node:unconnected:in-downloaded-area[barrier=kerb],
253node:unconnected:in-downloaded-area[barrier=border_control],
254node:unconnected:in-downloaded-area[barrier=bump_gate],
255node:unconnected:in-downloaded-area[barrier=bus_trap],
256node:unconnected:in-downloaded-area[barrier=cattle_grid],
257node:unconnected:in-downloaded-area[barrier=chain],
258node:unconnected:in-downloaded-area[barrier=cycle_barrier],
259node:unconnected:in-downloaded-area[barrier=hampshire_gate],
260node:unconnected:in-downloaded-area[barrier=height_restrictor],
261node:unconnected:in-downloaded-area[barrier=debris] {
[11138]262 throwWarning: tr("{0}", "{2.tag}");
263 group: tr("isolated node which must be connected to a way");
[8089]264}
265
[11049]266/* #11127 */
[8089]267way[railway][bridge] > node,
268way[highway][bridge] > node {
269 set node_in_bridge;
270}
271way[waterway] > node.node_in_bridge {
272 throwWarning: tr("node connects waterway and bridge");
[9540]273}
274
[13006]275/* #11128, #14812, #15032 */
[10037]276way[highway] > node[tourism=information][information=guidepost] {
277 set guidepost;
278 throwOther: tr("{0} node connected to a highway", "{1.tag}");
279}
[12201]280way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge)$/],
[10026]281way[highway] > node[building][!entrance],
[10272]282way[highway] > node[leisure][!entrance][leisure!=slipway],
[10026]283way[highway] > node[office][!entrance],
284way[highway] > node[shop][!entrance],
[13006]285way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
286way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
[10028]287 throwWarning: tr("{0} node connected to a highway", "{0.key}");
[10026]288}
289
[9540]290way[junction=roundabout]:righthandtraffic:clockwise,
291way[junction=roundabout]!:righthandtraffic:anticlockwise {
292 throwWarning: tr("suspicious roundabout direction");
[9843]293}
294
295/* #12496 */
[10328]296area:closed[place=islet][eval(areasize()) > 1500000] {
[9843]297 throwWarning: tr("{0} on a large area", "{1.tag}");
298 suggestAlternative: "place=island";
299 fixAdd: "place=island";
300}
301
[10328]302area:closed[place=island][eval(areasize()) < 500000] {
[9843]303 throwWarning: tr("{0} on a small area", "{1.tag}");
304 suggestAlternative: "place=islet";
305 fixAdd: "place=islet";
[9985]306}
307
[13394]308/* #15648 */
309way[place=island]!:closed {
310 throwError: tr("Way with {1} not closed.", "{0.tag}");
311}
312
[11049]313/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
314area:closed[building][building!=no][eval(areasize()) > 520000] {
315 throwError: tr("Too large building");
[9985]316}
[10028]317
318/* #12577 */
319way[power=line] > node,
320way[power=minor_line] > node,
321way[power=cable] > node {
322 set node_in_power_way;
[10029]323}
[10028]324way[!power][!building] > node.node_in_power_way {
325 throwWarning: tr("Node connects a power line or cable with an object which is not related to the power infrastructure.");
[10029]326}
[10232]327
[10427]328/* #12646, #12992 */
[10530]329way[waterway=~/^(stream|ditch|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area {
[10232]330 throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
[10389]331}
332
[11744]333/* #10717, #14535 */
334way:closed[natural=coastline] area[natural=water],
335way:closed[natural=coastline] area[waterway=riverbank] {
[10389]336 throwError: tr("Coastline inside {1}", "{0.tag}");
[11146]337}
338
339/* #10471 */
340way[waterway] > node[ford?] { set ford_on_waterway; }
341way[highway] > node[ford?] { set ford_on_highway; }
342node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
343 throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
[11232]344}
[11736]345
[11232]346/* #13877 */
347area:closed[waterway = canal][area!=no],
348area:closed[waterway = drain][area!=no],
349area:closed[waterway = ditch][area!=no],
350area:closed[waterway = stream][area!=no],
351area:closed[waterway = river][area!=no] {
352 throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
[11736]353}
354
[12572]355/* #15097 */
356way[highway][area!=yes] > node,
357way[man_made=pier] > node {
358 set node_in_highway_pier;
359}
360way[route=ferry][tunnel=yes] > node,
361way[route=ferry][bridge=yes] > node {
362 set node_in_ferry_bridge_tunnel;
363}
364way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
365way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
366 throwWarning: tr("Ferry route is not connected to the road network or branches.");
367}
368way[amenity=ferry_terminal] > node,
369way[man_made=pier] > node {
370 set node_in_terminal_pier;
371}
372way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
373way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
374 throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
[12708]375}
Note: See TracBrowser for help on using the repository browser.