source: josm/trunk/data/validator/geometry.mapcss @ 11500

Last change on this file since 11500 was 11500, checked in by Klumbumbus, 2 years ago

fix #14288 - verify for improper usage of type=multipolygon in nodes and ways

  • Property svn:eol-style set to native
File size: 11.2 KB
RevLine 
[7735]1/* {0} on a node, should be a way */
[11477]2node[area=no],
[6550]3node[oneway],
[7960]4node[bridge],
[7707]5node[sidewalk],
[7814]6node[footway],
[7960]7node[man_made=embankment],
[7975]8node[man_made=groyne],
[8147]9node[man_made=cutline],
[9494]10node[power=line],
[8147]11node[cutline],
[7915]12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
[7977]23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
[7737]34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
[7975]38node[waterway=drain],
[7735]39node[natural=coastline],
40node[natural=ridge],
[8135]41node[natural=valley],
[7735]42node[natural=tree_row] {
[7942]43  throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
[6550]44  assertMatch: "node oneway=-1";
45  assertNoMatch: "way oneway=-1";
46  assertMatch: "node bridge=yes";
[7963]47  assertMatch: "node bridge=viaduct";
[6611]48}
49
[7735]50/* {0} on a node, should be an area; see ticket #10679 */
[11477]51node[area=yes],
[7735]52node[landuse],
53node[natural=scree],
54node[natural=scrub],
55node[natural=fell],
56node[natural=heath],
57node[natural=wood],
58node[natural=grassland],
59node[natural=wetland],
60node[natural=water],
61node[natural=mud],
62node[natural=beach],
63node[natural=sand],
64node[natural=wood],
65node[natural=bare_rock],
[9022]66node[natural=glacier],
[7735]67node[waterway=riverbank],
[7960]68node[man_made=bridge],
[7975]69node[man_made=breakwater],
[7977]70node[aeroway=apron],
[7967]71node[power=plant],
[8139]72node[building:part],
[7735]73node[source:outline] {
74  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
[7468]75}
76
[11500]77/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
78node[type=multipolygon],
[7744]79node[route],
80node[restriction] {
[11500]81  throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}"); 
[7744]82}
83
[7942]84/* {0} on a way, should be a node */
[7960]85way[entrance],
[10429]86way[railway=subway_entrance],
[7960]87way[man_made=survey_point],
[11005]88way[aeroway=holding_position],
[9500]89way[power=transformer],
[7967]90way[power=pole],
[9494]91way[power=tower]!:closed,
[7977]92way[amenity=vending_machine],
[7942]93way[natural=peak],
94way[natural=saddle],
95way[natural=volcano],
96way[natural=tree] {
97  throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}"); 
98}
99
[11500]100/* {0} on a way, should be a relation; see #10252, #14288 */
101way[type=multipolygon],
[7744]102way[route=bus] {
[11500]103  throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}"); 
[7744]104}
105
[9745]106/* #12502 */
107node[leisure=park][natural=tree] {
108  throwWarning: tr("{0} together with {1} on a node. Remove {0}.", "{0.tag}", "{1.tag}");
[11146]109  group: tr("suspicious tag combination");
[9745]110  fixRemove: "leisure";
111}
112node[leisure=park][natural!=tree] {
113  throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
114}
115
[7279]116/* see ticket:#10125 */
117node[source:geometry] {
118  throwWarning: tr("{0} on a node", "{0.key}");
119  fixChangeKey: "source:geometry => source:position";
120}
121
[6611]122/* Building inside building (spatial test) */
[7164]123*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")] 
[6861]124*[building][building!~/no|entrance/] {
[6611]125  throwWarning: tr("Building inside building");
[6613]126}
127
128/* Overlapping areas (spatial test) */
129area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
130  set water_area;
131}
132
[7280]133/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
134area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/]  area:closed:areaStyle.water_area,
135area:closed:areaStyle[landuse=reservoir]                         area:closed:areaStyle.water_area {
[6613]136  throwWarning: tr("Overlapping Water Areas");
137}
138
[6630]139area:closed:areaStyle  area:closed:areaStyle {
[6613]140  throwOther: tr("Overlapping Areas");
141}
[6614]142
143/* see ticket #9311 */
[6628]144node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/]  *[amenity=parking] {
[6614]145  throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
[11353]146  group: tr("{0} inside {1}", "amenity", "amenity");
[6680]147}
148
149/* see ticket #9556 */
150area:closed:areaStyle[tag("natural") = parent_tag("natural")]  area:closed:areaStyle[natural] {
151  throwWarning: tr("Overlapping Identical Natural Areas");
152}
153
154area:closed:areaStyle[tag("landuse") = parent_tag("landuse")]  area:closed:areaStyle[landuse] {
155  throwWarning: tr("Overlapping Identical Landuses");
[6719]156}
157
158/* see ticket:#9522 */
159node[tag("amenity") = parent_tag("amenity")]  *[amenity][amenity != parking] {
160  throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
[10710]161  group: tr("{0} inside {1}", "amenity", "amenity");
[6719]162}
163node[tag("leisure") = parent_tag("leisure")]  *[leisure] {
164  throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
[10710]165  group: tr("{0} inside {1}", "leisure", "leisure");
[6719]166}
167node[tag("tourism") = parent_tag("tourism")]  *[tourism] {
168  throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
[10710]169  group: tr("{0} inside {1}", "tourism", "tourism");
[6719]170}
171node[tag("shop") = parent_tag("shop")]  *[shop] {
172  throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
[10710]173  group: tr("{0} inside {1}", "shop", "shop");
[6759]174}
175node[tag("power") = parent_tag("power")]  *[power] {
176  throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
[10710]177  group: tr("{0} inside {1}", "power", "power");
[7793]178}
179
[7807]180/* isolated nodes which should be part of a way, see #10825 */
[8522]181node:unconnected:in-downloaded-area[entrance],
182node:unconnected:in-downloaded-area[traffic_calming],
183node:unconnected:in-downloaded-area[highway=passing_place],
184node:unconnected:in-downloaded-area[highway=mini_roundabout],
185node:unconnected:in-downloaded-area[highway=motorway_junction],
186node:unconnected:in-downloaded-area[highway=turning_loop],
187node:unconnected:in-downloaded-area[highway=turning_circle],
188node:unconnected:in-downloaded-area[highway=stop],
189node:unconnected:in-downloaded-area[highway=give_way],
190node:unconnected:in-downloaded-area[highway=traffic_signals],
191node:unconnected:in-downloaded-area[highway=crossing],
192node:unconnected:in-downloaded-area[crossing],
193node:unconnected:in-downloaded-area[railway=crossing],
194node:unconnected:in-downloaded-area[railway=level_crossing],
195node:unconnected:in-downloaded-area[railway=buffer_stop],
196node:unconnected:in-downloaded-area[public_transport=stop_position],
[11005]197node:unconnected:in-downloaded-area[aeroway=holding_position],
[8522]198node:unconnected:in-downloaded-area[noexit],
199node:unconnected:in-downloaded-area[waterway=dam],
200node:unconnected:in-downloaded-area[waterway=weir],
201node:unconnected:in-downloaded-area[waterway=waterfall],
202node:unconnected:in-downloaded-area[amenity=ferry_terminal],
[11133]203node:unconnected:in-downloaded-area[leisure=slipway],
[8522]204node:unconnected:in-downloaded-area[mountain_pass=yes],
205node:unconnected:in-downloaded-area[barrier=gate],
206node:unconnected:in-downloaded-area[barrier=lift_gate],
207node:unconnected:in-downloaded-area[barrier=swing_gate],
208node:unconnected:in-downloaded-area[barrier=toll_booth],
209node:unconnected:in-downloaded-area[barrier=turnstile],
210node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
211node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
212node:unconnected:in-downloaded-area[barrier=rope],
213node:unconnected:in-downloaded-area[barrier=sally_port],
214node:unconnected:in-downloaded-area[barrier=spikes],
215node:unconnected:in-downloaded-area[barrier=stile],
216node:unconnected:in-downloaded-area[barrier=sump_buster],
217node:unconnected:in-downloaded-area[barrier=kerb],
218node:unconnected:in-downloaded-area[barrier=border_control],
219node:unconnected:in-downloaded-area[barrier=bump_gate],
220node:unconnected:in-downloaded-area[barrier=bus_trap],
221node:unconnected:in-downloaded-area[barrier=cattle_grid],
222node:unconnected:in-downloaded-area[barrier=chain],
223node:unconnected:in-downloaded-area[barrier=cycle_barrier],
224node:unconnected:in-downloaded-area[barrier=hampshire_gate],
225node:unconnected:in-downloaded-area[barrier=height_restrictor],
226node:unconnected:in-downloaded-area[barrier=debris] {
[11138]227  throwWarning: tr("{0}", "{2.tag}");
228  group: tr("isolated node which must be connected to a way");
[8089]229}
230
[11049]231/* #11127 */
[8089]232way[railway][bridge] > node,
233way[highway][bridge] > node {
234  set node_in_bridge;
235}
236way[waterway] > node.node_in_bridge {
237  throwWarning: tr("node connects waterway and bridge");
[9540]238}
239
[11049]240/* #11128 */
[10037]241way[highway] > node[tourism=information][information=guidepost] {
242  set guidepost;
243  throwOther: tr("{0} node connected to a highway", "{1.tag}");
244}
[10349]245way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal)$/],
[10026]246way[highway] > node[building][!entrance],
[10272]247way[highway] > node[leisure][!entrance][leisure!=slipway],
[10026]248way[highway] > node[office][!entrance],
249way[highway] > node[shop][!entrance],
[10071]250way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost {
[10028]251  throwWarning: tr("{0} node connected to a highway", "{0.key}");
[10026]252}
253
[9540]254way[junction=roundabout]:righthandtraffic:clockwise,
255way[junction=roundabout]!:righthandtraffic:anticlockwise {
256  throwWarning: tr("suspicious roundabout direction");
[9843]257}
258
259/* #12496 */
[10328]260area:closed[place=islet][eval(areasize()) > 1500000] {
[9843]261  throwWarning: tr("{0} on a large area", "{1.tag}");
262  suggestAlternative: "place=island";
263  fixAdd: "place=island";
264}
265
[10328]266area:closed[place=island][eval(areasize()) < 500000] {
[9843]267  throwWarning: tr("{0} on a small area", "{1.tag}");
268  suggestAlternative: "place=islet";
269  fixAdd: "place=islet";
[9985]270}
271
[11049]272/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
273area:closed[building][building!=no][eval(areasize()) > 520000] {
274  throwError: tr("Too large building");
[9985]275}
[10028]276
277/* #12577 */
278way[power=line] > node,
279way[power=minor_line] > node,
280way[power=cable] > node {
281  set node_in_power_way;
[10029]282}
[10028]283way[!power][!building] > node.node_in_power_way {
284  throwWarning: tr("Node connects a power line or cable with an object which is not related to the power infrastructure.");
[10029]285}
[10232]286
[10427]287/* #12646, #12992 */
[10530]288way[waterway=~/^(stream|ditch|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area { 
[10232]289  throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
[10389]290}
291
292/* #10717 */
293way[natural=coastline]  area[natural=water],
294way[natural=coastline]  area[waterway=riverbank] {
295  throwError: tr("Coastline inside {1}", "{0.tag}");
[11146]296}
297
298/* #10471 */
299way[waterway] > node[ford?] { set ford_on_waterway; }
300way[highway] > node[ford?] { set ford_on_highway; }
301node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
302    throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
[11232]303}
304/* #13877 */
305area:closed[waterway = canal][area!=no],
306area:closed[waterway = drain][area!=no],
307area:closed[waterway = ditch][area!=no],
308area:closed[waterway = stream][area!=no],
309area:closed[waterway = river][area!=no] {
310  throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
[10232]311}
Note: See TracBrowser for help on using the repository browser.