source: josm/trunk/data/validator/combinations.mapcss @ 9903

Last change on this file since 9903 was 9903, checked in by Don-vip, 4 years ago

fix #12578 - Take pipeline substations into account when validating substation=* tag

  • Property svn:eol-style set to native
File size: 16.3 KB
Line 
1/* Rules partially derived from Taginfo statistics - see ticket #5017
2 * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000;
3 */
4
5/* {0.key} without {1.key} (warning level) */
6way[junction                   ][!highway][junction!=yes],
7*[lanes                        ][!highway],
8*[lcn                          ][!highway],
9*[living_street                ][!highway],
10*[maintenance                  ][!highway],
11*[median                       ][!highway],
12*[motorroad                    ][!highway],
13*[ntd_id                       ][!highway],
14*[sac_scale                    ][!highway],
15*[sidewalk                     ][!highway],
16*[step_count                   ][!highway],
17*[tracktype                    ][!highway],
18*[trail_visibility             ][!highway],
19*[trolley_wire                 ][!highway],
20*[zip_left                     ][!highway],
21*[zip_right                    ][!highway],
22*[detail                       ][!railway][route!=railway],
23*[eddy_current_brake           ][!railway][route!=railway],
24*[electrified                  ][!railway][route!=railway],
25*[etcs                         ][!railway][route!=railway],
26*[gauge                        ][!railway][route!=railway],
27*[grade_of_track               ][!railway][route!=railway],
28*[kursbuchstrecke              ][!railway][route!=railway],
29*[lzb                          ][!railway][route!=railway],
30*[old_railway_operator         ][!railway][route!=railway],
31*[operating_procedure          ][!railway][route!=railway],
32*[pzb                          ][!railway][route!=railway],
33*[radio                        ][!railway][route!=railway],
34*[structure_gauge              ][!railway][route!=railway],
35*[tilting_technology           ][!railway][route!=railway],
36*[track_class                  ][!railway][route!=railway],
37*[tracks                       ][!railway][route!=railway],
38*[traffic_mode                 ][!railway][route!=railway],
39*[usage                        ][!railway][route!=railway][man_made!=pipeline],
40*[workrules                    ][!railway][route!=railway],
41*[stream                       ][!waterway],
42*[length_unit                  ][!waterway],
43*[llid                         ][!waterway],
44*[canal                        ][!waterway],
45*[have_riverbank               ][!waterway],
46*[border_type                  ][!boundary],
47*[bridge:structure             ][!bridge],
48*[piste:difficulty             ][!piste:type],
49*[source:date                  ][!source],
50*[source:name                  ][!name],
51*[source:maxspeed:forward      ][!maxspeed:forward],
52*[source:maxspeed:backward     ][!maxspeed:backward],
53*[source:maxspeed:forward      ][!source:maxspeed:backward],
54*[source:maxspeed:backward     ][!source:maxspeed:forward],
55*[source:building              ][!building],
56*[source:ref                   ][!ref],
57*[source:population            ][!population],
58*[source:postal_code           ][!postal_code],
59*[source:ele                   ][!ele],
60*[source:ref:INSEE             ][!ref:INSEE],
61*[source:lit                   ][!lit],
62*[source:hgv                   ][!hgv],
63*[source:highway               ][!highway],
64*[source:maxaxleload           ][!maxaxleload],
65*[source:surface               ][!surface],
66*[source:bridge                ][!bridge],
67*[source:old_name              ][!old_name],
68*[source:bicycle               ][!bicycle],
69*[source:designation           ][!designation],
70*[source:height                ][!height],
71*[source:lanes                 ][!lanes],
72*[source:postcode              ][!addr:postcode],
73*[source:housenumber           ][!addr:housenumber],
74*[source:addr:postcode         ][!addr:postcode],
75*[source:addr:housenumber      ][!addr:housenumber],
76*[source:addr                  ][!/^addr:/],
77*[source:maxspeed              ][!/^maxspeed:?/] {
78  throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
79  assertMatch: "way lanes=42";
80  assertNoMatch: "way lanes=42 highway=unclassified";
81  assertMatch: "node source:addr:postcode=postman";
82  assertMatch: "node source:addr=postman";
83  assertNoMatch: "node source:addr=postman addr:housenumber=42";
84}
85
86/* {0.key} without {1.key} (info level) */
87*[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1],
88*[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1],
89*[leaf_type ][!leaf_cycle],
90*[leaf_cycle][!leaf_type] {
91  throwOther: tr("{0} without {1}", "{0.key}", "{1.key}");
92}
93
94/* {0.key} without {1.tag} */
95*[transformer                  ][!power],
96*[fence_type                   ][barrier!=fence],
97*[recycling_type               ][amenity!=recycling],
98*[information                  ][tourism!=information],
99*[board_type                   ][information!=board],
100*[shelter_type                 ][amenity!=shelter],
101*[lamp_type                    ][highway!=street_lamp],
102*[map_type                     ][information!=map],
103*[site_type                    ][historic!=archaeological_site],
104*[artwork_type                 ][tourism!=artwork],
105*[castle_type                  ][historic!=castle],
106*[bridge:movable               ][bridge!=movable],
107*[parking                      ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
108*[cutline                      ][man_made!=cutline],
109*[bunker_type                  ][military!=bunker] {
110  throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
111}
112
113/* {0.key} without {1.tag} or {2.tag} */
114*[substation                   ][power!=substation][pipeline!=substation],
115*[reservoir_type               ][landuse!=reservoir][water!=reservoir] {
116  throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.tag}", "{2.tag}");
117}
118
119/* {0.tag} without {1.key} (warning level) */
120*[tourism=information][!information],
121*[aeroway=terminal][!building],
122*[power=generator][!generator:source],
123*[amenity=place_of_worship][!religion] {
124  throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
125}
126
127/* {0.tag} without {1.key} (info level) */
128way[power=cable                ][!location],
129node[power=transformer         ][!voltage],
130way[power=line                 ][!voltage],
131way[power=minor_line           ][!voltage],
132way[power=cable                ][!voltage],
133*[power=generator              ][!voltage][generator:output:electricity],
134*[power=plant                  ][!voltage][plant:output:electricity],
135*[power=substation             ][!substation],
136*[power=transformer            ][!transformer],
137*[amenity=parking              ][!parking],
138*[amenity=parking_entrance     ][!parking] {
139  throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}");
140  assertMatch: "way power=line";
141  assertNoMatch: "way power=line voltage=1";
142  assertNoMatch: "way power=switch";
143  assertMatch: "way power=substation";
144  assertMatch: "way power=substation transformer=foobar";
145  assertNoMatch: "way power=substation substation=foobar";
146  assertMatch: "way power=generator generator:output:electricity=yes";
147  assertNoMatch: "way power=generator";
148  assertNoMatch: "way power=generator generator:output:electricity=yes voltage=1";
149}
150
151/* {0.key} without {1.key} or {2.key} */
152*[oneway                       ][!highway][!railway] {
153  throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
154}
155
156/* {0.key} without {1.key} or {2.tag} */
157*[smoothness                   ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
158*[segregated                   ][!highway][railway!=crossing] {
159  throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}");
160}
161
162/* {0.tag} without {1.tag} (info level) see #11600 #11393 #11850 */
163*[highway=motorway][!oneway][junction!=roundabout],
164*[highway=motorway_link][!oneway][junction!=roundabout] {
165  throwOther: tr("{0} without {1}", "{0.tag}", "{1.tag}");
166}
167
168/* {0.tag} without {1.tag} or {2.tag} */
169*[amenity=recycling][recycling_type!=container][recycling_type!=centre] {
170  throwWarning: tr("{0} without {1} or {2}", "{0.tag}", "{1.tag}", "{2.tag}");
171}
172
173/* {0.key} without {1.key}, {2.tag} or {3.tag} */
174*[intermittent                 ][!waterway][natural!~/^(water|spring)$/][ford!=yes],
175*[boat                         ][!waterway][natural!=water][landuse!=basin] {
176  throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}");
177}
178
179/* {0.key} without {1.key}, {2.key} or {3.key} */
180*[snowplowing                  ][!highway][!amenity][!leisure] {
181  throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}");
182}
183
184/* {0.key} without {1.key}, {2.key} or {3.tag} */
185*[incline                      ][!highway][!railway][aeroway!~/^(runway|taxiway)$/],
186*[toll                         ][!highway][!barrier][route!~/^(ferry|road)$/] {
187  throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}");
188}
189
190/* {0.tag} together with {1.key}, see #10837 */
191*[noname?][name] {
192  throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
193}
194
195/* {0.tag} together with {1.key}, see #9389, #11977 */
196*[oneway=yes][/:backward/][!"traffic_sign:backward"],
197*[oneway=yes][/:forward/][!"traffic_sign:forward"],
198*[oneway=-1 ][/:backward/][!"traffic_sign:backward"],
199*[oneway=-1 ][/:forward/][!"traffic_sign:forward"] {
200  throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
201}
202
203/* {0.tag} together with {1.tag} (info level), see #9696 */
204*[highway=footway][oneway=no] {
205  throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
206}
207
208/* {0.tag} together with {1.tag}, see #10186 */
209*[highway=footway][bicycle=designated] {
210  throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
211}
212
213/*see #11127*/
214way[waterway][bridge=yes] {
215  throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}");
216  suggestAlternative: "bridge=aqueduct";
217  fixAdd: "bridge=aqueduct";
218}
219
220/* only {0.key}, see #11104 #12422 */
221*[area][eval(number_of_tags()) = 1],
222*[name][eval(number_of_tags()) = 1],
223*[ref][eval(number_of_tags()) = 1],
224*[lit][eval(number_of_tags()) = 1] {
225  throwWarning: tr("incomplete object: only {0}", "{0.key}");
226}
227/* only {0.key} and {1.key}, see #11104 */
228*[name][area][eval(number_of_tags()) = 2],
229*[name][ref][eval(number_of_tags()) = 2] {
230  throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}");
231}
232
233/* see #9811, #11491 */
234*[place][place!=farm][/^addr:/],
235*[boundary][/^addr:/],
236*[highway][/^addr:/][highway!=services][highway!=rest_area][!"addr:postcode"] {
237  throwWarning: tr("{0} together with addr:*", "{0.key}");
238}
239*[!highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
240  throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
241}
242*[!highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
243  throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
244}
245way[highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
246  throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
247  fixRemove: "addr:postcode";
248}
249way[highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
250  throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
251}
252way[highway][!postal_code]["addr:postcode"] {
253  throwWarning: tr("{0} together with {1}", "{0.key}", "{2.key}");
254  suggestAlternative: "postal_code";
255  fixChangeKey: "addr:postcode=>postal_code";
256}
257
258/* see #9195 */
259*[highway=footway][cycleway=lane] {
260  throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
261  suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes";
262}
263
264/* {0} on suspicious object */
265*[tunnel  ][!highway][!railway][!waterway][public_transport != platform][man_made != pipeline],
266*[bridge  ][!highway][!railway][!waterway][!piste:type][public_transport != platform][man_made !~ /^(bridge|pipeline)$/][building != bridge],
267*[psv     ][!highway][!railway][!waterway][amenity !~ /^parking.*/],
268*[width   ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance],
269*[maxspeed][!highway][!railway][traffic_sign !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][type != enforcement][waterway !~ /^(river|canal|lock)$/][!traffic_calming] {
270  throwWarning: tr("{0} on suspicious object", "{0.key}");
271}
272
273node[amenity =~ /^(restaurant|cafe|fast_food)$/][!name][noname!=yes] {
274  throwOther: tr("restaurant without name");
275  assertMatch: "node amenity=restaurant";
276  assertNoMatch: "node amenity=restaurant noname=yes";
277  assertNoMatch: "node amenity=restaurant name=Foobar";
278}
279
280way[highway][barrier],
281*[highway][waterway][waterway!=dam][waterway!=weir],
282way[highway][natural],
283*[landuse][building] {
284  throwWarning: tr("{0} used with {1}", "{0.key}", "{1.key}");
285  assertNoMatch: "node highway=street_lamp natural=birds_nest note=josm#10193";
286}
287
288*[natural=water][leisure=swimming_pool],
289*[natural=water][amenity=swimming_pool] {
290  /* see #6932 */
291  throwWarning: tr("natural water used for swimming pool");
292  fixRemove: "natural";
293}
294
295/* see #9593, #11183, #12418 */
296*[sport][!building][!club][tourism != hotel][highway != raceway][leisure !~ /^(sports_centre|stadium|track|pitch|golf_course|water_park|swimming_pool|recreation_ground|ice_rink)$/][natural !~ /^(beach|bare_rock|peak|water)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/][barrier !~ /^(wall|retaining_wall)$/][!"piste:type"][shop!=sports] {
297    throwWarning: tr("sport without physical feature");
298    assertMatch: "node sport=tennis";
299    assertNoMatch: "node sport=tennis leisure=pitch";
300    assertNoMatch: "node sport=beachvolleyball natural=beach";
301    assertNoMatch: "node sport=skiiing landuse=piste";
302    assertNoMatch: "node sport=swimming tourism=hotel";
303    assertNoMatch: "node sport=10pin amenity=restaurant";
304}
305
306/* see #10140 */
307*[building:levels][!building][!building:part] {
308  throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
309}
310
311/* see #10471 */
312way[waterway] > node[ford?] { set ford_on_waterway; }
313way[highway] > node[ford?] { set ford_on_highway; }
314node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
315    throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
316}
317
318/* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 */
319*[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] {
320  throwWarning: tr("alternative name without {0}", "{1.key}");
321}
322
323/* see #10837 */
324way[destination][!oneway?][junction!=roundabout][highway] {
325  throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}");
326  suggestAlternative: "destination:forward";
327  suggestAlternative: "destination:backward";
328}
329
330/* see #11389 */
331way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] {
332  throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");
333  suggestAlternative: "maxspeed";
334  fixChangeKey: "maxspeed:forward=>maxspeed";
335  fixRemove: "maxspeed:backward";
336}
337way["maxspeed:forward"=*maxspeed]["maxspeed:backward"=*maxspeed][maxspeed] {
338  throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}");
339  set AllSameMaxspeed;
340  suggestAlternative: "maxspeed";
341  fixRemove: "maxspeed:forward";
342  fixRemove: "maxspeed:backward";
343}
344way["maxspeed:forward"]["maxspeed:backward"][maxspeed]!.AllSameMaxspeed {
345  throwWarning: tr("{0} and {1} together with {2} and conflicting values", "{0.key}", "{1.key}", "{2.key}");
346}
347way["maxspeed:forward"][maxspeed][!"maxspeed:backward"],
348way["maxspeed:backward"][maxspeed][!"maxspeed:forward"] {
349  throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
350}
351
352/* see #11837 */
353way[layer][layer<0][bridge][bridge!=no][location!=underground][indoor!=yes][!tunnel],
354way[layer][layer>0][tunnel][tunnel!=no][location!=overground][indoor!=yes][!bridge] {
355  throwWarning: tr("Suspicious tag combination: {0} and {1}", "{2.tag}", "{0.tag}");
356}
Note: See TracBrowser for help on using the repository browser.