1 | /* Rules partially derived from Taginfo statistics - see ticket #5017
|
---|
2 | * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000;
|
---|
3 | */
|
---|
4 |
|
---|
5 | /* {0.key} without {1.key} (warning level) */
|
---|
6 | way[junction ][!highway][junction!=yes],
|
---|
7 | *[lanes ][!highway],
|
---|
8 | *[lcn ][!highway],
|
---|
9 | *[living_street ][!highway],
|
---|
10 | *[maintenance ][!highway],
|
---|
11 | *[median ][!highway],
|
---|
12 | *[motorroad ][!highway],
|
---|
13 | *[ntd_id ][!highway],
|
---|
14 | *[sac_scale ][!highway],
|
---|
15 | *[sidewalk ][!highway],
|
---|
16 | *[step_count ][!highway],
|
---|
17 | *[tracktype ][!highway],
|
---|
18 | *[trail_visibility ][!highway],
|
---|
19 | *[trolley_wire ][!highway],
|
---|
20 | *[zip_left ][!highway],
|
---|
21 | *[zip_right ][!highway],
|
---|
22 | *[detail ][!railway][route!=railway],
|
---|
23 | *[eddy_current_brake ][!railway][route!=railway],
|
---|
24 | *[electrified ][!railway][route!=railway],
|
---|
25 | *[etcs ][!railway][route!=railway],
|
---|
26 | *[gauge ][!railway][route!=railway],
|
---|
27 | *[grade_of_track ][!railway][route!=railway],
|
---|
28 | *[kursbuchstrecke ][!railway][route!=railway],
|
---|
29 | *[lzb ][!railway][route!=railway],
|
---|
30 | *[old_railway_operator ][!railway][route!=railway],
|
---|
31 | *[operating_procedure ][!railway][route!=railway],
|
---|
32 | *[pzb ][!railway][route!=railway],
|
---|
33 | *[radio ][!railway][route!=railway],
|
---|
34 | *[structure_gauge ][!railway][route!=railway],
|
---|
35 | *[tilting_technology ][!railway][route!=railway],
|
---|
36 | *[track_class ][!railway][route!=railway],
|
---|
37 | *[tracks ][!railway][route!=railway],
|
---|
38 | *[traffic_mode ][!railway][route!=railway],
|
---|
39 | *[usage ][!railway][route!=railway][man_made!=pipeline],
|
---|
40 | *[workrules ][!railway][route!=railway],
|
---|
41 | *[stream ][!waterway],
|
---|
42 | *[length_unit ][!waterway],
|
---|
43 | *[llid ][!waterway],
|
---|
44 | *[canal ][!waterway],
|
---|
45 | *[have_riverbank ][!waterway],
|
---|
46 | *[border_type ][!boundary],
|
---|
47 | *[bridge:structure ][!bridge],
|
---|
48 | *[piste:difficulty ][!piste:type],
|
---|
49 | *[source:date ][!source],
|
---|
50 | *[source:name ][!name],
|
---|
51 | *[source:maxspeed:forward ][!maxspeed:forward],
|
---|
52 | *[source:maxspeed:backward ][!maxspeed:backward],
|
---|
53 | *[source:maxspeed:forward ][!source:maxspeed:backward],
|
---|
54 | *[source:maxspeed:backward ][!source:maxspeed:forward],
|
---|
55 | *[source:building ][!building],
|
---|
56 | *[source:ref ][!ref],
|
---|
57 | *[source:population ][!population],
|
---|
58 | *[source:postal_code ][!postal_code],
|
---|
59 | *[source:ele ][!ele],
|
---|
60 | *[source:ref:INSEE ][!ref:INSEE],
|
---|
61 | *[source:lit ][!lit],
|
---|
62 | *[source:hgv ][!hgv],
|
---|
63 | *[source:highway ][!highway],
|
---|
64 | *[source:maxaxleload ][!maxaxleload],
|
---|
65 | *[source:surface ][!surface],
|
---|
66 | *[source:bridge ][!bridge],
|
---|
67 | *[source:old_name ][!old_name],
|
---|
68 | *[source:bicycle ][!bicycle],
|
---|
69 | *[source:designation ][!designation],
|
---|
70 | *[source:height ][!height],
|
---|
71 | *[source:lanes ][!lanes],
|
---|
72 | *[source:postcode ][!addr:postcode],
|
---|
73 | *[source:housenumber ][!addr:housenumber],
|
---|
74 | *[source:addr:postcode ][!addr:postcode],
|
---|
75 | *[source:addr:housenumber ][!addr:housenumber],
|
---|
76 | *[source:addr ][!/^addr:/],
|
---|
77 | *[source:maxspeed ][!/^maxspeed:?/] {
|
---|
78 | throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
|
---|
79 | assertMatch: "way lanes=42";
|
---|
80 | assertNoMatch: "way lanes=42 highway=unclassified";
|
---|
81 | assertMatch: "node source:addr:postcode=postman";
|
---|
82 | assertMatch: "node source:addr=postman";
|
---|
83 | assertNoMatch: "node source:addr=postman addr:housenumber=42";
|
---|
84 | }
|
---|
85 |
|
---|
86 | /* {0.key} without {1.key} (info level) */
|
---|
87 | *[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1],
|
---|
88 | *[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1],
|
---|
89 | *[leaf_type ][!leaf_cycle],
|
---|
90 | *[leaf_cycle][!leaf_type] {
|
---|
91 | throwOther: tr("{0} without {1}", "{0.key}", "{1.key}");
|
---|
92 | }
|
---|
93 |
|
---|
94 | /* {0.key} without {1.tag} */
|
---|
95 | *[substation ][power!=substation],
|
---|
96 | *[transformer ][!power],
|
---|
97 | *[fence_type ][barrier!=fence],
|
---|
98 | *[recycling_type ][amenity!=recycling],
|
---|
99 | *[information ][tourism!=information],
|
---|
100 | *[board_type ][information!=board],
|
---|
101 | *[shelter_type ][amenity!=shelter],
|
---|
102 | *[lamp_type ][highway!=street_lamp],
|
---|
103 | *[map_type ][information!=map],
|
---|
104 | *[site_type ][historic!=archaeological_site],
|
---|
105 | *[artwork_type ][tourism!=artwork],
|
---|
106 | *[castle_type ][historic!=castle],
|
---|
107 | *[reservoir_type ][landuse!=reservoir][water!=reservoir],
|
---|
108 | *[bridge:movable ][bridge!=movable],
|
---|
109 | *[parking ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
|
---|
110 | *[cutline ][man_made!=cutline],
|
---|
111 | *[bunker_type ][military!=bunker] {
|
---|
112 | throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
|
---|
113 | }
|
---|
114 |
|
---|
115 | /* {0.tag} without {1.key} (warning level) */
|
---|
116 | *[tourism=information][!information],
|
---|
117 | *[aeroway=terminal][!building],
|
---|
118 | *[power=generator][!generator:source],
|
---|
119 | *[amenity=place_of_worship][!religion] {
|
---|
120 | throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
|
---|
121 | }
|
---|
122 |
|
---|
123 | /* {0.tag} without {1.key} (info level) */
|
---|
124 | way[power=cable ][!location],
|
---|
125 | node[power=transformer ][!voltage],
|
---|
126 | way[power=line ][!voltage],
|
---|
127 | way[power=minor_line ][!voltage],
|
---|
128 | way[power=cable ][!voltage],
|
---|
129 | *[power=generator ][!voltage][generator:output:electricity],
|
---|
130 | *[power=plant ][!voltage][plant:output:electricity],
|
---|
131 | *[power=substation ][!substation],
|
---|
132 | *[power=transformer ][!transformer],
|
---|
133 | *[amenity=parking ][!parking],
|
---|
134 | *[amenity=parking_entrance ][!parking] {
|
---|
135 | throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}");
|
---|
136 | assertMatch: "way power=line";
|
---|
137 | assertNoMatch: "way power=line voltage=1";
|
---|
138 | assertNoMatch: "way power=switch";
|
---|
139 | assertMatch: "way power=substation";
|
---|
140 | assertMatch: "way power=substation transformer=foobar";
|
---|
141 | assertNoMatch: "way power=substation substation=foobar";
|
---|
142 | assertMatch: "way power=generator generator:output:electricity=yes";
|
---|
143 | assertNoMatch: "way power=generator";
|
---|
144 | assertNoMatch: "way power=generator generator:output:electricity=yes voltage=1";
|
---|
145 | }
|
---|
146 |
|
---|
147 | /* {0.key} without {1.key} or {2.key} */
|
---|
148 | *[oneway ][!highway][!railway] {
|
---|
149 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
|
---|
150 | }
|
---|
151 |
|
---|
152 | /* {0.key} without {1.key} or {2.tag} */
|
---|
153 | *[smoothness ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
|
---|
154 | *[segregated ][!highway][railway!=crossing] {
|
---|
155 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}");
|
---|
156 | }
|
---|
157 |
|
---|
158 | /* {0.tag} without {1.tag} (info level) see #11600 #11393 #11850 */
|
---|
159 | *[highway=motorway][!oneway][junction!=roundabout],
|
---|
160 | *[highway=motorway_link][!oneway][junction!=roundabout] {
|
---|
161 | throwOther: tr("{0} without {1}", "{0.tag}", "{1.tag}");
|
---|
162 | }
|
---|
163 |
|
---|
164 | /* {0.tag} without {1.tag} or {2.tag} */
|
---|
165 | *[amenity=recycling][recycling_type!=container][recycling_type!=centre] {
|
---|
166 | throwWarning: tr("{0} without {1} or {2}", "{0.tag}", "{1.tag}", "{2.tag}");
|
---|
167 | }
|
---|
168 |
|
---|
169 | /* {0.key} without {1.key}, {2.tag} or {3.tag} */
|
---|
170 | *[intermittent ][!waterway][natural!~/^(water|spring)$/][ford!=yes],
|
---|
171 | *[boat ][!waterway][natural!=water][landuse!=basin] {
|
---|
172 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}");
|
---|
173 | }
|
---|
174 |
|
---|
175 | /* {0.key} without {1.key}, {2.key} or {3.key} */
|
---|
176 | *[snowplowing ][!highway][!amenity][!leisure] {
|
---|
177 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}");
|
---|
178 | }
|
---|
179 |
|
---|
180 | /* {0.key} without {1.key}, {2.key} or {3.tag} */
|
---|
181 | *[incline ][!highway][!railway][aeroway!~/^(runway|taxiway)$/],
|
---|
182 | *[toll ][!highway][!barrier][route!~/^(ferry|road)$/] {
|
---|
183 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}");
|
---|
184 | }
|
---|
185 |
|
---|
186 | /* {0.tag} together with {1.key}, see #10837 */
|
---|
187 | *[noname?][name] {
|
---|
188 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
|
---|
189 | }
|
---|
190 |
|
---|
191 | /* {0.tag} together with {1.key}, see #9389, #11977 */
|
---|
192 | *[oneway=yes][/:backward/][!"traffic_sign:backward"],
|
---|
193 | *[oneway=yes][/:forward/][!"traffic_sign:forward"],
|
---|
194 | *[oneway=-1 ][/:backward/][!"traffic_sign:backward"],
|
---|
195 | *[oneway=-1 ][/:forward/][!"traffic_sign:forward"] {
|
---|
196 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
|
---|
197 | }
|
---|
198 |
|
---|
199 | /* {0.tag} together with {1.tag} (info level), see #9696 */
|
---|
200 | *[highway=footway][oneway=no] {
|
---|
201 | throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
---|
202 | }
|
---|
203 |
|
---|
204 | /* {0.tag} together with {1.tag}, see #10186 */
|
---|
205 | *[highway=footway][bicycle=designated] {
|
---|
206 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
---|
207 | }
|
---|
208 |
|
---|
209 | /*see #11127*/
|
---|
210 | way[waterway][bridge=yes] {
|
---|
211 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}");
|
---|
212 | suggestAlternative: "bridge=aqueduct";
|
---|
213 | fixAdd: "bridge=aqueduct";
|
---|
214 | }
|
---|
215 |
|
---|
216 | /* only {0.key}, see #11104 */
|
---|
217 | *[area][eval(number_of_tags()) = 1],
|
---|
218 | *[name][eval(number_of_tags()) = 1],
|
---|
219 | *[ref][eval(number_of_tags()) = 1] {
|
---|
220 | throwWarning: tr("incomplete object: only {0}", "{0.key}");
|
---|
221 | }
|
---|
222 | /* only {0.key} and {1.key}, see #11104 */
|
---|
223 | *[name][area][eval(number_of_tags()) = 2],
|
---|
224 | *[name][ref][eval(number_of_tags()) = 2] {
|
---|
225 | throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}");
|
---|
226 | }
|
---|
227 |
|
---|
228 | /* see #9811, #11491 */
|
---|
229 | *[place][place!=farm][/^addr:/],
|
---|
230 | *[boundary][/^addr:/],
|
---|
231 | *[highway][/^addr:/][highway!=services][highway!=rest_area][!"addr:postcode"] {
|
---|
232 | throwWarning: tr("{0} together with addr:*", "{0.key}");
|
---|
233 | }
|
---|
234 | *[!highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
|
---|
235 | throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
|
---|
236 | }
|
---|
237 | *[!highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
|
---|
238 | throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
|
---|
239 | }
|
---|
240 | way[highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
|
---|
241 | throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
|
---|
242 | fixRemove: "addr:postcode";
|
---|
243 | }
|
---|
244 | way[highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
|
---|
245 | throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
|
---|
246 | }
|
---|
247 | way[highway][!postal_code]["addr:postcode"] {
|
---|
248 | throwWarning: tr("{0} together with {1}", "{0.key}", "{2.key}");
|
---|
249 | suggestAlternative: "postal_code";
|
---|
250 | fixChangeKey: "addr:postcode=>postal_code";
|
---|
251 | }
|
---|
252 |
|
---|
253 | /* see #9195 */
|
---|
254 | *[highway=footway][cycleway=lane] {
|
---|
255 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
---|
256 | suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes";
|
---|
257 | }
|
---|
258 |
|
---|
259 | /* {0} on suspicious object */
|
---|
260 | *[tunnel ][!highway][!railway][!waterway][public_transport != platform][man_made != pipeline],
|
---|
261 | *[bridge ][!highway][!railway][!waterway][!piste:type][public_transport != platform][man_made !~ /^(bridge|pipeline)$/][building != bridge],
|
---|
262 | *[psv ][!highway][!railway][!waterway][amenity !~ /^parking.*/],
|
---|
263 | *[width ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance],
|
---|
264 | *[maxspeed][!highway][!railway][traffic_sign !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][type != enforcement][waterway !~ /^(river|canal|lock)$/][!traffic_calming],
|
---|
265 | *[lit ][!highway][!railway][!piste:type][!amenity][public_transport!=platform][advertising!=billboard][!leisure][!tourism] {
|
---|
266 | throwWarning: tr("{0} on suspicious object", "{0.key}");
|
---|
267 | }
|
---|
268 |
|
---|
269 | node[amenity =~ /^(restaurant|cafe|fast_food)$/][!name][noname!=yes] {
|
---|
270 | throwOther: tr("restaurant without name");
|
---|
271 | assertMatch: "node amenity=restaurant";
|
---|
272 | assertNoMatch: "node amenity=restaurant noname=yes";
|
---|
273 | assertNoMatch: "node amenity=restaurant name=Foobar";
|
---|
274 | }
|
---|
275 |
|
---|
276 | way[highway][barrier],
|
---|
277 | *[highway][waterway][waterway!=dam][waterway!=weir],
|
---|
278 | way[highway][natural],
|
---|
279 | *[landuse][building] {
|
---|
280 | throwWarning: tr("{0} used with {1}", "{0.key}", "{1.key}");
|
---|
281 | assertNoMatch: "node highway=street_lamp natural=birds_nest note=josm#10193";
|
---|
282 | }
|
---|
283 |
|
---|
284 | *[natural=water][leisure=swimming_pool],
|
---|
285 | *[natural=water][amenity=swimming_pool] {
|
---|
286 | /* see #6932 */
|
---|
287 | throwWarning: tr("natural water used for swimming pool");
|
---|
288 | fixRemove: "natural";
|
---|
289 | }
|
---|
290 |
|
---|
291 | /* see #9593, #11183, #12418 */
|
---|
292 | *[sport][!building][!club][tourism != hotel][highway != raceway][leisure !~ /^(sports_centre|stadium|track|pitch|golf_course|water_park|swimming_pool|recreation_ground|ice_rink)$/][natural !~ /^(beach|bare_rock|peak|water)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/][barrier !~ /^(wall|retaining_wall)$/][!"piste:type"][shop!=sports] {
|
---|
293 | throwWarning: tr("sport without physical feature");
|
---|
294 | assertMatch: "node sport=tennis";
|
---|
295 | assertNoMatch: "node sport=tennis leisure=pitch";
|
---|
296 | assertNoMatch: "node sport=beachvolleyball natural=beach";
|
---|
297 | assertNoMatch: "node sport=skiiing landuse=piste";
|
---|
298 | assertNoMatch: "node sport=swimming tourism=hotel";
|
---|
299 | assertNoMatch: "node sport=10pin amenity=restaurant";
|
---|
300 | }
|
---|
301 |
|
---|
302 | /* see #10140 */
|
---|
303 | *[building:levels][!building][!building:part] {
|
---|
304 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
|
---|
305 | }
|
---|
306 |
|
---|
307 | /* see #10471 */
|
---|
308 | way[waterway] > node[ford?] { set ford_on_waterway; }
|
---|
309 | way[highway] > node[ford?] { set ford_on_highway; }
|
---|
310 | node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
|
---|
311 | throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
|
---|
312 | }
|
---|
313 |
|
---|
314 | /* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 */
|
---|
315 | *[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] {
|
---|
316 | throwWarning: tr("alternative name without {0}", "{1.key}");
|
---|
317 | }
|
---|
318 |
|
---|
319 | /* see #10837 */
|
---|
320 | way[destination][!oneway?][junction!=roundabout][highway] {
|
---|
321 | throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}");
|
---|
322 | suggestAlternative: "destination:forward";
|
---|
323 | suggestAlternative: "destination:backward";
|
---|
324 | }
|
---|
325 |
|
---|
326 | /* see #11389 */
|
---|
327 | way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] {
|
---|
328 | throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");
|
---|
329 | suggestAlternative: "maxspeed";
|
---|
330 | fixChangeKey: "maxspeed:forward=>maxspeed";
|
---|
331 | fixRemove: "maxspeed:backward";
|
---|
332 | }
|
---|
333 | way["maxspeed:forward"=*maxspeed]["maxspeed:backward"=*maxspeed][maxspeed] {
|
---|
334 | throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}");
|
---|
335 | set AllSameMaxspeed;
|
---|
336 | suggestAlternative: "maxspeed";
|
---|
337 | fixRemove: "maxspeed:forward";
|
---|
338 | fixRemove: "maxspeed:backward";
|
---|
339 | }
|
---|
340 | way["maxspeed:forward"]["maxspeed:backward"][maxspeed]!.AllSameMaxspeed {
|
---|
341 | throwWarning: tr("{0} and {1} together with {2} and conflicting values", "{0.key}", "{1.key}", "{2.key}");
|
---|
342 | }
|
---|
343 | way["maxspeed:forward"][maxspeed][!"maxspeed:backward"],
|
---|
344 | way["maxspeed:backward"][maxspeed][!"maxspeed:forward"] {
|
---|
345 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
|
---|
346 | }
|
---|
347 |
|
---|
348 | /* see #11837 */
|
---|
349 | way[layer][layer<0][bridge][bridge!=no][location!=underground][indoor!=yes][!tunnel],
|
---|
350 | way[layer][layer>0][tunnel][tunnel!=no][location!=overground][indoor!=yes][!bridge] {
|
---|
351 | throwWarning: tr("Suspicious tag combination: {0} and {1}", "{2.tag}", "{0.tag}");
|
---|
352 | }
|
---|