1 | /* Rules partially derived from Taginfo statistics - see ticket #5017 |
---|
2 | * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000; |
---|
3 | */ |
---|
4 | |
---|
5 | way[surface=~/^(unpaved|compacted|gravel|fine_gravel|pebblestone|ground|earth|dirt|grass|sand|mud|ice|salt|snow|woodchips)$/] { /* without grass_paver as it is controversial */ |
---|
6 | set unpaved_surface; |
---|
7 | } |
---|
8 | |
---|
9 | /* {0.key} without {1.key} (warning level) */ |
---|
10 | way[junction ][!highway][junction!=yes], |
---|
11 | way[lanes ][!highway][leisure!=track][leisure!=swimming_pool], |
---|
12 | way[living_street ][!highway], |
---|
13 | way[maintenance ][!highway], |
---|
14 | way[median ][!highway], |
---|
15 | way[motorroad ][!highway], |
---|
16 | node[ntd_id ][!highway], |
---|
17 | way[sac_scale ][!highway], |
---|
18 | way[sidewalk ][!highway], |
---|
19 | way[step_count ][!highway][man_made!=tower], |
---|
20 | way[tracktype ][!highway], |
---|
21 | way[trail_visibility ][!highway], /* #15029 */ |
---|
22 | way[trolley_wire ][!highway], |
---|
23 | way[zip_left ][!highway], |
---|
24 | way[zip_right ][!highway], |
---|
25 | way[detail ][!railway][route!=railway], |
---|
26 | way[eddy_current_brake ][!railway][route!=railway], |
---|
27 | way[electrified ][!railway][route!=railway][!highway], /* #16007 */ |
---|
28 | way[etcs ][!railway][route!=railway], |
---|
29 | way[gauge ][!railway][route!=railway], |
---|
30 | way[grade_of_track ][!railway][route!=railway], |
---|
31 | way[kursbuchstrecke ][!railway][route!=railway], |
---|
32 | way[lzb ][!railway][route!=railway], |
---|
33 | way[old_railway_operator ][!railway][route!=railway], |
---|
34 | way[operating_procedure ][!railway][route!=railway], |
---|
35 | way[pzb ][!railway][route!=railway], |
---|
36 | way[structure_gauge ][!railway][route!=railway], |
---|
37 | way[tilting_technology ][!railway][route!=railway], |
---|
38 | way[track_class ][!railway][route!=railway], |
---|
39 | way[tracks ][!railway][route!=railway], |
---|
40 | way[traffic_mode ][!railway][route!=railway], |
---|
41 | way[workrules ][!railway][route!=railway], |
---|
42 | way[stream ][!waterway], |
---|
43 | way[length_unit ][!waterway], |
---|
44 | way[canal ][!waterway], |
---|
45 | way[have_riverbank ][!waterway], |
---|
46 | *[border_type ][!boundary], |
---|
47 | *[piste:difficulty ][!piste:type], |
---|
48 | *[place ][!name][place!=islet], |
---|
49 | *[transformer ][!power], |
---|
50 | *[source:date ][!source], |
---|
51 | *[source:name ][!name], |
---|
52 | *[source:maxspeed:forward ][!maxspeed:forward][!maxspeed], |
---|
53 | *[source:maxspeed:backward ][!maxspeed:backward][!maxspeed], |
---|
54 | *[source:building ][!building], |
---|
55 | *[source:ref ][!ref], |
---|
56 | *[source:population ][!population], |
---|
57 | *[source:postal_code ][!postal_code], |
---|
58 | *[source:ele ][!ele], |
---|
59 | *[source:ref:INSEE ][!ref:INSEE], |
---|
60 | *[source:lit ][!lit], |
---|
61 | *[source:hgv ][!hgv], |
---|
62 | *[source:highway ][!highway], |
---|
63 | *[source:maxaxleload ][!maxaxleload], |
---|
64 | *[source:surface ][!surface], |
---|
65 | *[source:bridge ][!bridge], |
---|
66 | *[source:old_name ][!old_name], |
---|
67 | *[source:bicycle ][!bicycle], |
---|
68 | *[source:designation ][!designation], |
---|
69 | *[source:height ][!height], |
---|
70 | *[source:lanes ][!lanes], |
---|
71 | *[source:postcode ][!addr:postcode], |
---|
72 | *[source:housenumber ][!addr:housenumber], |
---|
73 | *[source:addr:postcode ][!addr:postcode], |
---|
74 | *[source:addr:housenumber ][!addr:housenumber], |
---|
75 | *[source:addr ][!/^addr:/], |
---|
76 | *[source:maxspeed ][!/^maxspeed:?/] { |
---|
77 | throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}"); |
---|
78 | group: tr("missing tag"); |
---|
79 | assertMatch: "way lanes=42"; |
---|
80 | assertNoMatch: "way lanes=42 highway=unclassified"; |
---|
81 | assertMatch: "node source:addr:postcode=postman"; |
---|
82 | assertMatch: "node source:addr=postman"; |
---|
83 | assertNoMatch: "node source:addr=postman addr:housenumber=42"; |
---|
84 | } |
---|
85 | |
---|
86 | /* {0.key} without {1.key} (info level) */ |
---|
87 | way[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1], |
---|
88 | way[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1], |
---|
89 | *[leaf_type ][!leaf_cycle], |
---|
90 | *[leaf_cycle][!leaf_type] { |
---|
91 | throwOther: tr("{0} without {1}", "{0.key}", "{1.key}"); |
---|
92 | group: tr("missing tag"); |
---|
93 | } |
---|
94 | |
---|
95 | /* {0.key} without {1.tag}, #17997 */ |
---|
96 | node[railway:switch ][railway!=switch], |
---|
97 | *[generator:source ][power!=generator], |
---|
98 | *[generator:method ][power!=generator], |
---|
99 | *[generator:type ][power!=generator], |
---|
100 | node[fire_hydrant:type ][emergency!=fire_hydrant][disused:emergency!=fire_hydrant], |
---|
101 | node[manhole ][man_made!=manhole], |
---|
102 | way[fence_type ][barrier!=fence], |
---|
103 | *[recycling_type ][amenity!=recycling], |
---|
104 | *[information ][tourism!=information], |
---|
105 | node[board_type ][information!=board], |
---|
106 | *[shelter_type ][amenity!=shelter], |
---|
107 | node[lamp_type ][highway!=street_lamp], |
---|
108 | node[map_type ][information!=map], |
---|
109 | *[site_type ][historic!=archaeological_site], |
---|
110 | *[artwork_type ][tourism!=artwork][exhibit!=artwork], |
---|
111 | *[castle_type ][historic!=castle], |
---|
112 | *[parking ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/], |
---|
113 | way[cutline ][man_made!=cutline], |
---|
114 | *[bunker_type ][military!=bunker] { |
---|
115 | throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}"); |
---|
116 | group: tr("missing tag"); |
---|
117 | } |
---|
118 | |
---|
119 | /* {0.key} without {1.tag} or {2.tag}, #15107 */ |
---|
120 | *[iata ][aeroway!=aerodrome][aeroway!=helipad], |
---|
121 | *[icao ][aeroway!=aerodrome][aeroway!=helipad], |
---|
122 | *[bridge:movable ][bridge!=movable][man_made!=bridge], |
---|
123 | *[substation ][power!=substation][pipeline!=substation], |
---|
124 | *[reservoir_type ][landuse!=reservoir][water!=reservoir], |
---|
125 | way[waterway=pressurised ][tunnel!=flooded][man_made!=pipeline] { |
---|
126 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.tag}", "{2.tag}"); |
---|
127 | group: tr("missing tag"); |
---|
128 | } |
---|
129 | |
---|
130 | /* {0.tag} without {1.key} (warning level) */ |
---|
131 | node[traffic_sign=maxspeed][!maxspeed], |
---|
132 | node[actuator=manual][!handle], |
---|
133 | node[emergency=fire_hydrant][!fire_hydrant:type], |
---|
134 | way[ boundary=administrative][!admin_level], |
---|
135 | relation[boundary=administrative][!admin_level], |
---|
136 | relation[route=bicycle ][!network][type=route], |
---|
137 | relation[route=hiking ][!network][type=route], |
---|
138 | relation[route=foot ][!network][type=route], |
---|
139 | relation[route=horse ][!network][type=route], |
---|
140 | relation[route=piste][!piste:type][type=route], |
---|
141 | relation[route=ski ][!piste:type][type=route], |
---|
142 | *[tourism=information][!information], |
---|
143 | *[leisure=pitch][!sport], |
---|
144 | *[aeroway=terminal][!building], |
---|
145 | *[power=generator][!generator:source], |
---|
146 | *[amenity=recycling][!/^recycling:/], |
---|
147 | *[amenity=social_facility][!social_facility], |
---|
148 | *[amenity=place_of_worship][!religion] { |
---|
149 | throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}"); |
---|
150 | group: tr("missing tag"); |
---|
151 | } |
---|
152 | |
---|
153 | /* {0.tag} without {1.key} (info level), #15107 */ |
---|
154 | *[aeroway=runway ][!ref], |
---|
155 | *[aeroway=runway ][!surface], |
---|
156 | way[highway=track ][!tracktype], |
---|
157 | way[power=cable ][!location], |
---|
158 | node[power=transformer ][!voltage:primary], |
---|
159 | node[power=transformer ][!voltage:secondary], |
---|
160 | node[transformer=distribution ][!voltage:primary][power=pole], |
---|
161 | node[transformer=distribution ][!voltage:secondary][power=pole], |
---|
162 | way[power=line ][!voltage], |
---|
163 | way[power=minor_line ][!voltage], |
---|
164 | way[power=cable ][!voltage], |
---|
165 | *[power=generator ][!voltage][generator:output:electricity], |
---|
166 | *[power=plant ][!voltage][plant:output:electricity], |
---|
167 | *[power=substation ][!substation], |
---|
168 | *[power=switch ][!switch], |
---|
169 | *[power=transformer ][!transformer], |
---|
170 | *[amenity=bank ][!operator], |
---|
171 | *[amenity=cinema ][!operator], |
---|
172 | *[amenity=fast_food ][!operator], |
---|
173 | *[amenity=fuel ][!operator], |
---|
174 | *[mountain_pass=yes ][!ele], |
---|
175 | *[natural=peak ][!ele], |
---|
176 | *[amenity=place_of_worship ][!denomination], |
---|
177 | *[amenity=parking ][!parking], |
---|
178 | *[amenity=parking_entrance ][!parking] { |
---|
179 | throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}"); |
---|
180 | group: tr("missing tag"); |
---|
181 | assertMatch: "way power=line"; |
---|
182 | assertNoMatch: "way power=line voltage=1"; |
---|
183 | assertMatch: "way power=switch"; |
---|
184 | assertMatch: "way power=substation"; |
---|
185 | assertMatch: "way power=substation transformer=foobar"; |
---|
186 | assertNoMatch: "way power=substation substation=foobar"; |
---|
187 | assertMatch: "way power=generator generator:output:electricity=yes"; |
---|
188 | assertNoMatch: "way power=generator"; |
---|
189 | assertNoMatch: "way power=generator generator:output:electricity=yes voltage=1"; |
---|
190 | } |
---|
191 | |
---|
192 | /* {0.key} without {1.key} or {2.tag} */ |
---|
193 | way[bridge:structure ][!bridge][man_made!=bridge], |
---|
194 | *[smoothness ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking)$/], |
---|
195 | *[segregated ][!highway][railway!=crossing] { |
---|
196 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}"); |
---|
197 | group: tr("missing tag"); |
---|
198 | } |
---|
199 | |
---|
200 | /* {0.tag} without {1.tag} (info level) see #11600 #11393 #11850 */ |
---|
201 | way[highway=motorway][!oneway][junction!=roundabout], |
---|
202 | way[highway=motorway_link][!oneway][junction!=roundabout] { |
---|
203 | throwOther: tr("{0} without {1}", "{0.tag}", "{1.tag}"); |
---|
204 | group: tr("missing tag"); |
---|
205 | } |
---|
206 | |
---|
207 | /* {0.tag} without {1.tag} */ |
---|
208 | way[usage=penstock][man_made!=pipeline], |
---|
209 | way[usage=penstock][waterway!=pressurised] { |
---|
210 | throwWarning: tr("{0} without {1}", "{0.tag}", "{1.tag}"); |
---|
211 | group: tr("missing tag"); |
---|
212 | } |
---|
213 | |
---|
214 | /* {0.tag} without {1.tag} or {2.tag} */ |
---|
215 | *[amenity=recycling][recycling_type!=container][recycling_type!=centre] { |
---|
216 | throwWarning: tr("{0} without {1} or {2}", "{0.tag}", "{1.tag}", "{2.tag}"); |
---|
217 | group: tr("missing tag"); |
---|
218 | } |
---|
219 | |
---|
220 | /* {0.key} without {1.key}, {2.tag} or {3.tag} */ |
---|
221 | *[intermittent ][!waterway][natural!~/^(water|spring)$/][landuse!~/^(basin|reservoir)$/][ford!=yes], |
---|
222 | *[boat ][!waterway][natural!=water ][landuse!~/^(basin|reservoir)$/][ford!=yes] { |
---|
223 | throwWarning: tr("{0} without {1}, {2}, {3} or {4}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}", "{4.tag}"); |
---|
224 | group: tr("missing tag"); |
---|
225 | } |
---|
226 | |
---|
227 | /* {0.key} without {1.key}, {2.key} or {3.key}, #17253 */ |
---|
228 | way[oneway ][!highway][!railway][!aerialway][attraction!=summer_toboggan][aeroway!~/^(runway|taxiway)$/], |
---|
229 | *[snowplowing][!highway][!amenity][!leisure] { |
---|
230 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}"); |
---|
231 | group: tr("missing tag"); |
---|
232 | } |
---|
233 | |
---|
234 | /* {0.key} without {1.key}, {2.key} or {3.tag}, #17255 */ |
---|
235 | way[incline ][!highway][!railway][aeroway!~/^(runway|taxiway)$/][attraction!=summer_toboggan], |
---|
236 | *[toll ][!highway][!barrier][route!~/^(ferry|road)$/] { |
---|
237 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}"); |
---|
238 | group: tr("missing tag"); |
---|
239 | } |
---|
240 | |
---|
241 | /* {0.tag} together with {1.key}, see #17664, #17707, #16464, #10837, #14034, #9389, #11977, #13156, #16888 */ |
---|
242 | *[power=plant][/^generator:/], |
---|
243 | *[power=generator][/^plant:/], |
---|
244 | *[power=plant][voltage], |
---|
245 | *[power=plant][frequency], |
---|
246 | *[internet_access=no][internet_access:fee], |
---|
247 | node[power=transformer][voltage], |
---|
248 | node[transformer=distribution][voltage][power=pole], |
---|
249 | *[amenity=vending_machine][shop], |
---|
250 | *[noname?][name], |
---|
251 | way[oneway=yes][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath][oneway:bicycle!=no][oneway:psv!=no], |
---|
252 | way[oneway=yes][/:forward/ ][!traffic_sign:forward ][bicycle:forward!=use_sidepath ][oneway:bicycle!=no][oneway:psv!=no], |
---|
253 | way[oneway=-1 ][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath][oneway:bicycle!=no][oneway:psv!=no], |
---|
254 | way[oneway=-1 ][/:forward/ ][!traffic_sign:forward ][bicycle:forward!=use_sidepath ][oneway:bicycle!=no][oneway:psv!=no] { |
---|
255 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}"); |
---|
256 | group: tr("suspicious tag combination"); |
---|
257 | assertMatch: "way power=plant generator:source=wind"; |
---|
258 | assertMatch: "way power=generator plant:source=combustion"; |
---|
259 | } |
---|
260 | |
---|
261 | /* {0.tag} together with {1.tag} (info level), see #9696 */ |
---|
262 | way[highway=footway][oneway=no] { |
---|
263 | throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
264 | group: tr("suspicious tag combination"); |
---|
265 | } |
---|
266 | |
---|
267 | /* {0.tag} together with {1.tag}, see #17950, #17330, #17623, #17592, #17594, #17542, #16861, #16147, #10186 */ |
---|
268 | *[amenity=police][police], |
---|
269 | node[highway=crossing][crossing=no], |
---|
270 | node[railway=crossing][crossing=no], |
---|
271 | way[junction=yes][highway], |
---|
272 | way[tracktype=grade1][surface].unpaved_surface, |
---|
273 | way[tracktype=grade2][surface][surface=~/^(sand|mud)$/], |
---|
274 | way[segregated][bicycle=no], |
---|
275 | way[segregated][foot=no], |
---|
276 | way[man_made=pipeline][tunnel=flooded], |
---|
277 | way[waterway=canal][tunnel=yes] { |
---|
278 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
279 | group: tr("suspicious tag combination"); |
---|
280 | } |
---|
281 | |
---|
282 | /* {0.tag} together with {1.tag} (error level) */ |
---|
283 | relation[type=multipolygon][area=no] { |
---|
284 | throwError: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
285 | group: tr("suspicious tag combination"); |
---|
286 | } |
---|
287 | |
---|
288 | /* {0.key} together with {1.key}, #17630, #17604 */ |
---|
289 | *[building:part][building], |
---|
290 | *[addr:street][addr:place][outside("CZ,DK")] { |
---|
291 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}"); |
---|
292 | group: tr("suspicious tag combination"); |
---|
293 | } |
---|
294 | |
---|
295 | /* #11127, #13727 */ |
---|
296 | way[waterway][bridge=yes][waterway!=weir] { |
---|
297 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}"); |
---|
298 | suggestAlternative: "bridge=aqueduct"; |
---|
299 | group: tr("suspicious tag combination"); |
---|
300 | fixAdd: "bridge=aqueduct"; |
---|
301 | } |
---|
302 | way[waterway=weir][bridge=yes][highway] { |
---|
303 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
304 | suggestAlternative: "waterway=weir + ford=yes"; |
---|
305 | suggestAlternative: "waterway=dam"; |
---|
306 | suggestAlternative: tr("two objects, one with {0} and one with {1} + {2} + {3}", "{0.tag}", "{2.key}", "{1.tag}", "layer"); |
---|
307 | group: tr("suspicious tag combination"); |
---|
308 | } |
---|
309 | |
---|
310 | /* #16214 */ |
---|
311 | relation[type=multipolygon] >[role="inner"] way[area][eval(number_of_tags()) = 1] { |
---|
312 | throwWarning: tr("{0} on an inner multipolygon ring without further tags", "{0.tag}"); |
---|
313 | fixRemove: "area"; |
---|
314 | set area_yes_autofix; |
---|
315 | group: tr("suspicious tag combination"); |
---|
316 | } |
---|
317 | |
---|
318 | /* only {0.key}, see #11104 #12422 #14950 */ |
---|
319 | *[access][eval(number_of_tags()) = 1], |
---|
320 | *[area][eval(number_of_tags()) = 1]!.area_yes_autofix, |
---|
321 | *[name][eval(number_of_tags()) = 1], |
---|
322 | *[ref][eval(number_of_tags()) = 1], |
---|
323 | *[lit][eval(number_of_tags()) = 1] { |
---|
324 | throwWarning: tr("incomplete object: only {0}", "{0.key}"); |
---|
325 | group: tr("missing tag"); |
---|
326 | } |
---|
327 | /* only {0.key} and {1.key} */ |
---|
328 | *[name][area][eval(number_of_tags()) = 2], |
---|
329 | *[name][ref][eval(number_of_tags()) = 2] { |
---|
330 | throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}"); |
---|
331 | group: tr("missing tag"); |
---|
332 | } |
---|
333 | /* only {0.tag}, #15269 */ |
---|
334 | *[tourism=attraction][eval(number_of_tags()) = 1] { |
---|
335 | throwWarning: tr("incomplete object: only {0}", "{0.tag}"); |
---|
336 | group: tr("missing tag"); |
---|
337 | } |
---|
338 | /* only {0.key} and {1.tag} */ |
---|
339 | *[name][tourism=attraction][eval(number_of_tags()) = 2] { |
---|
340 | throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.tag}"); |
---|
341 | group: tr("missing tag"); |
---|
342 | } |
---|
343 | |
---|
344 | /* #9811, #11491, #12865, #14310 */ |
---|
345 | *[place][place!=farm][/^(addr:housenumber|addr:housename|addr:flats|addr:conscriptionnumber|addr:street|addr:place|addr:city|addr:country|addr:full|addr:hamlet|addr:suburb|addr:subdistrict|addr:district|addr:province|addr:state|addr:interpolation|addr:interpolation|addr:inclusion)$/], |
---|
346 | /* addr:postcode is used together with place in some countries */ |
---|
347 | *[boundary][/^addr:/], |
---|
348 | *[highway][/^addr:/][highway!=services][highway!=rest_area][!"addr:postcode"] { |
---|
349 | throwWarning: tr("{0} together with addr:*", "{0.key}"); |
---|
350 | group: tr("suspicious tag combination"); |
---|
351 | assertMatch: "node place=foo addr:housenumber=5"; |
---|
352 | assertMatch: "node place=foo addr:housenumber=5 addr:postcode=12345"; |
---|
353 | assertNoMatch: "node place=foo addr:postcode=12345"; |
---|
354 | } |
---|
355 | *[!highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] { |
---|
356 | throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}"); |
---|
357 | group: tr("suspicious tag combination"); |
---|
358 | } |
---|
359 | *[!highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] { |
---|
360 | throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}"); |
---|
361 | group: tr("suspicious tag combination"); |
---|
362 | } |
---|
363 | way[highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] { |
---|
364 | throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}"); |
---|
365 | group: tr("suspicious tag combination"); |
---|
366 | fixRemove: "addr:postcode"; |
---|
367 | } |
---|
368 | way[highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] { |
---|
369 | throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}"); |
---|
370 | group: tr("suspicious tag combination"); |
---|
371 | } |
---|
372 | way[highway][highway!=services][highway!=rest_area][!postal_code]["addr:postcode"] { |
---|
373 | throwWarning: tr("{0} together with {1}", "{0.key}", "{4.key}"); |
---|
374 | suggestAlternative: "postal_code"; |
---|
375 | group: tr("suspicious tag combination"); |
---|
376 | fixChangeKey: "addr:postcode=>postal_code"; |
---|
377 | } |
---|
378 | |
---|
379 | /* #9195 */ |
---|
380 | way[highway=footway][cycleway=lane] { |
---|
381 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
382 | suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes"; |
---|
383 | group: tr("suspicious tag combination"); |
---|
384 | } |
---|
385 | |
---|
386 | /* {0} on suspicious object */ |
---|
387 | *[tunnel ][!highway][!railway][!waterway][!piste:type][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing], |
---|
388 | *[bridge ][!highway][!railway][!waterway][!piste:type][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing][man_made!=bridge][building!=bridge], |
---|
389 | *[psv ][!highway][!railway][!waterway][barrier!=bollard][amenity !~ /^parking.*/], |
---|
390 | *[width ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance][natural!=stone][leisure!=track], |
---|
391 | *[maxspeed][!highway][!railway][traffic_sign !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][traffic_sign:forward !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][traffic_sign:backward !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][type != enforcement][waterway !~ /^(river|canal|lock)$/][!traffic_calming][aerialway!=zip_line] { |
---|
392 | throwWarning: tr("{0} on suspicious object", "{0.key}"); |
---|
393 | group: tr("suspicious tag combination"); |
---|
394 | } |
---|
395 | |
---|
396 | *[amenity][amenity =~ /^(restaurant|cafe|fast_food|pub|place_of_worship|school|university|hospital|library|theatre|courthouse|bank|cinema|pharmacy|fuel)$/][!name][noname!=yes] { |
---|
397 | throwOther: tr("{0} without {1}", "{0.tag}", "{2.key}"); |
---|
398 | group: tr("missing tag"); |
---|
399 | assertMatch: "node amenity=restaurant"; |
---|
400 | assertNoMatch: "node amenity=restaurant noname=yes"; |
---|
401 | assertNoMatch: "node amenity=restaurant name=Foobar"; |
---|
402 | } |
---|
403 | |
---|
404 | /* #10193, #16157 */ |
---|
405 | way[highway][barrier], |
---|
406 | *[highway][waterway][waterway!=dam][waterway!=weir], |
---|
407 | way[highway][natural][natural!=ridge], |
---|
408 | *[landuse][building][landuse!=retail] { |
---|
409 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}"); |
---|
410 | group: tr("suspicious tag combination"); |
---|
411 | assertNoMatch: "node highway=street_lamp natural=birds_nest"; |
---|
412 | } |
---|
413 | |
---|
414 | /* #6932 */ |
---|
415 | *[natural=water][leisure=swimming_pool] { |
---|
416 | throwWarning: tr("natural water used for swimming pool"); |
---|
417 | group: tr("suspicious tag combination"); |
---|
418 | fixRemove: "natural"; |
---|
419 | } |
---|
420 | |
---|
421 | /* #9593, #11183, #12418, #12761, #17254 */ |
---|
422 | *[sport][sport!=skiing][!building][!club][tourism != hotel][highway != raceway][!leisure][natural !~ /^(beach|bare_rock|cliff|peak|water)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/][barrier !~ /^(wall|retaining_wall)$/][!"piste:type"][shop!=sports][attraction!=summer_toboggan] { |
---|
423 | throwWarning: tr("sport without physical feature"); |
---|
424 | group: tr("missing tag"); |
---|
425 | assertMatch: "node sport=tennis"; |
---|
426 | assertNoMatch: "node sport=tennis leisure=pitch"; |
---|
427 | assertNoMatch: "node sport=beachvolleyball natural=beach"; |
---|
428 | assertNoMatch: "node sport=skiing"; /* skiing has deprecated warning */ |
---|
429 | assertNoMatch: "node sport=swimming tourism=hotel"; |
---|
430 | assertNoMatch: "node sport=10pin amenity=restaurant"; |
---|
431 | } |
---|
432 | |
---|
433 | /* {0.key} without {1.key} or {2.key} see #10140 */ |
---|
434 | *[building:levels][!building][!building:part], |
---|
435 | way[usage][!railway][!waterway][route!=railway][man_made!=pipeline] { |
---|
436 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}"); |
---|
437 | group: tr("missing tag"); |
---|
438 | } |
---|
439 | |
---|
440 | /* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 #16437 */ |
---|
441 | *[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!lock_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] { |
---|
442 | throwWarning: tr("alternative name without {0}", "{1.key}"); |
---|
443 | group: tr("missing tag"); |
---|
444 | } |
---|
445 | |
---|
446 | /* #10837 */ |
---|
447 | way[destination][!oneway?][junction!=roundabout][highway] { |
---|
448 | throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}"); |
---|
449 | suggestAlternative: "destination:forward"; |
---|
450 | suggestAlternative: "destination:backward"; |
---|
451 | } |
---|
452 | |
---|
453 | /* #11389 */ |
---|
454 | way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] { |
---|
455 | throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}"); |
---|
456 | suggestAlternative: "maxspeed"; |
---|
457 | group: tr("suspicious tag combination"); |
---|
458 | fixChangeKey: "maxspeed:forward=>maxspeed"; |
---|
459 | fixRemove: "maxspeed:backward"; |
---|
460 | } |
---|
461 | way["maxspeed:forward"=*maxspeed]["maxspeed:backward"=*maxspeed][maxspeed] { |
---|
462 | throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}"); |
---|
463 | set AllSameMaxspeed; |
---|
464 | suggestAlternative: "maxspeed"; |
---|
465 | group: tr("suspicious tag combination"); |
---|
466 | fixRemove: "maxspeed:forward"; |
---|
467 | fixRemove: "maxspeed:backward"; |
---|
468 | } |
---|
469 | way["maxspeed:forward"]["maxspeed:backward"][maxspeed]!.AllSameMaxspeed { |
---|
470 | throwWarning: tr("{0} and {1} together with {2} and conflicting values", "{0.key}", "{1.key}", "{2.key}"); |
---|
471 | group: tr("suspicious tag combination"); |
---|
472 | } |
---|
473 | way["maxspeed:forward"][maxspeed][!"maxspeed:backward"], |
---|
474 | way["maxspeed:backward"][maxspeed][!"maxspeed:forward"] { |
---|
475 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}"); |
---|
476 | group: tr("suspicious tag combination"); |
---|
477 | } |
---|
478 | |
---|
479 | /* #11837 */ |
---|
480 | way[layer][layer<0][bridge][bridge!=no][location!=underground][indoor!=yes][!tunnel], |
---|
481 | way[layer][layer>0][tunnel][tunnel!=no][location!=overground][indoor!=yes][!bridge] { |
---|
482 | throwWarning: tr("{0} together with {1}", "{2.tag}", "{0.tag}"); |
---|
483 | group: tr("suspicious tag combination"); |
---|
484 | } |
---|
485 | |
---|
486 | /* #12942 */ |
---|
487 | relation[oneway][type!=route] { |
---|
488 | throwWarning: tr("{0} on a relation without {1}", "{0.key}", "{1.tag}"); |
---|
489 | } |
---|
490 | |
---|
491 | /* #9182 */ |
---|
492 | way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) > 400] { |
---|
493 | throwWarning: tr("Long waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}"); |
---|
494 | group: tr("suspicious tag combination"); |
---|
495 | } |
---|
496 | way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) <= 400] { |
---|
497 | throwOther: tr("Short waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}"); |
---|
498 | group: tr("suspicious tag combination"); |
---|
499 | } |
---|
500 | |
---|
501 | /* #13144, #15536 */ |
---|
502 | *[unisex=yes][female=yes][male!=yes][shop=hairdresser], |
---|
503 | *[unisex=yes][male=yes][female!=yes][shop=hairdresser] { |
---|
504 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
505 | group: tr("suspicious tag combination"); |
---|
506 | } |
---|
507 | *[unisex=yes][female=yes][male=yes][shop=hairdresser] { |
---|
508 | throwWarning: tr("{0} together with {1} and {2}. Remove {1} and {2}", "{0.tag}", "{1.tag}", "{2.tag}"); |
---|
509 | group: tr("suspicious tag combination"); |
---|
510 | fixRemove: "female"; |
---|
511 | fixRemove: "male"; |
---|
512 | } |
---|
513 | *[female=yes][male=yes][!unisex][shop=hairdresser] { |
---|
514 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
515 | suggestAlternative: "unisex=yes"; |
---|
516 | group: tr("suspicious tag combination"); |
---|
517 | fixRemove: "female"; |
---|
518 | fixRemove: "male"; |
---|
519 | fixAdd: "unisex=yes"; |
---|
520 | } |
---|
521 | |
---|
522 | /* {1.key} without {2.tag} see #13138, #14468 */ |
---|
523 | way!:closed[water][natural!~/water|bay|strait/][water!=intermittent][amenity!=lavoir], /* water=intermittent is deprecated and has an own warning */ |
---|
524 | area:closed[water][natural!~/water|bay|strait/][water!=intermittent][amenity!=lavoir] { |
---|
525 | throwWarning: tr("{0} without {1}", "{1.key}", "{2.tag}"); |
---|
526 | group: tr("missing tag"); |
---|
527 | } |
---|
528 | |
---|
529 | /* see #8519, #11529, limited to motorways and trunks to avoid false positives for streets with lanes for non motorized traffic */ |
---|
530 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][turn:lanes ][tag(lanes)!=eval(count(split("|", tag("turn:lanes"))))], |
---|
531 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][change:lanes ][tag(lanes)!=eval(count(split("|", tag("change:lanes"))))], |
---|
532 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][maxspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("maxspeed:lanes"))))], |
---|
533 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][minspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("minspeed:lanes"))))], |
---|
534 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:lanes"))))], |
---|
535 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:ref:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:ref:lanes"))))], |
---|
536 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:symbol:lanes][tag(lanes)!=eval(count(split("|", tag("destination:symbol:lanes"))))] { |
---|
537 | throwWarning: tr("Different number of lanes in the keys {0} and {1}", "{1.key}", "{2.key}"); |
---|
538 | group: tr("suspicious tag combination"); |
---|
539 | } |
---|
540 | |
---|
541 | /* #13680 */ |
---|
542 | area[golf=bunker][natural=beach] { |
---|
543 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
544 | suggestAlternative: "natural=sand"; |
---|
545 | suggestAlternative: "surface=sand"; |
---|
546 | group: tr("suspicious tag combination"); |
---|
547 | } |
---|
548 | |
---|
549 | /* #13705 */ |
---|
550 | relation[type=multipolygon][building] > way { |
---|
551 | set part_of_building_MP; |
---|
552 | } |
---|
553 | way["addr:housenumber"][!building][!"building:part"][!"demolished:building"][!note][!amenity][!leisure][!landuse][!man_made][!tourism][!barrier]!.part_of_building_MP { |
---|
554 | /* don't exclude shop because a lot of real missing bulding tag cases have a shop tag. */ |
---|
555 | throwOther: tr("possibly missing {0} tag", "{1.key}"); |
---|
556 | group: tr("missing tag"); |
---|
557 | } |
---|
558 | |
---|
559 | /* #14125, #14323, #18185 */ |
---|
560 | way[highway][lanes][!lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1][oneway!=reversible][junction!=roundabout][lanes>2][get(split(".", tag(lanes)/2), 1)=5] { |
---|
561 | throwWarning: tr("street with odd number of {0}, but without {1} and {2} or {3}", "{1.key}", "{2.key}", "{3.key}", "{4.key}"); |
---|
562 | group: tr("missing tag"); |
---|
563 | assertNoMatch: "way highway=primary lanes=2"; |
---|
564 | assertNoMatch: "way highway=primary lanes=3 lanes:backward=2"; |
---|
565 | assertNoMatch: "way highway=primary lanes=3 oneway=-1"; |
---|
566 | assertNoMatch: "way highway=primary lanes=4"; |
---|
567 | assertMatch: "way highway=primary lanes=3"; |
---|
568 | } |
---|
569 | |
---|
570 | /* #15774 */ |
---|
571 | node[emergency=fire_hydrant][fire_hydrant:count][fire_hydrant:count!=1] { |
---|
572 | throwOther: tr("{0} together with {1}. Tag each hydrant separately.", "{0.tag}", "{1.tag}"); |
---|
573 | } |
---|
574 | |
---|
575 | /* #12502 */ |
---|
576 | node[leisure=park][natural=tree] { |
---|
577 | throwWarning: tr("{0} together with {1} on a node. Remove {0}.", "{0.tag}", "{1.tag}"); |
---|
578 | group: tr("suspicious tag combination"); |
---|
579 | fixRemove: "leisure"; |
---|
580 | } |
---|
581 | |
---|
582 | /* #17305 */ |
---|
583 | area[boundary=administrative][landuse=residential] { |
---|
584 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
585 | group: tr("suspicious tag combination"); |
---|
586 | } |
---|
587 | |
---|
588 | /* #17391 */ |
---|
589 | way[highway=pedestrian][width][width<3] { |
---|
590 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
591 | suggestAlternative: "highway=footway"; |
---|
592 | group: tr("suspicious tag combination"); |
---|
593 | fixAdd: "highway=footway"; |
---|
594 | assertMatch: "way highway=pedestrian width=0.8"; |
---|
595 | assertMatch: "way highway=pedestrian width=1"; |
---|
596 | assertNoMatch: "way highway=pedestrian width=3"; |
---|
597 | assertNoMatch: "way highway=pedestrian width=5.5"; |
---|
598 | } |
---|
599 | |
---|
600 | /* see #17623 */ |
---|
601 | way:areaStyle[highway][highway =~ /motorway|trunk|primary|secondary|tertiary|unclassified|residential|service$|living_street|pedestrian|track|path|footway|cycleway|bus_guideway|bridleway/][area!=yes] { |
---|
602 | throwOther: tr("A linear object {0} without {1} has a tag indicating that it is an area.", "{1.tag}", "{3.tag}"); |
---|
603 | group: tr("suspicious tag combination"); |
---|
604 | } |
---|
605 | |
---|
606 | /* #17804 */ |
---|
607 | area[cemetery=sector][landuse=cemetery] { |
---|
608 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}"); |
---|
609 | group: tr("suspicious tag combination"); |
---|
610 | } |
---|
611 | |
---|
612 | /* #17967 */ |
---|
613 | *[highway=cycleway][cycleway=track] { |
---|
614 | throwWarning: tr("{0} together with {1}. Remove {1}.", "{0.tag}", "{1.tag}"); |
---|
615 | group: tr("suspicious tag combination"); |
---|
616 | fixRemove: "cycleway"; |
---|
617 | } |
---|
618 | |
---|
619 | /* #17973, #18183 */ |
---|
620 | way[highway=path ][foot][foot!=no ][foot!=use_sidepath ][!segregated][bicycle][bicycle!=no][bicycle!=use_sidepath]!.unpaved_surface, |
---|
621 | way[highway=footway ][bicycle][bicycle!=no][bicycle!=use_sidepath][!segregated]!.unpaved_surface, |
---|
622 | way[highway=cycleway][foot][foot!=no ][foot!=use_sidepath ][!segregated]!.unpaved_surface { |
---|
623 | throwWarning: tr("Combined foot- and cycleway without {0}.", "{4.key}"); |
---|
624 | group: tr("missing tag"); |
---|
625 | } |
---|
626 | |
---|
627 | /* #17989 */ |
---|
628 | node[emergency_ward_entrance][emergency!=emergency_ward_entrance] { |
---|
629 | throwWarning: tr("{0} without {1}", "{0.tag}", "{1.tag}"); |
---|
630 | group: tr("missing tag"); |
---|
631 | fixAdd: "emergency=emergency_ward_entrance"; |
---|
632 | } |
---|
633 | |
---|
634 | /* #18203 */ |
---|
635 | way[construction][construction!=yes][highway][highway!=construction] { |
---|
636 | throwWarning: tr("{0} together with {1}", "{2.tag}", "{0.tag}"); |
---|
637 | group: tr("suspicious tag combination"); |
---|
638 | } |
---|