source: josm/trunk/data/validator/combinations.mapcss@ 11074

Last change on this file since 11074 was 11074, checked in by Klumbumbus, 8 years ago

fix #13727 - improve "waterway=weir together with bridge=yes" warning
  • Property svn:eol-style set to native
File size: 20.4 KB
Line 
1/* Rules partially derived from Taginfo statistics - see ticket #5017
2 * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000;
3 */
4
5/* {0.key} without {1.key} (warning level) */
6way[junction ][!highway][junction!=yes],
7*[lanes ][!highway],
8*[lcn ][!highway],
9*[living_street ][!highway],
10*[maintenance ][!highway],
11*[median ][!highway],
12*[motorroad ][!highway],
13*[ntd_id ][!highway],
14*[sac_scale ][!highway],
15*[sidewalk ][!highway],
16*[step_count ][!highway],
17*[tracktype ][!highway],
18*[trail_visibility ][!highway],
19*[trolley_wire ][!highway],
20*[zip_left ][!highway],
21*[zip_right ][!highway],
22*[detail ][!railway][route!=railway],
23*[eddy_current_brake ][!railway][route!=railway],
24*[electrified ][!railway][route!=railway],
25*[etcs ][!railway][route!=railway],
26*[gauge ][!railway][route!=railway],
27*[grade_of_track ][!railway][route!=railway],
28*[kursbuchstrecke ][!railway][route!=railway],
29*[lzb ][!railway][route!=railway],
30*[old_railway_operator ][!railway][route!=railway],
31*[operating_procedure ][!railway][route!=railway],
32*[pzb ][!railway][route!=railway],
33*[radio ][!railway][route!=railway],
34*[structure_gauge ][!railway][route!=railway],
35*[tilting_technology ][!railway][route!=railway],
36*[track_class ][!railway][route!=railway],
37*[tracks ][!railway][route!=railway],
38*[traffic_mode ][!railway][route!=railway],
39*[usage ][!railway][route!=railway][man_made!=pipeline],
40*[workrules ][!railway][route!=railway],
41*[stream ][!waterway],
42*[length_unit ][!waterway],
43*[llid ][!waterway],
44*[canal ][!waterway],
45*[have_riverbank ][!waterway],
46*[border_type ][!boundary],
47*[bridge:structure ][!bridge],
48*[piste:difficulty ][!piste:type],
49*[source:date ][!source],
50*[source:name ][!name],
51*[source:maxspeed:forward ][!maxspeed:forward],
52*[source:maxspeed:backward ][!maxspeed:backward],
53*[source:maxspeed:forward ][!source:maxspeed:backward],
54*[source:maxspeed:backward ][!source:maxspeed:forward],
55*[source:building ][!building],
56*[source:ref ][!ref],
57*[source:population ][!population],
58*[source:postal_code ][!postal_code],
59*[source:ele ][!ele],
60*[source:ref:INSEE ][!ref:INSEE],
61*[source:lit ][!lit],
62*[source:hgv ][!hgv],
63*[source:highway ][!highway],
64*[source:maxaxleload ][!maxaxleload],
65*[source:surface ][!surface],
66*[source:bridge ][!bridge],
67*[source:old_name ][!old_name],
68*[source:bicycle ][!bicycle],
69*[source:designation ][!designation],
70*[source:height ][!height],
71*[source:lanes ][!lanes],
72*[source:postcode ][!addr:postcode],
73*[source:housenumber ][!addr:housenumber],
74*[source:addr:postcode ][!addr:postcode],
75*[source:addr:housenumber ][!addr:housenumber],
76*[source:addr ][!/^addr:/],
77*[source:maxspeed ][!/^maxspeed:?/] {
78 throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
79 assertMatch: "way lanes=42";
80 assertNoMatch: "way lanes=42 highway=unclassified";
81 assertMatch: "node source:addr:postcode=postman";
82 assertMatch: "node source:addr=postman";
83 assertNoMatch: "node source:addr=postman addr:housenumber=42";
84}
85
86/* {0.key} without {1.key} (info level) */
87*[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1],
88*[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1],
89*[leaf_type ][!leaf_cycle],
90*[leaf_cycle][!leaf_type] {
91 throwOther: tr("{0} without {1}", "{0.key}", "{1.key}");
92}
93
94/* {0.key} without {1.tag} */
95*[transformer ][!power],
96*[fence_type ][barrier!=fence],
97*[recycling_type ][amenity!=recycling],
98*[information ][tourism!=information],
99*[board_type ][information!=board],
100*[shelter_type ][amenity!=shelter],
101*[lamp_type ][highway!=street_lamp],
102*[map_type ][information!=map],
103*[site_type ][historic!=archaeological_site],
104*[artwork_type ][tourism!=artwork],
105*[castle_type ][historic!=castle],
106*[bridge:movable ][bridge!=movable],
107*[parking ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
108*[cutline ][man_made!=cutline],
109*[bunker_type ][military!=bunker] {
110 throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
111}
112
113/* {0.key} without {1.tag} or {2.tag} */
114*[substation ][power!=substation][pipeline!=substation],
115*[reservoir_type ][landuse!=reservoir][water!=reservoir] {
116 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.tag}", "{2.tag}");
117}
118
119/* {0.tag} without {1.key} (warning level) */
120relation[route=bicycle][!network][type=route],
121relation[route=hiking][!network][type=route],
122relation[route=foot][!network][type=route],
123relation[route=horse][!network][type=route],
124relation[route=piste][!piste:type][type=route],
125relation[route=ski][!piste:type][type=route],
126*[tourism=information][!information],
127*[aeroway=terminal][!building],
128*[power=generator][!generator:source],
129*[amenity=place_of_worship][!religion] {
130 throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
131}
132
133/* {0.tag} without {1.key} (info level) */
134way[power=cable ][!location],
135node[power=transformer ][!voltage],
136way[power=line ][!voltage],
137way[power=minor_line ][!voltage],
138way[power=cable ][!voltage],
139*[power=generator ][!voltage][generator:output:electricity],
140*[power=plant ][!voltage][plant:output:electricity],
141*[power=substation ][!substation],
142*[power=transformer ][!transformer],
143*[amenity=parking ][!parking],
144*[amenity=parking_entrance ][!parking] {
145 throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}");
146 assertMatch: "way power=line";
147 assertNoMatch: "way power=line voltage=1";
148 assertNoMatch: "way power=switch";
149 assertMatch: "way power=substation";
150 assertMatch: "way power=substation transformer=foobar";
151 assertNoMatch: "way power=substation substation=foobar";
152 assertMatch: "way power=generator generator:output:electricity=yes";
153 assertNoMatch: "way power=generator";
154 assertNoMatch: "way power=generator generator:output:electricity=yes voltage=1";
155}
156
157/* {0.key} without {1.key} or {2.key} */
158way[oneway][!highway][!railway] {
159 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
160}
161
162/* {0.key} without {1.key} or {2.tag} */
163*[smoothness ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking)$/],
164*[segregated ][!highway][railway!=crossing] {
165 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}");
166}
167
168/* {0.tag} without {1.tag} (info level) see #11600 #11393 #11850 */
169*[highway=motorway][!oneway][junction!=roundabout],
170*[highway=motorway_link][!oneway][junction!=roundabout] {
171 throwOther: tr("{0} without {1}", "{0.tag}", "{1.tag}");
172}
173
174/* {0.tag} without {1.tag} or {2.tag} */
175*[amenity=recycling][recycling_type!=container][recycling_type!=centre] {
176 throwWarning: tr("{0} without {1} or {2}", "{0.tag}", "{1.tag}", "{2.tag}");
177}
178
179/* {0.key} without {1.key}, {2.tag} or {3.tag} */
180*[intermittent ][!waterway][natural!~/^(water|spring)$/][ford!=yes],
181*[boat ][!waterway][natural!=water][landuse!=basin] {
182 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}");
183}
184
185/* {0.key} without {1.key}, {2.key} or {3.key} */
186*[snowplowing ][!highway][!amenity][!leisure] {
187 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}");
188}
189
190/* {0.key} without {1.key}, {2.key} or {3.tag} */
191*[incline ][!highway][!railway][aeroway!~/^(runway|taxiway)$/],
192*[toll ][!highway][!barrier][route!~/^(ferry|road)$/] {
193 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}");
194}
195
196/* {0.tag} together with {1.key}, see #10837 */
197*[noname?][name] {
198 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
199}
200
201/* {0.tag} together with {1.key}, see #9389, #11977, #13156 */
202way[oneway=yes][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath],
203way[oneway=yes][/:forward/][!traffic_sign:forward][bicycle:forward!=use_sidepath],
204way[oneway=-1 ][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath],
205way[oneway=-1 ][/:forward/][!traffic_sign:forward][bicycle:forward!=use_sidepath] {
206 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
207}
208
209/* {0.tag} together with {1.tag} (info level), see #9696 */
210*[highway=footway][oneway=no] {
211 throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
212}
213
214/* {0.tag} together with {1.tag}, see #10186 */
215*[highway=footway][bicycle=designated] {
216 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
217}
218
219/* #11127, #13727 */
220way[waterway][bridge=yes][waterway!=weir] {
221 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}");
222 suggestAlternative: "bridge=aqueduct";
223 fixAdd: "bridge=aqueduct";
224}
225way[waterway=weir][bridge=yes][highway] {
226 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
227 suggestAlternative: "waterway=weir + ford=yes";
228 suggestAlternative: "waterway=dam";
229 suggestAlternative: tr("two objects, one with {0} and one with {1} + {2} + {3}", "{0.tag}", "{2.key}", "{1.tag}", "layer");
230}
231
232/* only {0.key}, see #11104 #12422 */
233*[area][eval(number_of_tags()) = 1],
234*[name][eval(number_of_tags()) = 1],
235*[ref][eval(number_of_tags()) = 1],
236*[lit][eval(number_of_tags()) = 1] {
237 throwWarning: tr("incomplete object: only {0}", "{0.key}");
238}
239/* only {0.key} and {1.key}, see #11104 */
240*[name][area][eval(number_of_tags()) = 2],
241*[name][ref][eval(number_of_tags()) = 2] {
242 throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}");
243}
244
245/* #9811, #11491, #12865 */
246*[place][place!=farm][/^addr:/],
247*[boundary][/^addr:/],
248*[highway][/^addr:/][highway!=services][highway!=rest_area][!"addr:postcode"] {
249 throwWarning: tr("{0} together with addr:*", "{0.key}");
250}
251*[!highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
252 throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
253}
254*[!highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
255 throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
256}
257way[highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
258 throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
259 fixRemove: "addr:postcode";
260}
261way[highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
262 throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
263}
264way[highway][highway!=services][highway!=rest_area][!postal_code]["addr:postcode"] {
265 throwWarning: tr("{0} together with {1}", "{0.key}", "{4.key}");
266 suggestAlternative: "postal_code";
267 fixChangeKey: "addr:postcode=>postal_code";
268}
269
270/* #9195 */
271*[highway=footway][cycleway=lane] {
272 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
273 suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes";
274}
275
276/* {0} on suspicious object */
277*[tunnel ][!highway][!railway][!waterway][public_transport != platform][man_made != pipeline],
278*[bridge ][!highway][!railway][!waterway][!piste:type][public_transport != platform][man_made !~ /^(bridge|pipeline)$/][building != bridge],
279*[psv ][!highway][!railway][!waterway][amenity !~ /^parking.*/],
280*[width ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance],
281*[maxspeed][!highway][!railway][traffic_sign !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][type != enforcement][waterway !~ /^(river|canal|lock)$/][!traffic_calming] {
282 throwWarning: tr("{0} on suspicious object", "{0.key}");
283}
284
285node[amenity =~ /^(restaurant|cafe|fast_food)$/][!name][noname!=yes] {
286 throwOther: tr("restaurant without name");
287 assertMatch: "node amenity=restaurant";
288 assertNoMatch: "node amenity=restaurant noname=yes";
289 assertNoMatch: "node amenity=restaurant name=Foobar";
290}
291
292way[highway][barrier],
293*[highway][waterway][waterway!=dam][waterway!=weir],
294way[highway][natural],
295*[landuse][building] {
296 throwWarning: tr("{0} used with {1}", "{0.key}", "{1.key}");
297 assertNoMatch: "node highway=street_lamp natural=birds_nest note=josm#10193";
298}
299
300/* #6932 */
301*[natural=water][leisure=swimming_pool] {
302 throwWarning: tr("natural water used for swimming pool");
303 fixRemove: "natural";
304}
305
306/* #9593, #11183, #12418, #12761 */
307*[sport][!building][!club][tourism != hotel][highway != raceway][leisure !~ /^(sports_centre|stadium|track|pitch|golf_course|water_park|swimming_pool|recreation_ground|ice_rink)$/][natural !~ /^(beach|bare_rock|cliff|peak|water)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/][barrier !~ /^(wall|retaining_wall)$/][!"piste:type"][shop!=sports] {
308 throwWarning: tr("sport without physical feature");
309 assertMatch: "node sport=tennis";
310 assertNoMatch: "node sport=tennis leisure=pitch";
311 assertNoMatch: "node sport=beachvolleyball natural=beach";
312 assertNoMatch: "node sport=skiiing landuse=piste";
313 assertNoMatch: "node sport=swimming tourism=hotel";
314 assertNoMatch: "node sport=10pin amenity=restaurant";
315}
316
317/* #10140 */
318*[building:levels][!building][!building:part] {
319 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
320}
321
322/* #10471 */
323way[waterway] > node[ford?] { set ford_on_waterway; }
324way[highway] > node[ford?] { set ford_on_highway; }
325node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
326 throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
327}
328
329/* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 */
330*[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] {
331 throwWarning: tr("alternative name without {0}", "{1.key}");
332}
333
334/* #10837 */
335way[destination][!oneway?][junction!=roundabout][highway] {
336 throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}");
337 suggestAlternative: "destination:forward";
338 suggestAlternative: "destination:backward";
339}
340
341/* #11389 */
342way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] {
343 throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");
344 suggestAlternative: "maxspeed";
345 fixChangeKey: "maxspeed:forward=>maxspeed";
346 fixRemove: "maxspeed:backward";
347}
348way["maxspeed:forward"=*maxspeed]["maxspeed:backward"=*maxspeed][maxspeed] {
349 throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}");
350 set AllSameMaxspeed;
351 suggestAlternative: "maxspeed";
352 fixRemove: "maxspeed:forward";
353 fixRemove: "maxspeed:backward";
354}
355way["maxspeed:forward"]["maxspeed:backward"][maxspeed]!.AllSameMaxspeed {
356 throwWarning: tr("{0} and {1} together with {2} and conflicting values", "{0.key}", "{1.key}", "{2.key}");
357}
358way["maxspeed:forward"][maxspeed][!"maxspeed:backward"],
359way["maxspeed:backward"][maxspeed][!"maxspeed:forward"] {
360 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
361}
362
363/* #11837 */
364way[layer][layer<0][bridge][bridge!=no][location!=underground][indoor!=yes][!tunnel],
365way[layer][layer>0][tunnel][tunnel!=no][location!=overground][indoor!=yes][!bridge] {
366 throwWarning: tr("Suspicious tag combination: {0} and {1}", "{2.tag}", "{0.tag}");
367}
368
369/* #12942 */
370relation[oneway][type!=route] {
371 throwWarning: tr("{0} on a relation without {1}", "{0.key}", "{1.tag}");
372}
373
374/* #9182 */
375way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) > 400] {
376 throwWarning: tr("Long waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}");
377}
378way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) <= 400] {
379 throwOther: tr("Short waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}");
380}
381
382/* #13144 */
383*[unisex=yes][female=yes][male!=yes],
384*[unisex=yes][male=yes][female!=yes] {
385 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
386}
387*[unisex=yes][female=yes][male=yes] {
388 throwWarning: tr("{0} together with {1} and {2}. Remove {1} and {2}", "{0.tag}", "{1.tag}", "{2.tag}");
389 fixRemove: "female";
390 fixRemove: "male";
391}
392*[female=yes][male=yes][!unisex][shop=hairdresser] { /* for toilets male=yes female=yes unisex=no combination is valid */
393 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
394 suggestAlternative: "unisex=yes";
395 fixRemove: "female";
396 fixRemove: "male";
397 fixAdd: "unisex=yes";
398}
399
400/* #13138 */
401area:closed[water][natural!=water][water!=intermittent] { /* water=intermittent is deprecated and has an own warning */
402 throwWarning: tr("{0} without {1}", "{1.key}", "{2.tag}");
403 fixAdd: "natural=water";
404}
405way!:closed[water][natural!=water][water!=intermittent] {
406 throwWarning: tr("{0} without {1}", "{1.key}", "{2.tag}");
407}
408
409/* see #8519, #11529, limited to motorways and trunks to avoid false positives for streets with lanes for non motorized traffic */
410way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][turn:lanes ][tag(lanes)!=eval(count(split("|", tag("turn:lanes"))))],
411way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][change:lanes ][tag(lanes)!=eval(count(split("|", tag("change:lanes"))))],
412way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][maxspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("maxspeed:lanes"))))],
413way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][minspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("minspeed:lanes"))))],
414way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:lanes"))))],
415way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:ref:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:ref:lanes"))))],
416way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:symbol:lanes][tag(lanes)!=eval(count(split("|", tag("destination:symbol:lanes"))))] {
417 throwWarning: tr("Different number of lanes in the keys {0} and {1}", "{1.key}", "{2.key}");
418}
419
420/* #13680 */
421area[golf=bunker][natural=beach] {
422 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
423 suggestAlternative: "natural=sand";
424 suggestAlternative: "surface=sand";
425}
Note: See TracBrowser for help on using the repository browser.