source: josm/trunk/data/validator/combinations.mapcss@ 8077

Last change on this file since 8077 was 8077, checked in by Klumbumbus, 9 years ago

fix #9389 - add validator warning for :forward and :backward in oneways; add validator info for lanes:backward without lanes:forward and vice versa

  • Property svn:eol-style set to native
File size: 11.7 KB
RevLine 
[6548]1/* Rules partially derived from Taginfo statistics - see ticket #5017
2 * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000;
3 */
4
[7229]5/* {0.key} without {1.key} (warning level) */
[7906]6way[junction ][!highway][junction!=yes],
[6548]7*[lanes ][!highway],
8*[lcn ][!highway],
9*[living_street ][!highway],
10*[maintenance ][!highway],
11*[median ][!highway],
12*[motorroad ][!highway],
13*[ntd_id ][!highway],
14*[sac_scale ][!highway],
15*[sidewalk ][!highway],
16*[step_count ][!highway],
17*[tracktype ][!highway],
18*[trail_visibility ][!highway],
19*[trolley_wire ][!highway],
20*[zip_left ][!highway],
21*[zip_right ][!highway],
[6812]22*[detail ][!railway][route!=railway],
23*[eddy_current_brake ][!railway][route!=railway],
24*[electrified ][!railway][route!=railway],
25*[etcs ][!railway][route!=railway],
26*[gauge ][!railway][route!=railway],
27*[grade_of_track ][!railway][route!=railway],
28*[kursbuchstrecke ][!railway][route!=railway],
29*[lzb ][!railway][route!=railway],
30*[old_railway_operator ][!railway][route!=railway],
31*[operating_procedure ][!railway][route!=railway],
32*[pzb ][!railway][route!=railway],
33*[radio ][!railway][route!=railway],
34*[structure_gauge ][!railway][route!=railway],
35*[tilting_technology ][!railway][route!=railway],
36*[track_class ][!railway][route!=railway],
37*[tracks ][!railway][route!=railway],
38*[traffic_mode ][!railway][route!=railway],
39*[usage ][!railway][route!=railway],
40*[workrules ][!railway][route!=railway],
[6548]41*[stream ][!waterway],
42*[length_unit ][!waterway],
43*[llid ][!waterway],
44*[canal ][!waterway],
45*[have_riverbank ][!waterway],
46*[border_type ][!boundary],
[7490]47*[bridge:structure ][!bridge],
[6548]48*[source:date ][!source],
49*[source:name ][!name],
50*[source:maxspeed:forward ][!maxspeed:forward],
51*[source:maxspeed:backward ][!maxspeed:backward],
52*[source:maxspeed:forward ][!source:maxspeed:backward],
53*[source:maxspeed:backward ][!source:maxspeed:forward],
54*[source:building ][!building],
55*[source:ref ][!ref],
56*[source:population ][!population],
57*[source:postal_code ][!postal_code],
58*[source:ele ][!ele],
59*[source:ref:INSEE ][!ref:INSEE],
60*[source:lit ][!lit],
61*[source:hgv ][!hgv],
62*[source:highway ][!highway],
63*[source:maxaxleload ][!maxaxleload],
64*[source:surface ][!surface],
65*[source:bridge ][!bridge],
66*[source:old_name ][!old_name],
67*[source:bicycle ][!bicycle],
68*[source:designation ][!designation],
69*[source:height ][!height],
70*[source:lanes ][!lanes],
[6645]71*[source:postcode ][!addr:postcode],
72*[source:housenumber ][!addr:housenumber],
73*[source:addr:postcode ][!addr:postcode],
74*[source:addr:housenumber ][!addr:housenumber],
[6548]75*[source:addr ][!/^addr:/],
76*[source:maxspeed ][!/^maxspeed:?/] {
77 throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
78 assertMatch: "way lanes=42";
79 assertNoMatch: "way lanes=42 highway=unclassified";
80 assertMatch: "node source:addr:postcode=postman";
81 assertMatch: "node source:addr=postman";
82 assertNoMatch: "node source:addr=postman addr:housenumber=42";
83}
84
[7229]85/* {0.key} without {1.key} (info level) */
[8077]86*[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1],
87*[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1],
[7229]88*[leaf_type ][!leaf_cycle],
89*[leaf_cycle][!leaf_type] {
90 throwOther: tr("{0} without {1}", "{0.key}", "{1.key}");
91}
92
[6548]93/* {0.key} without {1.tag} */
94*[fence_type ][barrier!=fence],
95*[recycling_type ][amenity!=recycling],
[7996]96*[information ][tourism!=information],
[6548]97*[board_type ][information!=board],
98*[shelter_type ][amenity!=shelter],
99*[lamp_type ][highway!=street_lamp],
100*[map_type ][information!=map],
101*[site_type ][historic!=archaeological_site],
102*[artwork_type ][tourism!=artwork],
103*[castle_type ][historic!=castle],
104*[reservoir_type ][landuse!=reservoir][water!=reservoir],
[7490]105*[bridge:movable ][bridge!=movable],
[8057]106*[parking ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/]
[6548]107*[bunker_type ][military!=bunker] {
108 throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
109}
110
[7923]111/* {0.tag} without {1.key} */
[7996]112*[tourism=information][!information],
[7929]113*[aeroway=terminal][!building],
[7967]114*[power=generator][!generator:source],
[7929]115*[amenity=place_of_worship][!religion] {
[7923]116 throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
117}
118
[6548]119/* {0.key} without {1.key} or {2.key} */
120*[incline ][!highway][!railway],
121*[oneway ][!highway][!railway] {
122 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
123}
124
125/* {0.key} without {1.key} or {2.tag} */
[8057]126*[smoothness ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
[7286]127*[segregated ][!highway][railway!=crossing],
[8057]128*[boat ][!waterway][natural!=water] {
[6548]129 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}");
130}
131
[8057]132/* {0.key} without {1.key}, {2.tag} or {3.tag} */
133*[intermittent ][!waterway][natural!~/^(water|spring)$/][ford!=yes] {
134 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}");
[7767]135}
136
[6880]137/* {0.key} without {1.key}, {2.key} or {3.key} */
138*[snowplowing ][!highway][!amenity][!leisure] {
139 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}");
140}
141
[7250]142/* {0.key} without {1.key}, {2.key} or {3.tag} */
143*[toll ][!highway][!barrier][route!~/^(ferry|road)$/] {
144 throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}");
145}
146
[7818]147/* {0.key} together with {1.key}, see #10837 */
[8043]148*[noname?][name] {
[7818]149 throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
150}
151
[8077]152/* {0.tag} together with {1.key}, see #9389 */
153*[oneway=yes][/:backward/],
154*[oneway=yes][/:forward/],
155*[oneway=-1 ][/:backward/],
156*[oneway=-1 ][/:forward/] {
157 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
158}
159
[8044]160/* {0.tag} together with {1.tag} (info level), see #9696 */
161*[highway=footway][oneway=no] {
162 throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
163}
164
[8054]165/* only {0.key}, see #11104 */
166*[area][eval(number_of_tags()) = 1],
167*[name][eval(number_of_tags()) = 1],
168*[ref][eval(number_of_tags()) = 1] {
169 throwWarning: tr("incomplete object: only {0}", "{0.key}");
170}
171/* only {0.key} and {1.key}, see #11104 */
172*[name][area][eval(number_of_tags()) = 2],
173*[name][ref][eval(number_of_tags()) = 2] {
174 throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}");
175}
176
[8043]177/* see #9811 */
[8049]178*[place][place!=farm][/^addr:/],
[8043]179*[boundary][/^addr:/],
180*[highway][/^addr:/] {
181 throwWarning: tr("{0} together with addr:*", "{0.key}");
182}
183
[8042]184/* see #9195 */
185*[highway=footway][cycleway=lane] {
186 throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
[8046]187 suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes";
[8042]188}
189
[6548]190/* {0} on suspicious object */
191*[tunnel ][!highway][!railway][!waterway][public_transport != platform][man_made != pipeline],
192*[bridge ][!highway][!railway][!waterway][!piste:type][public_transport != platform][man_made !~ /^(bridge|pipeline)$/][building != bridge],
193*[psv ][!highway][!railway][!waterway][amenity !~ /^parking.*/],
194*[width ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance],
[7032]195*[maxspeed][!highway][!railway][traffic_sign !~ /^(.*;)?maxspeed(;.*)?$/][type != enforcement][waterway !~ /^(river|canal|lock)$/],
[7727]196*[lit ][!highway][!railway][!piste:type][amenity !~ /^(parking|shelter)/][public_transport!=platform][advertising!=billboard][!leisure][!tourism] {
[6548]197 throwWarning: tr("{0} on suspicious object", "{0.key}");
198}
199
[7932]200node[amenity =~ /^(restaurant|cafe|fast_food)$/][!name][noname!=yes] {
[6548]201 throwOther: tr("restaurant without name");
202 assertMatch: "node amenity=restaurant";
[7932]203 assertNoMatch: "node amenity=restaurant noname=yes";
[6548]204 assertNoMatch: "node amenity=restaurant name=Foobar";
205}
206
[6550]207way[highway][barrier],
[6548]208*[highway][waterway][waterway!=dam],
[7265]209way[highway][natural],
[6548]210*[landuse][building] {
211 throwWarning: tr("{0} used with {1}", "{0.key}", "{1.key}");
[7265]212 assertNoMatch: "node highway=street_lamp natural=birds_nest note=josm#10193";
[6548]213}
214
215*[natural=water][leisure=swimming_pool],
216*[natural=water][amenity=swimming_pool] {
217 /* see #6932 */
218 throwWarning: tr("natural water used for swimming pool");
[7274]219 fixRemove: "natural";
[6548]220}
[6860]221
[7818]222/* see #9593 */
[7925]223*[sport][!building][tourism != hotel][highway != raceway][leisure !~ /^(sports_centre|stadium|track|pitch|golf_course|water_park|swimming_pool|recreation_ground)$/][natural !~ /^(beach|bare_rock|peak)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/] {
[6860]224 throwWarning: tr("sport without physical feature");
225 assertMatch: "node sport=tennis";
226 assertNoMatch: "node sport=tennis leisure=pitch";
227 assertNoMatch: "node sport=beachvolleyball natural=beach";
228 assertNoMatch: "node sport=skiiing landuse=piste";
229 assertNoMatch: "node sport=swimming tourism=hotel";
230 assertNoMatch: "node sport=10pin amenity=restaurant";
[7243]231}
232
233/* see #10140 */
234*[building:levels][!building][!building:part] {
235 throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
236}
[7488]237
238/* see #10471 */
239way[waterway] > node[ford?] { set ford_on_waterway; }
240way[highway] > node[ford?] { set ford_on_highway; }
241node[ford?]!.ford_on_waterway, node[ford?]!.ford_on_highway {
242 throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
243}
[7818]244
[7872]245/* any other *_name tag (except old_name, loc_name and uic_name) but not a name , see #10837 */
246*[/_name$/][!name][!old_name][!loc_name][!uic_name] {
[7818]247 throwWarning: tr("alternative name without {0}", "{1.key}");
248}
249
250/* see #10837 */
251way[destination][!oneway?] {
252 throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}");
253 suggestAlternative: "destination:forward";
254 suggestAlternative: "destination:backward";
255}
Note: See TracBrowser for help on using the repository browser.