Ticket #19792: 19792.patch

File 19792.patch, 1.7 KB (added by GerdP, 4 years ago)

work in progress, slows down processing but solves problem with undo/redo. Seems that ConflictResolver is not properly initiated with the populate() method

  • src/org/openstreetmap/josm/gui/conflict/pair/properties/PropertiesMerger.java

     
    463463
    464464    @Override
    465465    public void decideRemaining(MergeDecisionType decision) {
    466         if (!model.isDecidedCoord()) {
     466        if (!model.isDecidedDeletedState()) {
    467467            model.decideDeletedStateConflict(decision);
    468468        }
    469469        if (!model.isDecidedCoord()) {
  • src/org/openstreetmap/josm/gui/dialogs/ConflictDialog.java

     
    509509
    510510        @Override
    511511        public void actionPerformed(ActionEvent e) {
    512             final ConflictResolver resolver = new ConflictResolver();
    513512            final List<Command> commands = new ArrayList<>();
    514513            synchronized (this) {
    515514                for (OsmPrimitive osmPrimitive : lstConflicts.getSelectedValuesList()) {
    516515                    Conflict<? extends OsmPrimitive> c = conflicts.getConflictForMy(osmPrimitive);
    517516                    if (c != null) {
     517                        final ConflictResolver resolver = new ConflictResolver();
    518518                        resolver.populate(c);
    519519                        resolver.decideRemaining(type);
    520520                        Command cmd = resolver.buildResolveCommand();