Ticket #17040: 17040-pref-dlg.patch

src/org/openstreetmap/josm/gui/preferences/PreferenceDialog.java

@@ -42 +42 @@
 
     private final PreferenceTabbedPane tpPreferences = new PreferenceTabbedPane();
     private final ContextSensitiveHelpAction helpAction = new ContextSensitiveHelpAction();
+    private final WindowEventHandler windowEventHandler = new WindowEventHandler();
     private boolean canceled;
 
     /**
@@ -83 +84 @@
         tpPreferences.buildGui();
         tpPreferences.setBorder(BorderFactory.createEmptyBorder(5, 5, 5, 5));
         c.add(buildActionPanel(), BorderLayout.SOUTH);
+        addWindowListener(windowEventHandler);
 
-        addWindowListener(new WindowEventHandler());
-
         InputMapUtils.addEscapeAction(getRootPane(), new CancelAction());
         setHelpContext(HelpUtil.ht("/Action/Preferences"));
     }
@@ -176 +176 @@
 
         public void cancel() {
             setCanceled(true);
-            setVisible(false);
-            tpPreferences.validationListeners.clear();
+            dispose();
         }
 
         @Override
@@ -201 +200 @@
             }
 
             tpPreferences.savePreferences();
-            tpPreferences.validationListeners.clear();
             setCanceled(false);
-            setVisible(false);
+            dispose();
         }
     }
 
@@ -213 +211 @@
             new CancelAction().cancel();
         }
     }
+
+    @Override
+    public void dispose() {
+        removeWindowListener(windowEventHandler);
+        super.dispose();
+    }
 }