Ticket #13948: validator_seems_to_hang_3.patch

src/org/openstreetmap/josm/gui/dialogs/validator/ValidatorTreePanel.java

@@ -104 +104 @@
                 removeKeyListener(keyListener);
             }
         }
+        addDataSetListener();
+    }
+
+    private void addDataSetListener() {
+        if (getErrors().isEmpty())
+            return;
         DataSet ds = Main.getLayerManager().getEditDataSet();
         if (ds != null) {
             ds.addDataSetListener(this);
@@ -302 +308 @@
      */
     public final void setErrorList(List<TestError> errors) {
         this.errors = errors;
+        addDataSetListener();
         if (isVisible()) {
             buildTree();
         }
@@ -320 +327 @@
                 errors.add(error);
             }
         }
+        addDataSetListener();
         if (isVisible()) {
             buildTree();
         }
@@ -436 +444 @@
     }
 
     @Override public void primitivesRemoved(PrimitivesRemovedEvent event) {
-        // Remove purged primitives (fix #8639)
-        for (TestError err : errors) {
-            try {
-                err.getPrimitives().removeAll(event.getPrimitives());
-            } catch (UnsupportedOperationException e) {
-                if (event.getPrimitives().containsAll(err.getPrimitives())) {
-                    err.getPrimitives().clear();
-                } else {
-                    Main.warn(e, "Unable to remove primitives from "+err+'.');
-                }
-            }
-        }
+        // Remove errors which list of primitives refer to purged primitives (fix #8639)
+        setErrorList(errors.stream()
+                .filter(err -> event.getPrimitives().stream().noneMatch(prim -> err.getPrimitives().contains(prim)))
+                .collect(Collectors.toList()));
     }
 
     @Override public void primitivesAdded(PrimitivesAddedEvent event) {