Modify

Opened 3 years ago

Closed 2 years ago

Last modified 4 months ago

#9811 closed enhancement (fixed)

Validator: addr-tags should be shown as error on any object with highway=*

Reported by: stephan75 Owned by: team
Priority: normal Milestone: 15.02
Component: Core validator Version:
Keywords: Cc:

Description

By checking postalcodes in Germany I came accross many ways with highway=* and some addr-tags. mainly addr:postalcode=XXXX

This is wrong, because an addr-tags on any highway is not logical in OSM tagging schema.

(Alternatively you can add a postal_code=XXX tag to any highway that indicates this way belonging to a certain postalcode district ... but this is almost deprecated IMHO)

To visualize the "wrong" existing OSM data, go to http://operpass-turbo.eu ... zoom to any area you want to investigate, use Wizard feature there and type the following in the query form:

highway=* and "addr:postcode"=*

(try further "addr:street" or "addr:city" or other established addr-tags there)

So please show an error or warning in JOSM Validator results on those objects.

Attachments (0)

Change History (12)

comment:1 Changed 3 years ago by stephan75

After investigating more data via overpass-turbo.eu I would extend the validators warning even to:

addr:* and boundary=*

addr:* and place=*

comment:2 Changed 2 years ago by stephan75

With great pleasure I can see first changes in JOSM 7906 from end of December 2014:

Validator gives an alert about addr:street=* and highway=* on any object ... Thanks a lot!!

Let's see about any effect on the OSM database ... what about then trying the other "faulty" combinations?

comment:3 Changed 2 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8043/josm:

fix #9811 - add validator warning for addr:*=* together with highway, place or boundary

comment:4 Changed 2 years ago by Klumbumbus

Milestone: 15.02

comment:5 Changed 2 years ago by naoliv

Should the test ignore place=farm?

comment:6 Changed 2 years ago by Klumbumbus

I thought about it and kept it in, because I did not find it on taginfo for place=farm. However there are 416 nodes and 20 ways with place=farm + addr:housenumber. http://overpass-turbo.eu/s/7Ce

Last edited 2 years ago by Klumbumbus (previous) (diff)

comment:7 Changed 2 years ago by Klumbumbus

In 8049/josm:

see #9811 - improve validator warning for addr:*=* together with place

comment:8 Changed 2 years ago by anonymous

highway=bus_stop with addr:housenumber is used often by some; the location of a stop can be and is sometimes referenced as "stop at Foostreet 32", their names may not help in finding them. Such combinations shouldn't be tagged as warning.

comment:9 Changed 2 years ago by naoliv

Should also ignore highway=services and highway=rest_area?

comment:10 in reply to:  8 Changed 2 years ago by Klumbumbus

Replying to anonymous:

highway=bus_stop with addr:housenumber is used often by some; the location of a stop can be and is sometimes referenced as "stop at Foostreet 32", their names may not help in finding them. Such combinations shouldn't be tagged as warning.

A bus stop does not have an address. You should map the address as own object.

comment:11 Changed 2 years ago by Klumbumbus

In 8245/josm:

see #9811 - do not warn about address tags on highway=services|rest_area

comment:12 Changed 4 months ago by Klumbumbus

In 11548/josm:

fix #14310, see #11491, see #9811 - don't warn about addr:postcode together with place=* (used this way in some countries)

(If this combination is "wrong" in your country you can add a country specific rule at https://josm.openstreetmap.de/wiki/Rules with a territory selector.)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.