Modify

Opened 5 years ago

Closed 5 years ago

#966 closed defect (fixed)

Draw large GPS points does not work if lines between poins are drawn

Reported by: osm@… Owned by: Henry Loenwind
Priority: minor Component: Core
Version: latest Keywords: GPXLayer
Cc:

Description

If in preferences, display settings both options "Draw lines between raw gps points." and "Draw large GPS points" are marked then GPS points are not visible on track. This is regression.

Version 662. Previous version used by me was about two week old. There was no such problem there.

Attachments (1)

patch3.diff (17.1 KB) - added by Henry Loenwind 5 years ago.
GPXLayer fixes and Config dialog additions

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by Henry Loenwind

  • Keywords GPXLayer added
  • Owner changed from framm to Henry Loenwind
  • Priority changed from major to minor

oops, I broke it.

I'll supply a fix next weekend, I don't have my development environment with me and I don't want to submit an untested patch.

BTW: drawing small points while drawing lines is not needed, is it?

comment:2 Changed 5 years ago by Henry Loenwind

  • Owner changed from Henry Loenwind to anonymous
  • Status changed from new to assigned

comment:3 Changed 5 years ago by Henry Loenwind

  • Owner changed from anonymous to Henry Loenwind
  • Status changed from assigned to new

comment:4 follow-up: Changed 5 years ago by Jan Górski <osm@…>

Well, I think that question about small points between lines is a little bit rhetorical :)

comment:5 Changed 5 years ago by Henry Loenwind

Ok, here is the patch.

(1) Logic fixed
(2) More speedups with GPS tracks
(3) Added the settings to the config dialog
(4) Removed code for "triangle lines"---they are faster but just to ugly

Note:

  • "Color tracks by velocity." now imposes NO speed penalty to drawing at all.
  • Small points are only drawn when there is no lines pointing there.
  • Enabling large points will slow drawing down a little bit.
  • Same for arrow heads.
  • Same for not enabling "fast draw" for arrow heads.

Changed 5 years ago by Henry Loenwind

GPXLayer fixes and Config dialog additions

comment:6 in reply to: ↑ 4 Changed 5 years ago by Henry Loenwind

Replying to Jan Górski <osm@slimak.info>:

Well, I think that question about small points between lines is a little bit rhetorical :)

Not really. When color-lines-by-velocity is enabled, those points would be visible...

comment:7 Changed 5 years ago by ramack

  • Resolution set to fixed
  • Status changed from new to closed

patch applied in [721]

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.