regression: no automatic role added with associatedStreet

[skyper]

The automatic role adding function when adding objects to an associatedStreet relation does not work anymore.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-12-11 02:35:32
Last Changed Author: Don-vip
Revision: 6471
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-12-11 00:51:08 +0100 (Wed, 11 Dec 2013)
Last Changed Rev: 6471

Identification: JOSM/1.5 (6471 en) Linux Debian GNU/Linux 7.2 (wheezy)
Memory Usage: 434 MB / 672 MB (137 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u25-2.3.10-1~deb7u1
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (30117)
Plugin: conflation (0.1.6)
Plugin: jts (29854)
Plugin: mirrored_download (30106)
Plugin: notes (v0.6)
Plugin: reverter (30031)
Plugin: todo (29155)
Plugin: undelete (29854)
Plugin: utilsplugin2 (30017)
Plugin: wikipedia (30100)

[Don-vip]

Works for me:

Identification: JOSM/1.5 (6471 en) Windows 8 64-Bit
Memory Usage: 262 MB / 1813 MB (61 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM

Can you please attach sample file and exact steps ?

Thanks.

[skyper]

test file

[skyper]

I did test a bit and it works with a new created relations but it does not work with an existing or cloned one. Yesterday, I did clone one.

I did attach a sample file​. Please add house number eleven to "Schwarzwaldstraße".

[Don-vip]

OK thanks, I tested with node addresses, not buildings. You're sure it was working before ? I don't remember we changed anything in this area recently.

[skyper]

Replying to Don-vip:

OK thanks, I tested with node addresses, not buildings.

Does not make any difference, same problem.

You're sure it was working before ? I don't remember we changed anything in this area recently.

As far as I remember it was working a month ago. Gonna try to test with older version, but first need some time for it.

At least with "cloned" relation it did work.

[skyper]

Replying to skyper:

Replying to Don-vip:

OK thanks, I tested with node addresses, not buildings.

Does not make any difference, same problem.

You're sure it was working before ? I don't remember we changed anything in this area recently.

As far as I remember it was working a month ago. Gonna try to test with older version, but first need some time for it.

Yes, with josm-tested.jar aka r6388 it works with above example. Simply adding the object and it automatically gets a role.

[Don-vip]

Strange, this regression is a side effect of r6464 (the addition of relation to address preset type). I don't understand why right now.

[Don-vip]

In 6478/josm:

fix #9420 - Robustness on suggested roles in relation editor for relations matching several presets (rare regression from r6464)

[stoecker]

Milestone renamed