Modify

Opened 11 years ago

Closed 11 years ago

#8599 closed defect (fixed)

Remote command add_way does not close a way when the first and last node have same coordinates

Reported by: coso Owned by: akks
Priority: normal Milestone:
Component: Core remotecontrol Version: tested
Keywords: remote add_way Cc:

Description

This command creates a way of four nodes, with tag building=yes, where the first and last nodes have the same coordinates:

http://localhost:8111/add_way?way=45.437213,-2.810792;45.437988,-2.455983;45.224080,-2.455036;45.223302,-2.809845;45.437213,-2.810792&addtags=building=yes

If you run Validator it reports the warnings: "Area not closed" and 2 duplicate nodes (first and last).

http://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/AddWayHandler.java?rev=4833

Attachments (0)

Change History (5)

comment:1 by akks, 11 years ago

Owner: changed from team to akks

comment:2 by akks, 11 years ago

Do all agree that the nodes should be merged in such cases?

comment:3 by Don-vip, 11 years ago

Yep :-)

comment:4 by akks, 11 years ago

Then I commit :)
Merging to existing nodes is also done, but I am not sure the code is optimal. Fell free to improve it if needed.

comment:5 by akks, 11 years ago

Resolution: fixed
Status: newclosed

In 5845/josm:

fix #8599: Remote control command add_way now creates closed ways correctly
Show old values and tooltips in add_tags dialog
All nodes added by add_node and add_way are merged with existing ones

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain akks.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.