ArrayIndexOutOfBoundsException when rendering ways

[anonymous]

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-08-18 01:31:08
Last Changed Author: jttt
Revision: 5449
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-08-17 07:45:35 +0200 (Fri, 17 Aug 2012)
Last Changed Rev: 5449

Identification: JOSM/1.5 (5449 it)
Memory Usage: 186 MB / 455 MB (58 MB allocated, but free)
Java version: 1.6.0_24, Sun Microsystems Inc., OpenJDK Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: FixAddresses (28412)
Plugin: ImageWayPoint (27852)
Plugin: ImportImagePlugin (28412)
Plugin: SimplifyArea (27905)
Plugin: buildings_tools (28529)
Plugin: continuosDownload (28375)
Plugin: contourmerge (1003)
Plugin: imageryadjust (28412)
Plugin: irsrectify (28412)
Plugin: mirrored_download (28418)
Plugin: multipoly-convert (28412)
Plugin: namemanager (28412)
Plugin: openstreetbugs (28412)
Plugin: osmarender (28412)
Plugin: plastic_laf (26605)
Plugin: reverter (28535)
Plugin: tageditor (28412)
Plugin: tagging-preset-tester (28412)
Plugin: terracer (28412)

java.lang.ArrayIndexOutOfBoundsException: 14
	at org.openstreetmap.josm.data.osm.Way.getNode(Way.java:116)
	at org.openstreetmap.josm.data.osm.WaySegment.getSecondNode(WaySegment.java:29)
	at org.openstreetmap.josm.data.osm.WaySegment.toWay(WaySegment.java:39)
	at org.openstreetmap.josm.data.osm.visitor.paint.MapPainter.drawVirtualNodes(MapPainter.java:1169)
	at org.openstreetmap.josm.data.osm.visitor.paint.StyledMapRenderer.render(StyledMapRenderer.java:234)
	at org.openstreetmap.josm.gui.layer.OsmDataLayer.paint(OsmDataLayer.java:281)
	at org.openstreetmap.josm.gui.MapView.paintLayer(MapView.java:495)
	at org.openstreetmap.josm.gui.MapView.paint(MapView.java:579)
	at javax.swing.JComponent.paintChildren(JComponent.java:866)
	at javax.swing.JComponent.paint(JComponent.java:1038)
	at javax.swing.JComponent.paintToOffscreen(JComponent.java:5138)
	at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(RepaintManager.java:1454)
	at javax.swing.RepaintManager$PaintManager.paint(RepaintManager.java:1385)
	at javax.swing.BufferStrategyPaintManager.paint(BufferStrategyPaintManager.java:318)
	at javax.swing.RepaintManager.paint(RepaintManager.java:1188)
	at javax.swing.JComponent._paintImmediately(JComponent.java:5086)
	at javax.swing.JComponent.paintImmediately(JComponent.java:4896)
	at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:783)
	at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:735)
	at javax.swing.RepaintManager.prePaintDirtyRegions(RepaintManager.java:677)
	at javax.swing.RepaintManager.access$700(RepaintManager.java:58)
	at javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1593)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:226)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:647)
	at java.awt.EventQueue.access$000(EventQueue.java:96)
	at java.awt.EventQueue$1.run(EventQueue.java:608)
	at java.awt.EventQueue$1.run(EventQueue.java:606)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:105)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:617)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:275)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:200)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:185)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:177)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:138)

[skyper]

Please, if possible, submit a step by step describtion how to reproduce this error. At least tell us your last actions before this error occured.

Thanks

[mdk]

I look into the code and it seems to be very simple:

public Node getSecondNode(){

return way.getNode(lowerIndex + 1);

}

will fail on ways with only one node.

[skyper]

Replying to mdk:

will fail on ways with only one node.

A way always needs at least two nodes, therefor a way with only one node should not exist at all. Anyway patches are always welcome.

[bastiK]

Replying to anonymous:

java.lang.ArrayIndexOutOfBoundsException: 14
                                          ^^

This suggests, that the way had more than one node.

[bastiK]

It looks like a race condition, but DataSet should be Thread save in principle.

[stoecker]

Further information when happening again would be fine.

[stoecker]

Ticket #8029 has been marked as a duplicate of this ticket.

[stoecker]

Ticket #8043 has been marked as a duplicate of this ticket.

[bastiK]

It is indeed unsafe:

• the DataSet.highlightedVirtualNodes field is set from SelectAction when user moves mouse
• It is used during painting. In the meantime the way might have changed, e.g. deleted with a shortcut.

[Don-vip]

Replying to bastiK:

It is indeed unsafe:

• the DataSet.highlightedVirtualNodes field is set from SelectAction when user moves mouse
• It is used during painting. In the meantime the way might have changed, e.g. deleted with a shortcut.

I think it's that, I just got it for the first time:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-09-06 01:31:06
Last Changed Author: bastiK
Revision: 5501
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-09-05 22:15:03 +0200 (Wed, 05 Sep 2012)
Last Changed Rev: 5501

Identification: JOSM/1.5 (5501 en)
Memory Usage: 233 MB / 247 MB (87 MB allocated, but free)
Java version: 1.7.0_07, Oracle Corporation, Java HotSpot(TM) Client VM
Operating system: Windows 7
Dataset consistency test: No problems found

Plugin: cadastre-fr (28656)
Plugin: openstreetbugs (28656)
Plugin: turnrestrictions (28656)

java.lang.ArrayIndexOutOfBoundsException: 22
	at org.openstreetmap.josm.data.osm.Way.getNode(Way.java:116)
	at org.openstreetmap.josm.data.osm.WaySegment.getSecondNode(WaySegment.java:29)
	at org.openstreetmap.josm.data.osm.WaySegment.toWay(WaySegment.java:39)
	at org.openstreetmap.josm.data.osm.visitor.paint.MapPainter.drawVirtualNodes(MapPainter.java:1169)
	at org.openstreetmap.josm.data.osm.visitor.paint.StyledMapRenderer.render(StyledMapRenderer.java:234)
	at org.openstreetmap.josm.gui.layer.OsmDataLayer.paint(OsmDataLayer.java:283)
	at org.openstreetmap.josm.gui.MapView.paintLayer(MapView.java:488)
	at org.openstreetmap.josm.gui.MapView.paint(MapView.java:572)
	at javax.swing.JComponent.paintChildren(Unknown Source)
	at javax.swing.JComponent.paint(Unknown Source)
	at javax.swing.JComponent.paintChildren(Unknown Source)
	at javax.swing.JSplitPane.paintChildren(Unknown Source)
	at javax.swing.JComponent.paint(Unknown Source)
	at javax.swing.JComponent.paintChildren(Unknown Source)
	at javax.swing.JComponent.paint(Unknown Source)
	at javax.swing.JComponent.paintToOffscreen(Unknown Source)
	at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)
	at javax.swing.RepaintManager$PaintManager.paint(Unknown Source)
	at javax.swing.RepaintManager.paint(Unknown Source)
	at javax.swing.JComponent._paintImmediately(Unknown Source)
	at javax.swing.JComponent.paintImmediately(Unknown Source)
	at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
	at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
	at javax.swing.RepaintManager.prePaintDirtyRegions(Unknown Source)
	at javax.swing.RepaintManager.access$700(Unknown Source)
	at javax.swing.RepaintManager$ProcessingRunnable.run(Unknown Source)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$200(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

I deleted a node from a building with Del key and at the same time moved the mouse over another node of the same way -> Exception.

[bastiK]

Ticket #8053 has been marked as a duplicate of this ticket.

[Don-vip]

Ticket #8065 has been marked as a duplicate of this ticket.

[skyper]

Ticket #8108 has been marked as a duplicate of this ticket.

[anonymous]

Ticket #8114 has been marked as a duplicate of this ticket.

[skyper]

Ticket #8131 has been marked as a duplicate of this ticket.

[Don-vip]

Ticket #8178 has been marked as a duplicate of this ticket.

[Don-vip]

Ticket #8179 has been marked as a duplicate of this ticket.

[Don-vip]

We need to fix this bug for the next release :)

[bastiK]

I agree, any ideas?

[Don-vip]

Replying to bastiK:

I agree, any ideas?

Not yet, I was hoping you had one :D

[Don-vip]

First idea: delay the call to data.getHighlightedVirtualNodes() in StyledMapRenderer.render() and WireframeMapRenderer.render().

If I call this method just before the for() loop, I gain between 1.2 and 1.6 ms. It does not "solve" the bug but should drastically reduce its appearance probability ?

[bastiK]

Hm, Ok... :)

What about this?

try {
 ...
} catch (Exception e) {}

[Don-vip]

We can combine the two ideas :)

[Don-vip]

Here's a big patch with these two ideas, plus a lot of refactoring. While fixing this bug, I noticed a lot of common code between MapPainter and WireframeMapRenderer.

To get all this code in a single class (AbstractMapRenderer), I merged MapPainter and StyledMapRenderer.

Let me know if it's ok to integrate the refactoring in this release or if you prefer to wait for the next development cycle.

[bastiK]

Replying to Don-vip:

Here's a big patch with these two ideas, plus a lot of refactoring. While fixing this bug, I noticed a lot of common code between MapPainter and WireframeMapRenderer.

To get all this code in a single class (AbstractMapRenderer), I merged MapPainter and StyledMapRenderer.

An alternative would be to add new classes AbstractMapPainter and WireframeMapPainter, but I think I prefer the merging.

Let me know if it's ok to integrate the refactoring in this release or if you prefer to wait for the next development cycle.

Not in the spirit of bug-fixing, but should be relatively harmless as far as I can see.

--

I guess it's not the best style to use Exception handling to get your array indices right (my idea, I know :) ). The only disadvantage seems to be, that in this part of the code, ArrayIndexOutOfBoundsExceptions will silently get caught even if they are not caused by the same issue. This seems acceptable.

Another approach would be to avoid the WaySegment class and add another data class with { Way way; Node firstNode, secondNode; int firstIdx; }. On read, it would first check, if the way still has firstIdx+2 nodes, then check if the corresponding way nodes are still the same and report changes in a more controlled manner.

[Don-vip]

In 5571/josm:

fix #7979 - fix ArrayIndexOutOfBoundsException when rendering ways with the "quick and dirty" approach, and a TODO note to code a better approach on the next development cycle