[Patch] Map icons should be less prominent when disabled or inactive

[mrwojo]

Node icons and restriction relation icons use GrayFilter.createDisabledImage(Image) to indicate that they're disabled or in an inactive layer. This not only turns them gray (yay!), it also brightens them up (boo!).

The attached patch tweaks GrayFilter's parameters so that it just converts to grayscale without the extra brightness. The result is typically closer to the dark gray we use for disabled/inactive.

[Don-vip]

Wow, I tried and find the result too dark. It's maybe just with my test case, I'll post screenshots later. You can do the same meanwhile :)

[Don-vip]

Replying to mrwojo:

This not only turns them gray (yay!), it also brightens them up (boo!).

I'm reading Java 7 ​Features and Enhancements:

Important RFEs Addressed in Java SE 7

Area: API: AWT

Synopsis: Color alpha values are now preserved by java.awt.Color.darker() and java.awt.Color.lighter() methods.

RFE: ​6783910

Did you try with Java 7 ? If it's this bug, specific to Java 6 and resolved in Java 7, we won't do anything.

[mrwojo]

active, inactive (current), inactive (patched)

[mrwojo]

Java 7, Windows Vista, tested with JOSM head and latest release.

Image attached. That's highway=traffic_signals, amenity=parking, amenity=cafe, and tourism=motel. It's not noticeable with all node icons; traffic signals and parking were prominent when switching between layers in downtown areas.

Perhaps it's a matter of tweaking the params to GrayFilter: (true, 50) is default for createDisabledImage, (false, 0) doesn't brighten (does seem too dark for traffic signals), something less than 50 would be an improvement in my opinion. (true, 20) looked good.

[stoecker]

@Don-vip: You wanted to supply data.

[Don-vip]

Thanks for reminding me, I recognize I forgot this.

I just tried (true, 20) and I agree I find it much better than our current behaviour :) Fix on the way !

[Don-vip]

In 5470/josm:

fix #7865 - Map icons should be less prominent when disabled or inactive (patch by mrwojo)