Some primitives drawn in active color when the layer is inactive

[mrwojo]

Swapping between two layers I noticed 3 4 minor cases where primitives are using their active color while the layer is inactive:

1. Node icon selection border. Repro: Select a highway=stop node. Switch to a different layer. Stop icon remains bordered by red selection rectangle. I'd expect either the rectangle to be rendered in gray or not rendered.
2. Area fill color. Repro: Find an area way with a fill color. Switch to a different layer. Area fill color remains as it was (it's easier to see the dark red fill of a selected area). I'd expect the area fill to be either gray or omitted.
3. Turn restriction icon selection border. Repro: Select a turn restriction relation. Switch to different layer. Turn restriction icon remains bordered by pink selection rectangle. Again, I'd expect the rectangle to be either gray or omitted.
4. Area text. Repro: Find an area with a displayed name. Switch to a different layer. The name text remains white-ish when it should be gray.

The attached patch does:

1. Inactive node icon selection: Gray.
2. Inactive area fill: Omitted. (This what's done for disabled areas. See StyledMapRenderer.java, line 118.)
3. Inactive restriction icon selection: Gray.
4. Inactive area text: Gray.

[skyper]

Replying to mrwojo:

Swapping between two layers I noticed 3 minor cases where primitives are using their active color while the layer is inactive:

Would be nice if it is only the colour. Last time I checked it was quite worse: #6518 and #6447.

[skyper]

Replying to skyper:

Replying to mrwojo:

Swapping between two layers I noticed 3 minor cases where primitives are using their active color while the layer is inactive:

Would be nice if it is only the colour. Last time I checked it was quite worse: #6518 and #6447.

Did run a quick check and I am able to move objects in inactive layers in all three cases:

1. download same object twice in different layers
2. select object
3. switch layer
4. select object
5. move object
6. switch layer
7. move object -> object in inactive layer is moved.

Guess the problem is a bit deeper.

r5345

[mrwojo]

Replying to skyper:

Would be nice if it is only the colour. Last time I checked it was quite worse: #6518 and #6447.

I took a look at those issues. They appear to be separate from this, which is purely rendering. I'll add some info to #6518 based on what I found.

[Don-vip]

In 5348/josm:

see #7864 - Improvements in rendering of primitives in inactive layers (patch by mrwojo)

[Don-vip]

Thanks for the patch.

I have integrated the points 1, 3 and 4, they were obviously bugs. Concerning the point 2, I see it as a quite fundamental change in inactive layers rendering as areas cannot be distinguished anymore.

I don't know if it's a good idea or not and would like to hear other opinions from team members.

[mrwojo]

Another possibility would be to change the fill to inactiveColor with some reasonable alpha value (the default fill alpha of 50 with dark gray isn't typically visible).

[bastiK]

Replying to mrwojo:

Another possibility would be to change the fill to inactiveColor with some reasonable alpha value (the default fill alpha of 50 with dark gray isn't typically visible).

+1, basically desaturating the colors for inactive areas would be an improvement.

[Don-vip]

In 5431/josm:

fix #7864 - desaturate the colors for inactive areas to alpha of 0.33f