#7732 closed enhancement (wontfix)
Separate error-check code from method logic
| Reported by: | Locked | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Component: | Core |
| Version: | Keywords: | ||
| Cc: |
Description
the null checks in OsmPrimitive#visitReferrers should be seaprated from the method logic
Attachments (1)
Change History (5)
Changed 12 months ago by Locked
comment:1 Changed 12 months ago by Locked
- Type changed from defect to enhancement
comment:2 Changed 12 months ago by simon04
- Resolution set to wontfix
- Status changed from new to closed
Semantically, I don't see a difference. I don't see a problem with the current code.
Without improvement, such changes are discouraged (see DevelopersGuide/SVN_Account#RulesforJOSMaccount).
comment:3 Changed 12 months ago by Locked
Just thought it would be more readable to separate sanity null-checks from the business logic.
comment:4 Changed 12 months ago by bastiK
We don't want patches, that only change the coding style. If you change formatting, only, you are correcting someone else's work, although it's just a matter of taste. If you do change the code (but only for cosmetic reasons), it's discouraged, because it may introduce bugs. Let's focus on new features, improvements, bug fixes, documentation, unit tests, and so on.



Patch to improve the code