Modify

#7722 closed defect (fixed)

do not render junction=roundabout as area

Reported by: skyper Owned by: team
Priority: normal Component: Internal mappaint style
Version: latest Keywords: junction roundabout
Cc:

Description

Please, do not render junction=roundabout as area.

Thanks

r5241

Attachments (1)

7722.patch (3.3 KB) - added by simon04 12 months ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 12 months ago by skyper

Happens with a closed way.

A closed way with highway=* should never be treated as area unless it is tagged with area=yes.

comment:2 Changed 12 months ago by simon04

  • Resolution set to fixed
  • Status changed from new to closed

In 5247/josm:

fix #7722 - do not render junction=roundabout as area

comment:3 Changed 12 months ago by skyper

This line is outdated:
trunk/styles/standard/elemstyles.xml?rev=5247#L742

Note: junction=roundabout can be used on nodes but please never use mini_roundabouts for normal ones as these are two different things. See: http://lists.openstreetmap.org/pipermail/tagging/2012-May/010107.html

Changed 12 months ago by simon04

comment:4 follow-up: Changed 12 months ago by simon04

  • Summary changed from do not render junction=roundabout as area to [Patch] do not render junction=roundabout as area

I tried to stay away from the roundabout discussion … ;-)

skyper, I'd …

  • allow junction=roundabout on nodes + icon
  • require highway only for junctions on ways (validator)
  • remove area style for highway=turning_circle

… do you agree?

comment:5 in reply to: ↑ 4 ; follow-up: Changed 12 months ago by skyper

Replying to simon04:

I tried to stay away from the roundabout discussion … ;-)

skyper, I'd …

  • allow junction=roundabout on nodes + icon
  • require highway only for junctions on ways (validator)
  • remove area style for highway=turning_circle

… do you agree?

Thanks, that is fine, but please delete the second part of source:trunk/styles/standard/elemstyles.xml?rev=5247#L742.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 12 months ago by simon04

Replying to skyper:

Thanks, that is fine, but please delete the second part of source:trunk/styles/standard/elemstyles.xml?rev=5247#L742.

Already covered in the patch. :-)

comment:7 Changed 12 months ago by simon04

In 5250/josm:

fix #7722 - update roundabout-related styles/presets/checks.

  • allow junction=roundabout on nodes + icon
  • require highway only for junctions on ways (validator)
  • remove area style for highway=turning_circle

comment:8 in reply to: ↑ 6 Changed 12 months ago by skyper

Replying to simon04:

Replying to skyper:

Thanks, that is fine, but please delete the second part of source:trunk/styles/standard/elemstyles.xml?rev=5247#L742.

Already covered in the patch. :-)

Sorry, should have look at it. :-)

comment:9 Changed 12 months ago by skyper

  • Summary changed from [Patch] do not render junction=roundabout as area to do not render junction=roundabout as area

comment:10 Changed 12 months ago by skyper

Ticket #7755 has been marked as a duplicate of this ticket.

comment:11 follow-up: Changed 12 months ago by skyper

  • Resolution fixed deleted
  • Status changed from closed to reopened

Now all roundabouts are rendered white instead of the colour according to highway=*

We do not have to evaluate junction=roundabout for rendered colour but simple stick to the highway rendering.

EDIT: It is also not possible to use the preset for several ways forming a circle.

Last edited 12 months ago by skyper (previous) (diff)

comment:12 in reply to: ↑ 11 Changed 12 months ago by simon04

Replying to skyper:

Now all roundabouts are rendered white instead of the colour according to highway=*

We do not have to evaluate junction=roundabout for rendered colour but simple stick to the highway rendering.

So basically, we only render roundabouts on nodes? The oneway arrows are determined differently.

comment:13 Changed 11 months ago by simon04

Ticket #7764 has been marked as a duplicate of this ticket.

comment:14 Changed 11 months ago by simon04

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5274/josm:

fix #7722 - do not render junction=roundabout in white

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.