upload=false prevents merging

[pnorman]

upload=false currently prevents merging with another layer. It should warn when merging a layer like it does when uploading.

I would suggest not warning when someone tries to merge a single object. The most common use case for upload=false is an import source like CanVec and merging a single object should not generate a warning, as this is the correct way to handle the data.

Additionally, JOSM will suggest that you upload an upload=false layer when quitting. It should never suggest this, but suggest saving instead.

[Don-vip]

Replying to pnorman:

upload=false currently prevents merging with another layer. It should warn when merging a layer like it does when uploading.

Actually this was intentional to prevent merging "upload=false" layers with normal layers. It should be no problem to merge two layers of the same type. But a warning instead of a restriction sounds good to me too.

I would suggest not warning when someone tries to merge a single object. The most common use case for upload=false is an import source like CanVec and merging a single object should not generate a warning, as this is the correct way to handle the data.

Agreed.

Additionally, JOSM will suggest that you upload an upload=false layer when quitting. It should never suggest this, but suggest saving instead.

Agreed too.

[Don-vip]

In 5233/josm:

fix #7684 - Various improvements in "upload=false" layers handling