[Patch] Splash screen displays `logo.png` from working directory

[simon04]

To reproduce:

1. Put any image logo.png in the working directory
2. Launch JOSM
3. Notice that the image from 1. is displayed instead of the JOSM's logo.

[stoecker]

Actually that is a feature, so it is possible to replace the in-file icons. Thought probably it has security drawbacks.

[bastiK]

Replying to stoecker:

Actually that is a feature, so it is possible to replace the in-file icons. Thought probably it has security drawbacks.

I think we should disable this feature.

If someone wants to replace preset or map images, they can can configure icon paths in the preferences. Are there really users who want to replace the logo and other GUI icons? An Einstein-option should suffice in this case.

[skyper]

Replying to bastiK:

Replying to stoecker:

Actually that is a feature, so it is possible to replace the in-file icons. Thought probably it has security drawbacks.

I think we should disable this feature.

If someone wants to replace preset or map images, they can can configure icon paths in the preferences. Are there really users who want to replace the logo and other GUI icons? An Einstein-option should suffice in this case.

There is the debian package ​openstreetmap-map-icons but I do not really know how it is used.

[bastiK]

They patch the source code, to make it work:
​http://anonscm.debian.org/gitweb/?p=pkg-osm/josm.git;a=blob;f=debian/patches/02-elemstyles.patch;h=b826168613a6876883ef370a6d63f653e689bcba;hb=HEAD

[stoecker]

In 5946/josm:

fix #7658 - don't load icons from user relative paths (require explicit path settings)