Modify

#7616 closed defect (fixed)

NPE when replacing address nodes with buildings

Reported by: Cobra Owned by: joshdoe
Priority: major Component: Plugin conflation
Version: latest Keywords: template_report
Cc:

Description

What steps will reproduce the problem?

  1. open the attached .osm file (I purged all irrelevant objects)
  2. select the address nodes, freeze as reference
  3. select the buildings, freeze as subject
  4. click replace geometry

What is the expected result?
House numbers (and relation memberships) get assigned to the buildings

What happens instead?
NPE, nothing else

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-04-15 01:30:59
Last Changed Author: Don-vip
Revision: 5187
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-04-15 00:25:21 +0200 (Sun, 15 Apr 2012)
Last Changed Rev: 5187

Identification: JOSM/1.5 (5187 en)
Memory Usage: 340 MB / 1820 MB (102 MB allocated, but free)
Java version: 1.6.0_31, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: FastDraw (28167)
Plugin: FixAddresses (27907)
Plugin: HouseNumberTaggingTool (27865)
Plugin: ImportImagePlugin (27906)
Plugin: InfoMode (27981)
Plugin: PicLayer (27883)
Plugin: alignways (27852)
Plugin: buildings_tools (27984)
Plugin: conflation (0.1.1)
Plugin: contourmerge (1003)
Plugin: jts (28210)
Plugin: licensechange (27964)
Plugin: measurement (27957)
Plugin: mirrored_download (28108)
Plugin: openstreetbugs (27852)
Plugin: openvisible (27852)
Plugin: pbf (27649)
Plugin: pdfimport (27867)
Plugin: proj4j (27902)
Plugin: restart (27852)
Plugin: reverter (28089)
Plugin: terracer (27852)
Plugin: undelete (27852)
Plugin: utilsplugin2 (28222)

java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.conflation.ConflationToggleDialog$ConflationAction.actionPerformed(ConflationToggleDialog.java:224)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
	at java.awt.Component.processMouseEvent(Component.java:6290)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:6055)
	at java.awt.Container.processEvent(Container.java:2039)
	at java.awt.Component.dispatchEventImpl(Component.java:4653)
	at java.awt.Container.dispatchEventImpl(Container.java:2097)
	at java.awt.Component.dispatchEvent(Component.java:4481)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4575)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4236)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4166)
	at java.awt.Container.dispatchEventImpl(Container.java:2083)
	at java.awt.Window.dispatchEventImpl(Window.java:2482)
	at java.awt.Component.dispatchEvent(Component.java:4481)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:648)
	at java.awt.EventQueue.access$000(EventQueue.java:84)
	at java.awt.EventQueue$1.run(EventQueue.java:607)
	at java.awt.EventQueue$1.run(EventQueue.java:605)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
	at java.awt.EventQueue$2.run(EventQueue.java:621)
	at java.awt.EventQueue$2.run(EventQueue.java:619)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:618)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Attachments (1)

7616.osm (11.3 KB) - added by Cobra 13 months ago.

Download all attachments as: .zip

Change History (3)

Changed 13 months ago by Cobra

comment:1 Changed 13 months ago by joshdoe

Ah, you first need to select an entry from the list before clicking replace geometry. But yes, NPEs are bad, so I'll add a check to disable that button unless an entry is selected. Or maybe I should select the first entry by default? Also, I'd greatly appreciate you giving some feedback, either on #7374 or http://wiki.openstreetmap.org/wiki/JOSM/Plugins/Conflation. I've had zero feedback, which is part of why I haven't put much effort into this plugin yet. Feedback will motivate me. :)

comment:2 Changed 13 months ago by Cobra

  • Resolution set to fixed
  • Status changed from new to closed

this is fixed now.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.