Opened 13 months ago
Closed 13 months ago
#7588 closed defect (duplicate)
[Patch] Negative incline value displays wrong direction arrows
| Reported by: | anonymous | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Component: | Core |
| Version: | tested | Keywords: | incline |
| Cc: | bastiK, stoecker |
Description
As it should, incline=down displays (for an unselected way) arrows correctly in reverse direction to the way.
However, negative incline values like incline=-10° or incline=-10% display the inclination arrows in the same direction as positive values, while they should be reversed just like with incline=down.
Attachments (1)
Change History (7)
Changed 13 months ago by simon04
comment:1 follow-up: ↓ 2 Changed 13 months ago by simon04
- Cc bastiK stoecker added
- Summary changed from Negative incline value displays wrong direction arrows to [Patch] Negative incline value displays wrong direction arrows
comment:2 in reply to: ↑ 1 ; follow-ups: ↓ 3 ↓ 4 Changed 13 months ago by skyper
Replying to simon04:
Fixed in the attached patch (allows to use regular expressions for reversedDirectionKeys and directionKeys).
stoecker, bastiK: Shall we apply this patch in the stabilization phase?
Not sure if needed. Incline rendering is broken for years now, just add oneway=yes to your way with incline=-10% and have a look !
comment:3 in reply to: ↑ 2 Changed 13 months ago by simon04
comment:4 in reply to: ↑ 2 ; follow-up: ↓ 5 Changed 13 months ago by anonymous
Replying to skyper:
Replying to simon04:
Fixed in the attached patch (allows to use regular expressions for reversedDirectionKeys and directionKeys).
stoecker, bastiK: Shall we apply this patch in the stabilization phase?
Not sure if needed. Incline rendering is broken for years now, just add oneway=yes to your way with incline=-10% and have a look !
Yeah, would be better to fix the underlying rendering problem. But that's been there for 5 years, hasn't happened yet, and is a lot more effort than the small patch that has practical value.
I would rather add the small patch to the broken system to make it at least little less broken, than wait for a larger rewrite, unless there is active effort to atually fixing it.
comment:5 in reply to: ↑ 4 Changed 13 months ago by skyper
Replying to anonymous:
Yeah, would be better to fix the underlying rendering problem. But that's been there for 5 years, hasn't happened yet, and is a lot more effort than the small patch that has practical value.
I would rather add the small patch to the broken system to make it at least little less broken, than wait for a larger rewrite, unless there is active effort to atually fixing it.
Ok I got it.
@ simon04:
Do not forget this one.
comment:6 Changed 13 months ago by simon04
- Resolution set to duplicate
- Status changed from new to closed
Closed as duplicate of #5983.
Fixed in the attached patch (allows to use regular expressions for reversedDirectionKeys and directionKeys).
stoecker, bastiK: Shall we apply this patch in the stabilization phase?