Join node cursor problems with Ctrl

[joshdoe]

The join node cursor image doesn't always show properly. It seems to only show while moving the cursor, but not while stationary, causing a blinking effect. Additionally while moving a way the join node cursor image is shown if the pointer is near a way while Ctrl is held down.

[xeen]

I can confirm both issues. Steps to reproduce are:

1. create two single nodes
2. grab&drag one onto the other
3. press ctrl

→ merge to node cursor not shown

1. create a way and a unconnected node
2. grab way on way-part (i.e. none of its nodes; not a virtual node)
3. drag way so that the cursor is hovering the node while pressing ctrl

→ merge to node cursor is shown

[xeen]

I likely have a fix for the first issue, but I’m unsure about the second. Merging only works for nodes, so if the selection only contains ways there shouldn’t even be a merge cursor (the cross) because the merge can’t possibly find a valid target. Unless someone has a better suggestion, I’m going with disabling the merge cursor in this case altogether.

[xeen]

In 4934/josm:

likely fix #7315’s cursor issues and related target-highlight ones

[xeen]

Please reopen the ticket if the fixes do not work for you.