Download dialog always loads bing attributions

[skyper]

If I open the download dialog, the bing attributions are always loaded, even though I only use mapnik.

This is happening for month now, I did only forget to fill a ticket.

[simon04]

In the download dialog, you can select Bing as layer. I don't see any defect here.

Instead, we could cache the attribution data to avoid regular downloads.

[simon04]

Patch attached to cache the attribution data for 1 week. Are there any legal issues with this approach (e.g., is loading the attribution data required for Bing-internal statistics)?

[skyper]

Replying to simon04:

In the download dialog, you can select Bing as layer. I don't see any defect here.

Maybe I was not clear:

It is loaded without selecting the bing layer. It is not needed for all other layers and should not be loaded if not needed.

[bastiK]

I'd say with 1 day caching, no one can complain. The original bug remains.

[simon04]

Caching + loading on demand (in 7284_v2.patch) should take care of all. :-)

[simon04]

Fixed in ​[o27483].

[skyper]

Replying to simon04:

Fixed in ​[o27483].

This was fast !

Thanks

[bastiK]

The changeset is ok, but it exposes other problems: #7289

[bastiK]

JOSM classes cannot be used in the JMapViewer Component.

[simon04]

Replying to bastiK:

JOSM classes cannot be used in the JMapViewer Component.

I realized that too late. Fixed in r4825. Sorry for the mess while fixing this ticket.

[bastiK]

See ​[o27507].

[rickmastfan67]

In continuation of ticket:7289#comment:10, the fixes don't seem to have fully fixed the problems here on my end.

As of right now in r4831, while looking in the Java Console, I never see the message stating that the Bing Attribution is fully loaded post-r4806 (r4806 was the last build I saw it in). In r4831, every time I download some data from OSM, I'm greeted with a "Error: null" message when I turn on the Bing Imagery layer (as long as I didn't have previous imagery from that area). However, if I delete the Bing layer and then hit the Bing button again, the imagery will start to download (but I don't get the "Bing Attribution has been successfully loaded message in the Java Console).

Also, it seems that post-r4806 can successfully download the Bing Attribution ONLY if it doesn't exist in your cache. If it exists, then you'll get the "Error: null" message on your first attempt of loading imagery.

Now, I don't think it's a problem with the attribution file itself because the most current copy that I have (downloaded on 01/21/12), works just fine in r4806. So, something was changed between r4806 and r4818 that is causing this problem for me (my gut says something in r4813 broke it, it's that or r4818).

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-01-21 02:32:22
Last Changed Author: bastiK
Revision: 4831
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-01-20 22:00:13 +0100 (Fri, 20 Jan 2012)
Last Changed Rev: 4831

Identification: JOSM/1.5 (4831 en)
Memory Usage: 189 MB / 2730 MB (97 MB allocated, but free)
Java version: 1.6.0_30, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Windows 7
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (27355)
Plugin: buildings_tools (27355)
Plugin: imageryadjust (27494)
Plugin: licensechange (27472)
Plugin: mapdust (27355)
Plugin: measurement (27289)
Plugin: openstreetbugs (27355)
Plugin: restart (27289)
Plugin: reverter (27393)
Plugin: turnrestrictions (27355)
Plugin: undelete (27395)
Plugin: utilsplugin2 (27516)

[simon04]

The reason that "Successfully loaded Bing attribution data." isn't shown is that the message is only printed, if the attribution data is loaded from the web. Instead, if it comes from the cache, no message is shown.

The "Error: null" errors are of course not expected … I'm investigating.

[simon04]

See ​[o27519].

[skyper]

It seems to work but I get strange messages on the console:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-01-30 02:32:23
Last Changed Author: stoecker
Revision: 4878
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-01-30 00:02:54 +0100 (Mon, 30 Jan 2012)
Last Changed Rev: 4878

Warnung: Fehlende Einstellungsdatei "$HOME/.josm/preferences.xml". Datei mit Standardeinstellungen wird erstellt.
GET http://api.openstreetmap.org/api/capabilities... OK
Successfully loaded Bing attribution data.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
Bing: attribution data is not yet loaded.
GET http://api.openstreetmap.org/api/0.6/map?bbox=....

[simon04]

The same issue has been reported in #7280.

[skyper]

Replying to simon04:

The same issue has been reported in #7280.

Then decide by yourself which of the two tickets can be closed and which needs to stay open.

[simon04]

Let's continue the discussion in #7280.