[patch] Validation Enhancements for water features

[oldtopos]

I've modified OverlappingAreas and CrossingWays slightly, such that OverlappingAreas reports water area features separately as Warnings rather than informational.

CrossingWays is modified to report crossing water ways separately.

These changes are a great help when validating the addition of NHD features.

[oldtopos]

diff file for validation test changes

[simon04]

The patch looks mostly fine, besides:

• remove debugging output (System.out.println)
• use consistent indentation and spacing around parenthesis (e.g., if (!isWaterArea2) {})

---

Unfortunately, all of this validation tests get very complex when adding special cases (like water areas overlaps, railway overlaps). IMHO, the way to go is to fix the cooperation between filters and validator tests (see #6195). Then, one can specifically filter for cases of interest. Thus, I'd refrain from committing this patch now.

[bastiK]

In 5550/josm:

applied #7259 - Validation Enhancements for water features (patch by oldtopos, slightly modified)