"Update data" broken (regression)

[rickmastfan67]

I'm pretty sure this is because of [4718]. This regression has all but completely broken the "Update data" feature in JOSM. This last worked in r4717.

To really see how bad this regression is, following the following steps:

1. Download 4 separate areas of data in JOSM (doesn't matter what size the areas are).
2. Then, File > Update Data.

In r4717, it updates all the data that has been downloaded right away with no user intervention, like it should. But in r4756, it refuses to update the data. When you hit the "Update Data" text in r4756, all you get is a window saying "Download Data" with "Cancel" and "In background" buttons. The "Cancel" button doesn't work, and when you hit the "In background" button, it's frozen at "Download 1 of 4 (3 left)", and the "Cancel" button on that screen doesn't work as well. If you hit the "Red X" several times, you can get the download finally going and you have to keep doing that to finally get all 4 data sections re-downloaded. Really annoying.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-01-01 02:31:59
Last Changed Author: jttt
Revision: 4756
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-12-31 15:00:49 +0100 (Sat, 31 Dec 2011)
Last Changed Rev: 4756

Identification: JOSM/1.5 (4756 en)
Memory Usage: 154 MB / 2730 MB (100 MB allocated, but free)
Java version: 1.6.0_30, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Windows 7

Plugin: OpeningHoursEditor (27355)
Plugin: buildings_tools (27355)
Plugin: imageryadjust (27355)
Plugin: licensechange (27359)
Plugin: mapdust (27355)
Plugin: measurement (27289)
Plugin: openstreetbugs (27355)
Plugin: restart (27289)
Plugin: reverter (27159)
Plugin: turnlanes (27355)
Plugin: turnrestrictions (27355)
Plugin: undelete (27243)
Plugin: utilsplugin2 (27355)

[jttt]

Fixed in r4758