Opened 17 months ago
Last modified 16 months ago
#7190 new defect
allow disabling of highlighting/cursor changes
| Reported by: | NE2 | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Component: | Core |
| Version: | Keywords: | ||
| Cc: |
Description
I may be wrong, but this feature seems to have caused major sluggishness for me. Is there a way to turn it off? If not, can you please add one? Thanks.
Attachments (1)
Change History (22)
comment:1 Changed 17 months ago by akks
comment:2 Changed 17 months ago by akks
Should I make the patch or someone already have such plans?
comment:3 Changed 17 months ago by bastiK
Go ahead, maybe we can group settings, that affect performance. (rubber line, antialiasing, highlight, ...)
comment:4 Changed 17 months ago by akks
Luckily, there was ready option "draw.target-highlight" for highlighting. I have just added it to configuration panel and grouped entries about highlighting, rubber line, antialiasing and area fill together.
Here is a patch:
Changed 17 months ago by akks
comment:5 Changed 17 months ago by akks
- Summary changed from allow disabling of highlighting/cursor changes to (patch) allow disabling of highlighting/cursor changes
comment:6 Changed 17 months ago by stoecker
Most of these options should be expert options. Can you change that?
comment:7 Changed 17 months ago by bastiK
- Summary changed from (patch) allow disabling of highlighting/cursor changes to [patch] allow disabling of highlighting/cursor changes
comment:8 Changed 17 months ago by akks
Of course I can if you give me list of options that should be "expert" :)
I do not know. For example, hiding rubber line and disabling highlighting really improve performance and may be needed for non-expert users too...
comment:9 Changed 17 months ago by stoecker
Choose yourself :-)
Everything which is not really essential, e.g. most of this visual stuff is "expert". Aim of the normal mode is to have a software which only presents essential options to the user and thus reducing the initial amount of possibilities.
Every option in the preferences has a good reason, sure. Otherwise they wouldn't be there. But as a beginner it is much harder to find 5 really important options when they are hidden between 50 "nice-to-have" options.
comment:10 Changed 17 months ago by akks
OK, but it will not be fast then :)
If anyone have ideas about specific really important options, please write it here...
comment:11 Changed 17 months ago by skyper
Thanks for your work akks.
I am often working with slow machines and I am happy about every Mb RAM I can save. I have to admit though that at least in the first world people with slow machines will probably also find the expert options. This might be totally different in other regions.
Maybe some start option would be nice to run JOSM on slow machines with these features turn off. Another solution would be to do it automatically depending on the given RAM size.
comment:12 follow-up: ↓ 16 Changed 17 months ago by akks
I have moved some prefrerence to expert mode, commiting now... I'll leave ticket open for now, maybe you notice some problems or can implement more echancements.
comment:13 Changed 17 months ago by akks
In [4767/josm]:
comment:14 Changed 17 months ago by NE2
Thanks a lot. This seems to run much better.
comment:15 Changed 16 months ago by bastiK
close?
comment:16 in reply to: ↑ 12 ; follow-ups: ↓ 18 ↓ 19 Changed 16 months ago by skyper
Replying to akks:
I have moved some prefrerence to expert mode, commiting now... I'll leave ticket open for now, maybe you notice some problems or can implement more echancements.
Is "show object ids" really an expert option ?
I still miss the option to disable the changes of the cursor. At least this is what the summary says.
comment:17 Changed 16 months ago by skyper
- Summary changed from [patch] allow disabling of highlighting/cursor changes to allow disabling of highlighting/cursor changes
comment:18 in reply to: ↑ 16 Changed 16 months ago by akks
comment:19 in reply to: ↑ 16 ; follow-up: ↓ 20 Changed 16 months ago by bastiK
Replying to skyper:
I still miss the option to disable the changes of the cursor.
Why? This won't improve the performance.
comment:20 in reply to: ↑ 19 Changed 16 months ago by skyper
comment:21 Changed 16 months ago by akks
Actually, most CPU-intense task is rendering (painting). Highligting (and sometimes rubber band) caused all the map to repaint after each mouse movement.
Next, less hard task is searching primitives under the cursor after mouse move (to change cursors, show info in statusbar, change highlighting). It is integrated with instruments and can not be easily turned off... But if it is really needed, this task can also become optional. It needs discussion.



It would be really good for slow machines or large datasets.