building inside building false positiv

[julien.balas@…]

i don't know if the validator handle incorrectly "wall=no" or if the algorithm is too strict, but ther are some false alerts.

for example
​http://www.openstreetmap.org/browse/way/81189416
and
​http://www.openstreetmap.org/browse/way/81188636

[mdk]

An other fase positive is a building inside the inner of a building multipolygon:

 _______________̣_______    MP outer
|  MP building=yes     |
|  __________________  |   MP inner
| |                  | |
| |  ______________  | |
| | |              | | |   Building inside MP inner
| | | building=yes | | |   Validator mark this as "building in building" error
| | |              | | |
| | |______________| | |
| |__________________| |
|______________________|

mdk

[skyper]

Think, this has to do with #4582.

It is always better to have a small .osm file test file, as objects might change on the server.

[mdk]

Here is an example .osm file. Just validate.

[JulienBalas]

a small test file. None of the small way "linked" to the big way should be reported as "in"

[jcr83]

Another false positive example.

[Don-vip]

In [4738/josm]:

see #7034 - building inside building false positives

[Don-vip]

Problem fixed for 7034.osm and test.osm. The first example needs another fix.

[Don-vip]

In [4747/josm]:

fix #7034 - building inside building false positives

[julien@…]

2 tests cases for a covered yard

[julien@…]

The first example "area inside mp" seems to be also fixed, a building in a yard is correctly handled.
I'v added 1 new test file about covered yard (very common in french school)
The 2 example should not trigger the rule.

[Don-vip]

In 5522/josm:

fix #7034, fix #8067 - Rework "Building inside Building" test from scratch