Apparent error computing tms tile URLs

[mackerski]

Version 4542. Computes incorrect (not present on server) tile URLs for tms tiles for the following service:

tms[5,15]:​http://geo.nls.uk/maps/ireland/gsgs4136/{zoom}/{x}/{!y}.png

Log output (sanitized to beat spam filter):

failed loading 15/15796/10608 hxxxx//geo.nls.uk/maps/ireland/gsgs4136/15/15796/5775.png
failed loading 15/15796/10609 hxxxx//geo.nls.uk/maps/ireland/gsgs4136/15/15796/5774.png
failed loading 15/15796/10607 hxxxx//geo.nls.uk/maps/ireland/gsgs4136/15/15796/5776.png
failed loading 15/15795/10608 hxxxx//geo.nls.uk/maps/ireland/gsgs4136/15/15795/5775.png
failed loading 15/15795/10609 hxxxx//geo.nls.uk/maps/ireland/gsgs4136/15/15795/5774.png
failed loading 15/15795/10607 hxxxx//geo.nls.uk/maps/ireland/gsgs4136/15/15795/5776.png
failed loading 15/15797/10608 hxxxx//geo.nls.uk/maps/ireland/gsgs4136/15/15797/5775.png
failed loading 15/15797/10609 hxxxx//geo.nls.uk/maps/ireland/gsgs4136/15/15797/5774.png
failed loading 15/15797/10607 hxxxx//geo.nls.uk/maps/ireland/gsgs4136/15/15797/5776.png

This previously worked and requested valid tiles at different URLs which are still valid.

Problem seems to occur for other services using the placeholder {!y}

[Don-vip]

Fixed in ​[o26973]. Is it enough to have a new JOSM latest build automatically ?

[stoecker]

This fix breaks Yahoo again. !y should be Yahoo format as documented and this is what I changed.

Seems your URL format is another one. Yahoo has a format, where negative values are possible. Your server simply has reversed y axis? In this case maybe we can introduce another format for these as well.

I now added {-y} in ​[o26975]. Using this your URL should work again. Also documented at Maps page.

@Don-Vip: Please no plain code reverts before asking the author.