Opened 20 months ago
Last modified 4 months ago
#6909 new enhancement
Necessity of History toggle dialog?
| Reported by: | simon04 | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Component: | Core |
| Version: | Keywords: | History toggle dialog | |
| Cc: | bastiK, stoecker |
Description
As the history dialog can be accessed through the View menu (Help/Action/ObjectHistory), I don't see the necessity of the History toggle dialog any more. Is there any? Can this toggle dialog be removed? This would also help to achieve #6731.
Attachments (1)
Change History (15)
comment:1 Changed 20 months ago by Don-vip
comment:2 Changed 20 months ago by olejorgenb
+1
I've always wondered why this was a toggle dialog. It was really annoying to waste the space (or enable/disable it for each use) before I discovered other methods of bringing up the history (eg. ctrl+h).
comment:3 Changed 20 months ago by simon04
- Cc bastiK stoecker added
Before removing this dialog, I'd like to hear the opinion of the main developers. Does the removal cause any problems?
comment:4 follow-up: ↓ 5 Changed 20 months ago by stoecker
I'm against it. Maybe this is a case for the expert/beginner mode as well.
comment:5 in reply to: ↑ 4 Changed 20 months ago by simon04
Replying to stoecker:
I'm against it. Maybe this is a case for the expert/beginner mode as well.
why wouldn't you like to have the History td removed, i.e., which feature would be missing afterwards?
comment:6 follow-ups: ↓ 7 ↓ 8 Changed 20 months ago by bastiK
I guess there have been plans to extend this dialog; but there is no reason to believe this will happen any time soon.
At the moment, the history toggle dialog seems superfluous, maybe we can hide it with history.button_hidden=true?
There is still one problem with the menu item: When a lot of objects are selected (e.g. Ctrl+A), a plenty of windows will pop up. I never had this problem with the toggle window, because it provides a "sub-selection".
comment:7 in reply to: ↑ 6 Changed 17 months ago by simon04
Replying to bastiK:
At the moment, the history toggle dialog seems superfluous, maybe we can hide it with history.button_hidden=true?
That's fine by me.
There is still one problem with the menu item: When a lot of objects are selected (e.g. Ctrl+A), a plenty of windows will pop up. I never had this problem with the toggle window, because it provides a "sub-selection".
Personally, I never used that "sub-selection" as I found it just as easy to deselect the corresponding objects directly.
Changed 16 months ago by simon04
comment:8 in reply to: ↑ 6 ; follow-up: ↓ 9 Changed 16 months ago by simon04
- Summary changed from Necessity of History toggle dialog? to [Patch] Necessity of History toggle dialog?
Replying to bastiK:
At the moment, the history toggle dialog seems superfluous, maybe we can hide it with history.button_hidden=true?
Patch attached which disables the dialog per default. It can be reactivated using the setting dialog.history.enabled.
comment:9 in reply to: ↑ 8 ; follow-up: ↓ 10 Changed 16 months ago by bastiK
Replying to simon04:
Replying to bastiK:
At the moment, the history toggle dialog seems superfluous, maybe we can hide it with history.button_hidden=true?
Patch attached which disables the dialog per default. It can be reactivated using the setting dialog.history.enabled.
Why not hide it "the normal way"? (Like from the right click menu of the button.)
comment:10 in reply to: ↑ 9 ; follow-up: ↓ 11 Changed 16 months ago by simon04
Replying to bastiK:
Why not hide it "the normal way"? (Like from the right click menu of the button.)
Good idea, but then the dialog is still selectable in the Windows menu.
comment:11 in reply to: ↑ 10 Changed 16 months ago by bastiK
Replying to simon04:
Replying to bastiK:
Why not hide it "the normal way"? (Like from the right click menu of the button.)
Good idea, but then the dialog is still selectable in the Windows menu.
Ok, haven't thought of that.
Maybe a new toggle button state: Keep it in the ">>" menu at the bottom left but only display it in the windows menu, when the button is visible on the left (i.e. history.button_hidden=false).
This new logic would apply to "expert" toggle buttons in non-expert mode and the history dialog in general.
The idea is, that it is already hidden enough in the ">>" menu, no need to hide it further.
comment:12 Changed 16 months ago by stoecker
The expert mode must not be 100%. We don't want to restrict users, we want to easy their usage experience. I don't see a problem, when the buttons are hidden in left menu, but not in windows menu.
When users start to wonder about this, it anyways gets time they check the expert button. :-)
comment:13 Changed 14 months ago by simon04
- Summary changed from [Patch] Necessity of History toggle dialog? to Necessity of History toggle dialog?
Do we want to take any action concerning the History toggle dialog?
comment:14 Changed 4 months ago by Don-vip
Ticket #7643 has been marked as a duplicate of this ticket.



I don't see any either. And I don't like this dialog because of its redundancy with Selection dialog (the list content is the same). By the way, no existing plugin seem to reference it, so it could safely be removed.