Align nodes in line should respect straight crossing lines
|Reported by:||kempelen||Owned by:||team|
The current algorithm for "Align Nodes in Line" is very simple. We use it to straighten ways that are straight in the world. If the modified street crosses other streets, which are also straight, this function makes the crossing streets not straight anymore (this is an error).
To make a part of a city straight, one needs to repeat this function on a way, and then all crossing ways that were straight, and then again and again, to minimize the error (but still, nothing but the last way will be really straight). This may affect many streets, require a lot of manual work, that could be replaced with math in JOSM.
The routine could handle this frequent "special case":
When a node, which is being moved:
- exactly 4 ways connect
- end of 2 of those are part of the straighten operation
- end of the 2 others are already in line with the node being moved
...move the node on the already straight line, by calculating the junction of the new straight line and the existing straight line.
I'll attach a screenshot where straight line gets an angle if the selected line is "aligned".